Skip to content

Commit 633ce4f

Browse files
author
Steven Orvell
committed
Add more tests.
1 parent 4e0abe4 commit 633ce4f

File tree

1 file changed

+35
-14
lines changed

1 file changed

+35
-14
lines changed

test/unit/element-disable-upgrade.html

Lines changed: 35 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,12 @@
4646
Polymer({
4747
is: 'x-attach',
4848
attached: function() {
49-
this._wasAttached = true;
49+
this._connectLog = this._connectLog || [];
50+
this._connectLog.push('attached');
5051
},
5152
detached: function() {
52-
this._wasDetached = true;
53+
this._connectLog = this._connectLog || [];
54+
this._connectLog.push('detached');
5355
}
5456
});
5557
});
@@ -177,32 +179,51 @@
177179
el = fixture('attach');
178180
});
179181
test('attached does not fire when element is not yet enabled', function() {
180-
assert.notOk(el._wasAttached);
182+
assert.notOk(el._connectLog);
181183
el.removeAttribute('disable-upgrade');
182-
assert.ok(el._wasAttached);
184+
assert.equal(el._connectLog.length, 1);
185+
assert.equal(el._connectLog[0], 'attached');
183186
});
184187
test('attached/detached do not fire when element is not yet enabled', function() {
185188
el.parentNode.removeChild(el);
186189
Polymer.dom.flush();
187-
assert.notOk(el._wasAttached);
188-
assert.notOk(el._wasDetached);
190+
assert.notOk(el._connectLog);
189191
el.removeAttribute('disable-upgrade');
190-
assert.notOk(el._wasAttached);
191-
assert.notOk(el._wasDetached);
192+
assert.notOk(el._connectLog);
192193
});
193194
test('attached/detached do not fire when element is detached/attached when not yet enabled', function() {
194195
var parent = el.parentNode;
195196
parent.removeChild(el);
196197
Polymer.dom.flush();
197-
assert.notOk(el._wasAttached);
198-
assert.notOk(el._wasDetached);
198+
assert.notOk(el._connectLog);
199199
parent.appendChild(el);
200200
Polymer.dom.flush();
201-
assert.notOk(el._wasAttached);
202-
assert.notOk(el._wasDetached);
201+
assert.notOk(el._connectLog);
202+
assert.notOk(el._connectLog);
203203
el.removeAttribute('disable-upgrade');
204-
assert.ok(el._wasAttached);
205-
assert.notOk(el._wasDetached);
204+
assert.equal(el._connectLog.length, 1);
205+
assert.equal(el._connectLog[0], 'attached');
206+
});
207+
208+
test('attached/detached fire as expected after element is enabled', function() {
209+
var parent = el.parentNode;
210+
parent.removeChild(el);
211+
Polymer.dom.flush();
212+
assert.notOk(el._connectLog);
213+
parent.appendChild(el);
214+
Polymer.dom.flush();
215+
assert.notOk(el._connectLog);
216+
el.removeAttribute('disable-upgrade');
217+
assert.equal(el._connectLog.length, 1);
218+
assert.equal(el._connectLog[0], 'attached');
219+
parent.removeChild(el);
220+
Polymer.dom.flush();
221+
assert.equal(el._connectLog.length, 2);
222+
assert.equal(el._connectLog[1], 'detached');
223+
parent.appendChild(el);
224+
Polymer.dom.flush();
225+
assert.equal(el._connectLog.length, 3);
226+
assert.equal(el._connectLog[2], 'attached');
206227
});
207228
});
208229
suite('disableUpgrade and Databinding', function() {

0 commit comments

Comments
 (0)