Merge pull request #4786 from beckysiegel/master

Update closure annotation for all paths

Author: dfreedm

externs/closure-types.js

@@ -594,25 +594,25 @@ Polymer_PropertyEffects.prototype.set = function(path, value, root){};
 */
 Polymer_PropertyEffects.prototype.push = function(path, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_PropertyEffects.prototype.pop = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {number} start Index from which to start removing/inserting.
 * @param {number} deleteCount Number of items to remove.
 * @param {...*} items 
 * @return {Array}
 */
 Polymer_PropertyEffects.prototype.splice = function(path, start, deleteCount, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_PropertyEffects.prototype.shift = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {...*} items 
 * @return {number}
 */
@@ -1102,25 +1102,25 @@ Polymer_ElementMixin.prototype.set = function(path, value, root){};
 */
 Polymer_ElementMixin.prototype.push = function(path, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_ElementMixin.prototype.pop = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {number} start Index from which to start removing/inserting.
 * @param {number} deleteCount Number of items to remove.
 * @param {...*} items 
 * @return {Array}
 */
 Polymer_ElementMixin.prototype.splice = function(path, start, deleteCount, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_ElementMixin.prototype.shift = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {...*} items 
 * @return {number}
 */
@@ -1644,25 +1644,25 @@ Polymer_LegacyElementMixin.prototype.set = function(path, value, root){};
 */
 Polymer_LegacyElementMixin.prototype.push = function(path, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_LegacyElementMixin.prototype.pop = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {number} start Index from which to start removing/inserting.
 * @param {number} deleteCount Number of items to remove.
 * @param {...*} items 
 * @return {Array}
 */
 Polymer_LegacyElementMixin.prototype.splice = function(path, start, deleteCount, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_LegacyElementMixin.prototype.shift = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {...*} items 
 * @return {number}
 */
@@ -2493,25 +2493,25 @@ Polymer_ArraySelectorMixin.prototype.set = function(path, value, root){};
 */
 Polymer_ArraySelectorMixin.prototype.push = function(path, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_ArraySelectorMixin.prototype.pop = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {number} start Index from which to start removing/inserting.
 * @param {number} deleteCount Number of items to remove.
 * @param {...*} items 
 * @return {Array}
 */
 Polymer_ArraySelectorMixin.prototype.splice = function(path, start, deleteCount, items){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @return {*}
 */
 Polymer_ArraySelectorMixin.prototype.shift = function(path){};
 /**
-* @param {string} path Path to array.
+* @param {(string|!Array.<(string|number)>)} path Path to array.
 * @param {...*} items 
 * @return {number}
 */

lib/mixins/property-effects.html

@@ -1834,7 +1834,7 @@
        * This method notifies other paths to the same array that a
        * splice occurred to the array.
        *
-       * @param {string} path Path to array.
+       * @param {string | !Array<string|number>} path Path to array.
        * @return {*} Item that was removed.
        * @public
        */
@@ -1859,7 +1859,7 @@
        * This method notifies other paths to the same array that a
        * splice occurred to the array.
        *
-       * @param {string} path Path to array.
+       * @param {string | !Array<string|number>} path Path to array.
        * @param {number} start Index from which to start removing/inserting.
        * @param {number} deleteCount Number of items to remove.
        * @param {...*} items Items to insert into array.
@@ -1894,7 +1894,7 @@
        * This method notifies other paths to the same array that a
        * splice occurred to the array.
        *
-       * @param {string} path Path to array.
+       * @param {string | !Array<string|number>} path Path to array.
        * @return {*} Item that was removed.
        * @public
        */
@@ -1918,7 +1918,7 @@
        * This method notifies other paths to the same array that a
        * splice occurred to the array.
        *
-       * @param {string} path Path to array.
+       * @param {string | !Array<string|number>} path Path to array.
        * @param {...*} items Items to insert info array
        * @return {number} New length of the array.
        * @public