Skip to content

Commit 2627e63

Browse files
author
Steven Orvell
committed
Fix more closure warnings.
1 parent b3dfd38 commit 2627e63

File tree

4 files changed

+7
-19
lines changed

4 files changed

+7
-19
lines changed

closure.log

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -514,11 +514,7 @@ Found : PropertyEffects
514514
klass.observers : [];
515515
^^^^^^^^^^^^^^^
516516

517-
/polymer.html_script_11.js:155: WARNING - Type annotation references non-existent type Objecg.
518-
* @return {Objecg} The input `flattenedProps` bag
519-
^^^^^^
520-
521-
/polymer.html_script_11.js:184: WARNING - Property prototype never defined on klass of type HTMLElement{__classProperties:?}
517+
/polymer.html_script_11.js:184: WARNING - Property prototype never defined on klass of type HTMLElement{__classProperties:Object|null}
522518
let superCtor = Object.getPrototypeOf(klass.prototype).constructor;
523519
^^^^^^^^^^^^^^^
524520

@@ -761,14 +757,6 @@ Found : PolymerElement
761757
return this.splice(arrayOrPath, index, 1);
762758
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
763759

764-
/polymer.html_script_23.js:49: WARNING - Invalid type for parameter 1 of function _mixinBehaviors.
765-
Expected : {length:?} (loose)
766-
Found : Array<?>|null
767-
More details:
768-
The found type is a union that includes an unexpected type: null
769-
klass = _mixinBehaviors(behaviors, klass);
770-
^^^^^^^^^
771-
772760
/polymer.html_script_23.js:141: WARNING - Property is never defined on this of type PolymerGenerated
773761
Polymer.DomModule.import(this.is, 'template') ||
774762
^^^^^^^
@@ -1495,4 +1483,4 @@ externs/closure-types.js:759: WARNING - property toggle on interface Polymer_Arr
14951483
Polymer_ArraySelectorMixin.prototype.toggle;
14961484
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
14971485

1498-
0 error(s), 328 warning(s), 72.6% typed
1486+
0 error(s), 326 warning(s), 72.6% typed

lib/legacy/class.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* to ensure that any legacy behaviors can rely on legacy Polymer API on
3636
* the underlying element.
3737
*
38-
* @param {Object|Array} behaviors Behavior object or array of behaviors.
38+
* @param {!(Object|Array)} behaviors Behavior object or array of behaviors.
3939
* @param {HTMLElement} klass Element class.
4040
* @return {HTMLElement} Returns a new Element class extended by the
4141
* passed in `behaviors` and also by `Polymer.LegacyElementMixin`.
@@ -110,7 +110,7 @@
110110
* @param {Array} behaviors List of behaviors to flatten.
111111
* @param {Array=} list Target list to flatten behaviors into.
112112
* @param {Array=} exclude List of behaviors to exclude from the list.
113-
* @return {Array} Returns the list of flattened behaviors.
113+
* @return {!Array} Returns the list of flattened behaviors.
114114
*/
115115
function flattenBehaviors(behaviors, list, exclude) {
116116
list = list || [];

lib/legacy/legacy-element-mixin.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@
4242

4343
/**
4444
* @constructor
45-
* @extends {base}
46-
* @implements {Polymer_GestureEventListeners}
4745
* @implements {Polymer_ElementMixin}
46+
* @implements {Polymer_GestureEventListeners}
47+
* @extends {base}
4848
*/
4949
const legacyElementBase = Polymer.GestureEventListeners(Polymer.ElementMixin(base));
5050

lib/mixins/element-mixin.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
*
171171
* @param {Object} flattenedProps Bag to collect flattened properties into
172172
* @param {Object} props Bag of properties to add to `flattenedProps`
173-
* @return {Objecg} The input `flattenedProps` bag
173+
* @return {Object} The input `flattenedProps` bag
174174
* @private
175175
*/
176176
function flattenProperties(flattenedProps, props) {

0 commit comments

Comments
 (0)