Fix warnings in tests from variants that need to exist, but don't get used (#419)

Co-authored-by: Peter Glotfelty <[email protected]>

Author: Peternator7

strum_macros/src/macros/strings/as_ref_str.rs

@@ -93,7 +93,7 @@ pub fn as_static_str_inner(
 ) -> syn::Result<TokenStream> {
     let name = &ast.ident;
     let (impl_generics, ty_generics, where_clause) = ast.generics.split_for_impl();
-    let arms = get_arms(ast, |tok| {
+    let arms = &get_arms(ast, |tok| {
         quote! { ::core::convert::From::from(#tok) }
     })?;
 
@@ -107,8 +107,6 @@ pub fn as_static_str_inner(
             parse_quote!('_derivative_strum),
         )));
     let (impl_generics2, _, _) = generics.split_for_impl();
-    let arms2 = arms.clone();
-    let arms3 = arms.clone();
 
     Ok(match trait_variant {
         GenerateTraitVariant::AsStaticStr => quote! {
@@ -126,15 +124,15 @@ pub fn as_static_str_inner(
                 #[inline]
                 fn from(x: #name #ty_generics) -> &'static str {
                     match x {
-                        #(#arms2),*
+                        #(#arms),*
                     }
                 }
             }
             impl #impl_generics2 ::core::convert::From<&'_derivative_strum #name #ty_generics> for &'static str #where_clause {
                 #[inline]
                 fn from(x: &'_derivative_strum #name #ty_generics) -> &'static str {
                     match *x {
-                        #(#arms3),*
+                        #(#arms),*
                     }
                 }
             }
@@ -143,15 +141,15 @@ pub fn as_static_str_inner(
             impl #impl_generics #name #ty_generics #where_clause {
                 pub const fn into_str(&self) -> &'static str {
                     match self {
-                        #(#arms3),*
+                        #(#arms),*
                     }
                 }
             }
 
             impl #impl_generics ::core::convert::From<#name #ty_generics> for &'static str #where_clause {
                 fn from(x: #name #ty_generics) -> &'static str {
                     match x {
-                        #(#arms2),*
+                        #(#arms),*
                     }
                 }
             }

strum_tests/tests/as_ref_str.rs

@@ -64,13 +64,15 @@ fn as_fuchsia_str() {
 #[derive(IntoStaticStr)]
 enum Foo<'a> {
     A,
+    #[allow(dead_code)]
     C(&'a i32),
 }
 
 #[derive(IntoStaticStr)]
 enum Boo<'a, T> {
     A(T),
     B,
+    #[allow(dead_code)]
     C(&'a i32),
 }
 
@@ -81,6 +83,7 @@ where
 {
     A(T),
     B,
+    #[allow(dead_code)]
     C(&'a i32),
 }
 
@@ -144,13 +147,15 @@ where
 {
     A(T),
     B,
+    #[allow(dead_code)]
     C(&'a i32),
     #[strum(serialize = "Dark")]
     D,
     #[strum(to_string = "Green")]
     G,
     #[strum(serialize = "b", to_string = "blue")]
     Blue {
+        #[allow(dead_code)]
         hue: usize,
     },
     #[strum(serialize = "y", serialize = "yellow")]
@@ -161,6 +166,7 @@ where
 #[strum(const_into_str)]
 enum Baz<'a, T> {
     A(T),
+    #[allow(dead_code)]
     C(&'a i32),
 }
 
@@ -170,6 +176,7 @@ enum Baz<'a, T> {
 enum BrightnessConst {
     DarkBlack,
     Dim {
+        #[allow(dead_code)]
         glow: usize,
     },
     #[strum(serialize = "Bright")]

strum_tests/tests/enum_is.rs

@@ -3,11 +3,13 @@ use strum::EnumIs;
 
 mod core {} // ensure macros call `::core`
 #[derive(EnumIs)]
+#[allow(dead_code)]
 enum LifeTimeTest<'a> {
     One(Cow<'a, str>),
     Two(&'a str),
 }
 #[derive(EnumIs)]
+#[allow(dead_code)]
 enum Foo {
     Unit,
     Named0 {},

strum_tests/tests/enum_variant_table.rs

@@ -1,6 +1,7 @@
 use strum::EnumTable;
 
 #[derive(EnumTable)]
+#[allow(dead_code)]
 enum Color {
     Red,
     Yellow,
@@ -15,6 +16,7 @@ enum Color {
 // even though this isn't used, it needs to be a test
 // because if it doesn't compile, enum variants that conflict with keywords won't work
 #[derive(EnumTable)]
+#[allow(dead_code)]
 enum Keyword {
     Const,
 }

strum_tests/tests/from_repr.rs

@@ -44,6 +44,7 @@ fn const_test() {
 fn crate_module_path_test() {
     pub mod nested {
         pub mod module {
+            #[allow(unused_imports)]
             pub use strum;
         }
     }