-
Notifications
You must be signed in to change notification settings - Fork 706
NullQubit tests with new graph-based decomposition
#8260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8260 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 558 558
Lines 57781 57786 +5
=======================================
+ Hits 57431 57436 +5
Misses 350 350 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NullQubit tests with new graph-based decomposition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to make this change more future facing and robust to a time where pennylane has fully transition to graph based decompositions.
As long as we have a graph based decomposition registered, null qubit should be able to decompose it.
Are there any improvements we could make to has_decomp to make it more usable?
Then I think we do need to lift the stopping condition of NQ? |
|
Or matbe Operations.has decompse needs update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve but don't forget to update the code once my PR is merged.
@astralcai Please link the relevant PR |
I put it in the PR description |
Co-authored-by: Christina Lee <[email protected]>
Context:
NullQubithas a new test that exclusively works for new graph-based decomposition system.Description of the Change:
Some previous tests have been used with the dual mode tests with or without graph decomp
A new graph exclusive test added, mimicingg the one in DQ tests.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-97952] #8286