Skip to content

Conversation

@JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Sep 12, 2025

Context:
NullQubit has a new test that exclusively works for new graph-based decomposition system.

Description of the Change:
Some previous tests have been used with the dual mode tests with or without graph decomp
A new graph exclusive test added, mimicingg the one in DQ tests.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-97952] #8286

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (2e4c60f) to head (7303c29).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8260   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         558      558           
  Lines       57781    57786    +5     
=======================================
+ Hits        57431    57436    +5     
  Misses        350      350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerryChen97 JerryChen97 changed the title NQ's own test NullQubit tests with new graph-based decomposition Sep 12, 2025
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to make this change more future facing and robust to a time where pennylane has fully transition to graph based decompositions.

As long as we have a graph based decomposition registered, null qubit should be able to decompose it.

Are there any improvements we could make to has_decomp to make it more usable?

@JerryChen97
Copy link
Contributor Author

I'd prefer to make this change more future facing and robust to a time where pennylane has fully transition to graph based decompositions.

As long as we have a graph based decomposition registered, null qubit should be able to decompose it.

Are there any improvements we could make to has_decomp to make it more usable?

Then I think we do need to lift the stopping condition of NQ?

@JerryChen97
Copy link
Contributor Author

Or matbe Operations.has decompse needs update

@JerryChen97 JerryChen97 requested a review from albi3ro September 13, 2025 20:49
Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but don't forget to update the code once my PR is merged.

@Alex-Preciado
Copy link
Contributor

I'll approve but don't forget to update the code once my PR is merged.

@astralcai Please link the relevant PR

@JerryChen97
Copy link
Contributor Author

I'll approve but don't forget to update the code once my PR is merged.

@astralcai Please link the relevant PR

I put it in the PR description

@JerryChen97 JerryChen97 requested a review from albi3ro September 18, 2025 17:05
@JerryChen97 JerryChen97 requested a review from albi3ro September 18, 2025 18:05
@JerryChen97 JerryChen97 added the urgent Mark a pull request as high priority label Sep 18, 2025
@JerryChen97 JerryChen97 added this pull request to the merge queue Sep 18, 2025
Merged via the queue into master with commit 59d5028 Sep 18, 2025
54 of 56 checks passed
@JerryChen97 JerryChen97 deleted the new-decomp-integration/null-qubit3 branch September 18, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

urgent Mark a pull request as high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants