move value grab for camera to layout service

Author: PassiveModding

Meddle/Meddle.Plugin/Models/Layout/ParsedInstance.cs

@@ -280,12 +280,11 @@ public class ParsedCameraInstance : ParsedInstance, ISearchableInstance
     public float AspectRatio { get; }
     public Quaternion Rotation { get; }
 
-    public unsafe ParsedCameraInstance(Pointer<Camera> camera, Transform transform) : base((nint)camera.Value, ParsedInstanceType.Camera, transform)
+    public unsafe ParsedCameraInstance(nint id, Transform transform, float fov, float aspectRatio, Vector3 position, Vector3 lookAtVector) : base(id, ParsedInstanceType.Camera, transform)
     {
-        FoV = camera.Value->RenderCamera->FoV;
-        AspectRatio = camera.Value->RenderCamera->AspectRatio;
-
-        var rotation = CreateLookAt(camera.Value->Position, camera.Value->LookAtVector); 
+        FoV = fov;
+        AspectRatio = aspectRatio;
+        var rotation = CreateLookAt(position, lookAtVector);
         // flip the rotation for cameras
         rotation *= Quaternion.CreateFromAxisAngle(Vector3.UnitY, MathF.PI);
 

Meddle/Meddle.Plugin/Services/LayoutService.cs

@@ -101,11 +101,14 @@ private unsafe ParsedCameraInstance[] ParseCameras()
                 continue;
 
             var camera = cameraPtr.Value;
-            
-            var transform = new Transform(camera->Position, camera->Rotation, camera->Scale);
             if (camera->RenderCamera != null)
-            {
-                cameras.Add(new ParsedCameraInstance(camera, transform));
+            {      
+                var transform = new Transform(camera->Position, camera->Rotation, camera->Scale); 
+                var fov = camera->RenderCamera->FoV;
+                var aspectRatio = camera->RenderCamera->AspectRatio;
+                var position = camera->Position;
+                var lookAtVector = camera->LookAtVector;
+                cameras.Add(new ParsedCameraInstance((nint)camera, transform, fov, aspectRatio, position, lookAtVector));
             }
         }