Skip to content

group null judge fix #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2023
Merged

group null judge fix #7122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c7076
group null judge fix
TimeYWL Sep 25, 2023
4d043d1
fix all
TimeYWL Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions paddlenlp/data/dist_dataloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def __next__(self):
# broadcast data keys size
data_keys_size = paddle.to_tensor(data_keys_size)
if self._data_keys_size is None:
if self.mp_group is not None and self.pp_rank == 0:
if self.mp_group.rank > -1 and self.pp_rank == 0:
paddle.distributed.broadcast(data_keys_size, src=self.mp_src_rank, group=self.mp_group)
if self._pp_data_group is not None:
paddle.distributed.broadcast(
Expand All @@ -165,7 +165,7 @@ def __next__(self):

# broadcast data keys name
if self._data_keys is None:
if self.mp_group is not None and self.pp_rank == 0:
if self.mp_group.rank > -1 and self.pp_rank == 0:
paddle.distributed.broadcast_object_list(data_keys, src=self.mp_src_rank, group=self.mp_group)
if self._pp_data_group is not None:
paddle.distributed.broadcast_object_list(
Expand All @@ -176,7 +176,7 @@ def __next__(self):
# broadcast data
if not self._need_data:
data_list = [None for i in range(self._data_keys_size)]
if self.mp_group is not None and self.pp_rank == 0:
if self.mp_group.rank > -1 and self.pp_rank == 0:
data_list = broadcast_data_list(data_list, paddle.int64, self.mp_rank, self.mp_group, self.mp_src_rank)

if self._pp_data_group is not None:
Expand Down