Skip to content

Conversation

@lugimzzz
Copy link
Contributor

PR types

New features

PR changes

APIs

Description

新增返回visualdl路径

@paddle-bot
Copy link

paddle-bot bot commented Feb 24, 2023

Thanks for your contribution!

@lugimzzz lugimzzz requested a review from sijunhe February 24, 2023 10:23
@lugimzzz lugimzzz self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #4990 (315a58b) into develop (f38a255) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #4990      +/-   ##
===========================================
- Coverage    47.58%   47.57%   -0.01%     
===========================================
  Files          453      453              
  Lines        65378    65385       +7     
===========================================
  Hits         31109    31109              
- Misses       34269    34276       +7     
Impacted Files Coverage Δ
...dlenlp/experimental/autonlp/text_classification.py 97.09% <ø> (ø)
...addlenlp/experimental/autonlp/auto_trainer_base.py 88.63% <75.00%> (-0.97%) ⬇️
paddlenlp/trainer/integrations.py 68.22% <100.00%> (ø)
paddlenlp/trainer/training_args.py 67.41% <0.00%> (-1.88%) ⬇️
paddlenlp/utils/downloader.py 64.60% <0.00%> (-0.89%) ⬇️
paddlenlp/taskflow/taskflow.py 80.45% <0.00%> (ø)
paddlenlp/taskflow/dialogue.py 74.45% <0.00%> (+1.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议先研究清楚ai studio里的vdl功能是怎么工作的,在写这个PR

logger.info(f"Exported {trial_id} to {export_path}")
return taskflow_config

def visualdl(self, trial_id: Optional[str] = None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该写到auto_trainer_base.py里面作为后续所有任务的共有函数

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改写到共有函数

@lugimzzz
Copy link
Contributor Author

lugimzzz commented Feb 27, 2023

建议先研究清楚ai studio里的vdl功能是怎么工作的,在写这个PR

aistudio中只需要添加vdl的路径就可以启动vdl的服务
image


if self.vdl_writer is None:
self._init_summary_writer(args)
return
Copy link
Contributor Author

@lugimzzz lugimzzz Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trainer里evaluate调用log函数的时候会新增一个visualdl的log文件。

这块修改需要 @ZHUI 确认是否没问题

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lugimzzz lugimzzz requested a review from ZHUI February 27, 2023 09:20
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 27, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 27, 2023
Copy link
Contributor

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我这里lgtm. 看 @ZHUI 怎么说

Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lugimzzz lugimzzz merged commit c19d9aa into PaddlePaddle:develop Feb 27, 2023
@lugimzzz lugimzzz deleted the visualdl branch February 27, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants