[clang-tidy] enable bugprone-exception-escape check (#56692)

Author: gouzil

.clang-tidy

@@ -8,7 +8,7 @@ bugprone-argument-comment,
 bugprone-copy-constructor-init,
 -bugprone-dangling-handle,
 -bugprone-dynamic-static-initializers,
--bugprone-exception-escape,
+bugprone-exception-escape,
 -bugprone-fold-init-type,
 -bugprone-forwarding-reference-overload,
 -bugprone-inaccurate-erase,

paddle/fluid/distributed/auto_parallel/spmd_rules/dim_trans.cc

@@ -72,7 +72,7 @@ Flatten::Flatten(const std::vector<DimTrans*>& dims)
   all_dim_trans.emplace_back(this);
 }
 
-Flatten::~Flatten() {
+Flatten::~Flatten() {  // NOLINT
   input_dims_.assign(input_dims_.size(), nullptr);
   std::vector<DimTrans*>().swap(input_dims_);
 }

paddle/fluid/eager/auto_code_generator/eager_generator.cc

@@ -3299,7 +3299,7 @@ static void DygraphCodeGeneration(const std::string& output_dir,
 }  // namespace framework
 }  // namespace paddle
 
-int main(int argc, char* argv[]) {
+int main(int argc, char* argv[]) {  // NOLINT
   if (argc != 3) {
     std::cerr << "argc must be 3" << std::endl;
     return -1;

paddle/fluid/eager/pylayer/py_layer_node.cc

@@ -27,7 +27,7 @@
 #include "pybind11/pytypes.h"
 
 namespace egr {
-GradNodePyLayer::~GradNodePyLayer() {
+GradNodePyLayer::~GradNodePyLayer() {  // NOLINT
   pybind11::gil_scoped_acquire gil;
   Py_XDECREF(ctx_);
 }

paddle/fluid/framework/custom_operator.cc

@@ -916,11 +916,12 @@ static void RegisterOperatorKernel(
   OperatorWithKernel::OpKernelFunc op_kernel_func;
   if (kernel_func) {
     VLOG(3) << "Register custom operator " << name << " with kernel func";
-    op_kernel_func = [kernel_func, inputs, outputs, attrs, inplace_map](
-                         const framework::ExecutionContext& ctx) {
-      VLOG(3) << "Custom Operator: run custom kernel func in lambda.";
-      RunKernelFunc(ctx, kernel_func, inputs, outputs, attrs, inplace_map);
-    };
+    op_kernel_func =
+        [kernel_func, inputs, outputs, attrs, inplace_map](  // NOLINT
+            const framework::ExecutionContext& ctx) {
+          VLOG(3) << "Custom Operator: run custom kernel func in lambda.";
+          RunKernelFunc(ctx, kernel_func, inputs, outputs, attrs, inplace_map);
+        };
   } else {
     VLOG(3) << "Register custom operator " << name
             << " with raw op kernel func";
@@ -1027,12 +1028,12 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
   // InferShape
   if (infer_shape_func == nullptr) {
     // use default InferShape
-    info.infer_shape_ =
-        [op_inputs, op_outputs, op_inplace_map](InferShapeContext* ctx) {
-          RunDefaultInferShapeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
-        };
+    info.infer_shape_ = [op_inputs, op_outputs, op_inplace_map](  // NOLINT
+                            InferShapeContext* ctx) {
+      RunDefaultInferShapeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
+    };
   } else {
-    info.infer_shape_ = [op_inputs,
+    info.infer_shape_ = [op_inputs,  // NOLINT
                          op_outputs,
                          op_attrs,
                          op_inplace_map,
@@ -1051,12 +1052,12 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
   // Infer Dtype
   if (infer_dtype_func == nullptr) {
     // use default InferDtype
-    info.infer_var_type_ =
-        [op_inputs, op_outputs, op_inplace_map](InferVarTypeContext* ctx) {
-          RunDefaultInferDtypeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
-        };
+    info.infer_var_type_ = [op_inputs, op_outputs, op_inplace_map](  // NOLINT
+                               InferVarTypeContext* ctx) {
+      RunDefaultInferDtypeFunc(ctx, op_inputs, op_outputs, op_inplace_map);
+    };
   } else {
-    info.infer_var_type_ = [op_inputs,
+    info.infer_var_type_ = [op_inputs,  // NOLINT
                             op_outputs,
                             op_attrs,
                             op_inplace_map,
@@ -1115,7 +1116,10 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // GradOpDescMaker
     info.grad_op_maker_ =
-        [grad_op_name, grad_op_inputs, grad_op_outputs, is_double_grad](
+        [grad_op_name,  // NOLINT
+         grad_op_inputs,
+         grad_op_outputs,
+         is_double_grad](
             const OpDesc& fwd_op,
             const std::unordered_set<std::string>& no_grad_set,
             std::unordered_map<std::string, std::string>* grad_to_var,
@@ -1133,7 +1137,10 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // GradOpBaseMaker
     info.dygraph_grad_op_maker_ =
-        [grad_op_name, grad_op_inputs, grad_op_outputs, is_double_grad](
+        [grad_op_name,  // NOLINT
+         grad_op_inputs,
+         grad_op_outputs,
+         is_double_grad](
             const std::string& type,
             const imperative::NameVarBaseMap& var_base_map_in,
             const imperative::NameVarBaseMap& var_base_map_out,
@@ -1173,7 +1180,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
 
     // Grad InferShape
     if (grad_infer_shape_fn == nullptr) {
-      grad_info.infer_shape_ = [grad_op_inputs,
+      grad_info.infer_shape_ = [grad_op_inputs,  // NOLINT
                                 grad_op_outputs,
                                 is_double_grad](InferShapeContext* ctx) {
         // 1. if forward input exists, gradient's shape is same with forward
@@ -1211,7 +1218,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
         }
       };
     } else {
-      grad_info.infer_shape_ = [grad_op_inputs,
+      grad_info.infer_shape_ = [grad_op_inputs,  // NOLINT
                                 grad_op_outputs,
                                 grad_op_attrs,
                                 grad_op_inplace_map,
@@ -1230,7 +1237,7 @@ void RegisterOperatorWithMetaInfo(const std::vector<OpMetaInfo>& op_meta_infos,
     // Grad InferDtype
     if (grad_infer_dtype_fn != nullptr) {
       grad_info.infer_var_type_ =
-          [grad_op_inputs,
+          [grad_op_inputs,  // NOLINT
            grad_op_outputs,
            grad_op_attrs,
            grad_op_inplace_map,

paddle/fluid/framework/new_executor/interpreter/interpreter_util.cc

@@ -72,7 +72,7 @@ class SingleStreamGuard {
     }
   }
 
-  ~SingleStreamGuard() {
+  ~SingleStreamGuard() {  // NOLINT
     if (!is_changed) {
       return;
     }

paddle/fluid/framework/scope.cc

@@ -33,7 +33,7 @@ PADDLE_DEFINE_EXPORTED_bool(
 namespace paddle {
 namespace framework {
 
-Scope::~Scope() { DropKids(); }
+Scope::~Scope() { DropKids(); }  // NOLINT
 
 Scope& Scope::NewScope() const {
   Scope* child = new Scope(this);

paddle/fluid/inference/api/analysis_predictor.cc

@@ -2581,7 +2581,7 @@ bool AnalysisPredictor::SaveTrtCalibToDisk() {
 }
 #endif
 
-AnalysisPredictor::~AnalysisPredictor() {
+AnalysisPredictor::~AnalysisPredictor() {  // NOLINT
 #ifdef PADDLE_WITH_TENSORRT
   if (config_.tensorrt_engine_enabled() &&
       config_.tensorrt_precision_mode_ == AnalysisConfig::Precision::kInt8 &&

paddle/fluid/memory/allocation/mmap_allocator.cc

@@ -391,7 +391,7 @@ void MemoryMapAllocationPool::Clear() {
   memory_map_allocations_.clear();
 }
 
-MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); }
+MemoryMapAllocationPool::~MemoryMapAllocationPool() { Clear(); }  // NOLINT
 
 }  // namespace allocation
 }  // namespace memory

paddle/fluid/platform/profiler.cc

@@ -591,7 +591,7 @@ MemEvenRecorder::RecordMemEvent::RecordMemEvent(const Place &place,
   PushMemEvent(start_ns_, end_ns_, bytes_, place_, alloc_in_);
 }
 
-MemEvenRecorder::RecordMemEvent::~RecordMemEvent() {
+MemEvenRecorder::RecordMemEvent::~RecordMemEvent() {  // NOLINT
   phi::DeviceTracer *tracer = phi::GetDeviceTracer();
   end_ns_ = PosixInNsec();