Do not delete 'IndexingTask' table after the migration (#18071)

Author: MikeAlhayek

src/OrchardCore.Modules/OrchardCore.Indexing/Migrations.cs

@@ -77,7 +77,6 @@ public int UpdateFrom4()
 
             try
             {
-                var previewIndexExists = false;
                 await connection.OpenAsync();
                 try
                 {
@@ -99,28 +98,8 @@ public int UpdateFrom4()
                     """;
 
                     await connection.ExecuteAsync(previewTableQuery);
-
-                    previewIndexExists = true;
                 }
 
-                // At this point, the 'RecordIndexingTask' table has been populated with the data from the 'IndexingTask' table.
-                // It's safe to drop the old 'IndexingTask' table now.
-
-                var dropIndex = dialect.GetDropIndexString("IDX_IndexingTask_ContentItemId", indexingTaskTable, store.Configuration.Schema);
-
-                await connection.ExecuteAsync(dropIndex);
-
-                if (previewIndexExists)
-                {
-                    // If the preview index was created, we need to drop it as well.
-                    var dropPreviewIndex = dialect.GetDropIndexString("IDX_IndexingTask_RecordId_Category", indexingTaskTable, store.Configuration.Schema);
-
-                    await connection.ExecuteAsync(dropPreviewIndex);
-                }
-
-                var dropTable = dialect.GetDropTableString(indexingTaskTable, store.Configuration.Schema);
-
-                await connection.ExecuteAsync(dropTable);
                 await connection.CloseAsync();
             }
             catch (Exception e)

src/docs/releases/3.0.0.md

@@ -59,7 +59,8 @@ if(context.Record is ContentItem contentItem) {
 
 - The `IIndexingTaskManager` interface was changed to be use as a universal task manager not only for content items. If you want to queue the content items in the index manager, you'll need to pass `Content` in the category argument. You may also store non-content-items in the index manager by passing a different category name.
 
-The `IndexingTask` table in the database has been renamed to `RecordIndexingTask` to better reflect its purpose as a universal task manager.
+!!! warning
+    The `IndexingTask` table in the database has been migrated to `RecordIndexingTask` to better reflect its purpose as a universal task manager. The `IndexingTask` table is kept intact to allow you to rollback your deployment if needed. If you no longer need that table, you can either manually delete it or create a migration in your project that deletes it.
 
 ### Elasticsearch Module