Skip to content

Commit 2e25ba0

Browse files
Merge pull request #32924 from SmithaSubbarao/add-spring4-war-tests-concurrency-mbean
Enable Spring 4.0 WAR tests for Concurrency and MBean
2 parents 9306105 + eedab80 commit 2e25ba0

File tree

3 files changed

+14
-2
lines changed
  • dev
    • io.openliberty.springboot.fat40.concurrency.app
    • io.openliberty.springboot.fat40.mbean.app
    • io.openliberty.springboot.fat40_fat/fat/src/com/ibm/ws/springboot/support/fat

3 files changed

+14
-2
lines changed

dev/io.openliberty.springboot.fat40.concurrency.app/build.gradle

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@ apply from: '../wlp-gradle/subprojects/maven-central-mirror.gradle'
2727

2828
dependencies {
2929
implementation('org.springframework.boot:spring-boot-starter-web')
30-
providedRuntime('org.springframework.boot:spring-boot-starter-tomcat')
30+
// Should use spring-boot-starter-tomcat as provideCompile, but gradle plugin
31+
// is putting too much in lib-provided: see https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/409
32+
// providedCompile('org.springframework.boot:spring-boot-starter-tomcat')
33+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-core')
34+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-el')
35+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-websocket')
3136
}
3237

3338
bootJar {

dev/io.openliberty.springboot.fat40.mbean.app/build.gradle

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,12 @@ apply from: '../wlp-gradle/subprojects/maven-central-mirror.gradle'
2828

2929
dependencies {
3030
implementation('org.springframework.boot:spring-boot-starter-web') // + ':' + sv['springBoot'])
31-
providedRuntime('org.springframework.boot:spring-boot-starter-tomcat')
31+
// Should use spring-boot-starter-tomcat as provideCompile, but gradle plugin
32+
// is putting too much in lib-provided: see https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/409
33+
// providedCompile('org.springframework.boot:spring-boot-starter-tomcat')
34+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-core')
35+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-el')
36+
providedRuntime('org.apache.tomcat.embed:tomcat-embed-websocket')
3237
}
3338

3439
bootJar {

dev/io.openliberty.springboot.fat40_fat/fat/src/com/ibm/ws/springboot/support/fat/FATSuite.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@
6363
TemplateTests40.class,
6464
ApplicationStartedEventTests40.class,
6565
ConcurrencyAppTests40.class,
66+
ConcurrencyAppTests40War.class,
6667
MBeanAppTests40.class,
68+
MBeanAppTests40War.class,
6769
JmsSpringBootAppTests40.class,
6870
JmsWebAppTests40.class
6971

0 commit comments

Comments
 (0)