Skip to content

Commit 96c92ba

Browse files
author
huubl
committed
Bug fix: Assignment to constant variable
1 parent c983ea2 commit 96c92ba

File tree

9 files changed

+39
-31
lines changed

9 files changed

+39
-31
lines changed

‎assets/dist/waymark-js/js/waymark-js.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7387,7 +7387,7 @@ function Waymark_Map() {
73877387
//Set by name?
73887388
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
73897389
//Search
7390-
for(i in Waymark.config.tile_layers) {
7390+
for(var i in Waymark.config.tile_layers) {
73917391
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
73927392
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();
73937393

@@ -7400,7 +7400,7 @@ function Waymark_Map() {
74007400
}
74017401

74027402
//For each tile layer
7403-
for(i in Waymark.config.tile_layers) {
7403+
for(var i in Waymark.config.tile_layers) {
74047404
//Append URL?
74057405
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
74067406
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
@@ -7435,7 +7435,7 @@ function Waymark_Map() {
74357435
var type = null;
74367436

74377437
//Iterate over all types
7438-
for(i in Waymark.config[layer_type + '_types']) {
7438+
for(var i in Waymark.config[layer_type + '_types']) {
74397439
//Use first as default
74407440
if(i == 0) {
74417441
type = Waymark.config[layer_type + '_types'][i];
@@ -7481,7 +7481,7 @@ function Waymark_Map() {
74817481
}
74827482
];
74837483

7484-
for(i in required) {
7484+
for(var i in required) {
74857485
//If undefined
74867486
if(typeof type[required[i]['key']] !== 'string') {
74877487
//Set default
@@ -7592,7 +7592,7 @@ function Waymark_Map() {
75927592
// case 'photos':
75937593
// waymark_data.type = 'photo';
75947594
//
7595-
// for(i in feature.properties[prop]) {
7595+
// for(var i in feature.properties[prop]) {
75967596
// //Set thumb
75977597
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
75987598
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
@@ -7885,7 +7885,7 @@ function Waymark_Map() {
78857885
var image_sizes = {};
78867886

78877887
//Grab these
7888-
for(i in Waymark.config.media_library_sizes) {
7888+
for(var i in Waymark.config.media_library_sizes) {
78897889
//Use fallback
78907890
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;
78917891

@@ -8126,7 +8126,7 @@ function Waymark_Map_Viewer() {
81268126
this.line_has_elevation_data = function(feature) {
81278127
if(feature.geometry.type == 'MultiLineString') {
81288128
//Each line
8129-
for(i in feature.geometry.coordinates) {
8129+
for(var i in feature.geometry.coordinates) {
81308130
//Each point
81318131
for(j in feature.geometry.coordinates[i]) {
81328132
//If has elevation data
@@ -8975,7 +8975,7 @@ function Waymark_Map_Editor() {
89758975
);
89768976

89778977
//Pre-defined types
8978-
for(i in types) {
8978+
for(var i in types) {
89798979
var type_key = Waymark.make_key(types[i][layer_type + '_title']);
89808980

89818981
ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
@@ -9325,7 +9325,7 @@ function Waymark_Map_Editor() {
93259325
//var keep_properties = ['title', 'name', 'description', 'photos'];
93269326
// var keep_properties = ['title', 'name', 'description'];
93279327
// //Each feature
9328-
// for(i in geo_json.features) {
9328+
// for(var i in geo_json.features) {
93299329
// //Each property
93309330
// for(key in geo_json.features[i].properties) {
93319331
// //We want this

‎assets/dist/waymark-js/js/waymark-js.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎readme.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ A big thank you to the following projects and their contributors. Without their
111111

112112
## Changelog ##
113113

114+
### 0.9.21 ###
115+
116+
* Bug fix. Uncaught TypeError: Assignment to constant variable.
117+
114118
### 0.9.20 ###
115119

116120
* Front-end <a href="https://www.waymark.dev/docs/submissions/">Submissions</a> can now be added to a <a href="https://www.waymark.dev/docs/collections/">Collection</a> by default. A collection for User and Guest submissions can be specified in Settings > Submissions > Default Collection.

‎readme.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ A big thank you to the following projects and their contributors. Without their
9797

9898
== Changelog ==
9999

100+
= 0.9.21 =
101+
102+
* Bug fix. Uncaught TypeError: Assignment to constant variable.
103+
100104
= 0.9.20 =
101105

102106
* Front-end <a href="https://www.waymark.dev/docs/submissions/">Submissions</a> can now be added to a <a href="https://www.waymark.dev/docs/collections/">Collection</a> by default. A collection for User and Guest submissions can be specified in Settings > Submissions > Default Collection.

‎waymark-js/dist/js/waymark-js.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7387,7 +7387,7 @@ function Waymark_Map() {
73877387
//Set by name?
73887388
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
73897389
//Search
7390-
for(i in Waymark.config.tile_layers) {
7390+
for(var i in Waymark.config.tile_layers) {
73917391
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
73927392
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();
73937393

@@ -7400,7 +7400,7 @@ function Waymark_Map() {
74007400
}
74017401

74027402
//For each tile layer
7403-
for(i in Waymark.config.tile_layers) {
7403+
for(var i in Waymark.config.tile_layers) {
74047404
//Append URL?
74057405
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
74067406
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
@@ -7435,7 +7435,7 @@ function Waymark_Map() {
74357435
var type = null;
74367436

74377437
//Iterate over all types
7438-
for(i in Waymark.config[layer_type + '_types']) {
7438+
for(var i in Waymark.config[layer_type + '_types']) {
74397439
//Use first as default
74407440
if(i == 0) {
74417441
type = Waymark.config[layer_type + '_types'][i];
@@ -7481,7 +7481,7 @@ function Waymark_Map() {
74817481
}
74827482
];
74837483

7484-
for(i in required) {
7484+
for(var i in required) {
74857485
//If undefined
74867486
if(typeof type[required[i]['key']] !== 'string') {
74877487
//Set default
@@ -7592,7 +7592,7 @@ function Waymark_Map() {
75927592
// case 'photos':
75937593
// waymark_data.type = 'photo';
75947594
//
7595-
// for(i in feature.properties[prop]) {
7595+
// for(var i in feature.properties[prop]) {
75967596
// //Set thumb
75977597
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
75987598
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
@@ -7885,7 +7885,7 @@ function Waymark_Map() {
78857885
var image_sizes = {};
78867886

78877887
//Grab these
7888-
for(i in Waymark.config.media_library_sizes) {
7888+
for(var i in Waymark.config.media_library_sizes) {
78897889
//Use fallback
78907890
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;
78917891

@@ -8126,7 +8126,7 @@ function Waymark_Map_Viewer() {
81268126
this.line_has_elevation_data = function(feature) {
81278127
if(feature.geometry.type == 'MultiLineString') {
81288128
//Each line
8129-
for(i in feature.geometry.coordinates) {
8129+
for(var i in feature.geometry.coordinates) {
81308130
//Each point
81318131
for(j in feature.geometry.coordinates[i]) {
81328132
//If has elevation data
@@ -8975,7 +8975,7 @@ function Waymark_Map_Editor() {
89758975
);
89768976

89778977
//Pre-defined types
8978-
for(i in types) {
8978+
for(var i in types) {
89798979
var type_key = Waymark.make_key(types[i][layer_type + '_title']);
89808980

89818981
ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
@@ -9325,7 +9325,7 @@ function Waymark_Map_Editor() {
93259325
//var keep_properties = ['title', 'name', 'description', 'photos'];
93269326
// var keep_properties = ['title', 'name', 'description'];
93279327
// //Each feature
9328-
// for(i in geo_json.features) {
9328+
// for(var i in geo_json.features) {
93299329
// //Each property
93309330
// for(key in geo_json.features[i].properties) {
93319331
// //We want this

‎waymark-js/dist/js/waymark-js.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎waymark-js/src/js/Waymark_Map.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ function Waymark_Map() {
510510
//Set by name?
511511
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
512512
//Search
513-
for(i in Waymark.config.tile_layers) {
513+
for(var i in Waymark.config.tile_layers) {
514514
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
515515
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();
516516

@@ -523,7 +523,7 @@ function Waymark_Map() {
523523
}
524524

525525
//For each tile layer
526-
for(i in Waymark.config.tile_layers) {
526+
for(var i in Waymark.config.tile_layers) {
527527
//Append URL?
528528
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
529529
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
@@ -558,7 +558,7 @@ function Waymark_Map() {
558558
var type = null;
559559

560560
//Iterate over all types
561-
for(i in Waymark.config[layer_type + '_types']) {
561+
for(var i in Waymark.config[layer_type + '_types']) {
562562
//Use first as default
563563
if(i == 0) {
564564
type = Waymark.config[layer_type + '_types'][i];
@@ -604,7 +604,7 @@ function Waymark_Map() {
604604
}
605605
];
606606

607-
for(i in required) {
607+
for(var i in required) {
608608
//If undefined
609609
if(typeof type[required[i]['key']] !== 'string') {
610610
//Set default
@@ -715,7 +715,7 @@ function Waymark_Map() {
715715
// case 'photos':
716716
// waymark_data.type = 'photo';
717717
//
718-
// for(i in feature.properties[prop]) {
718+
// for(var i in feature.properties[prop]) {
719719
// //Set thumb
720720
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
721721
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
@@ -1008,7 +1008,7 @@ function Waymark_Map() {
10081008
var image_sizes = {};
10091009

10101010
//Grab these
1011-
for(i in Waymark.config.media_library_sizes) {
1011+
for(var i in Waymark.config.media_library_sizes) {
10121012
//Use fallback
10131013
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;
10141014

‎waymark-js/src/js/Waymark_Map_Editor.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,7 @@ function Waymark_Map_Editor() {
648648
);
649649

650650
//Pre-defined types
651-
for(i in types) {
651+
for(var i in types) {
652652
var type_key = Waymark.make_key(types[i][layer_type + '_title']);
653653

654654
ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
@@ -998,7 +998,7 @@ function Waymark_Map_Editor() {
998998
//var keep_properties = ['title', 'name', 'description', 'photos'];
999999
// var keep_properties = ['title', 'name', 'description'];
10001000
// //Each feature
1001-
// for(i in geo_json.features) {
1001+
// for(var i in geo_json.features) {
10021002
// //Each property
10031003
// for(key in geo_json.features[i].properties) {
10041004
// //We want this

‎waymark-js/src/js/Waymark_Map_Viewer.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ function Waymark_Map_Viewer() {
215215
this.line_has_elevation_data = function(feature) {
216216
if(feature.geometry.type == 'MultiLineString') {
217217
//Each line
218-
for(i in feature.geometry.coordinates) {
218+
for(var i in feature.geometry.coordinates) {
219219
//Each point
220220
for(j in feature.geometry.coordinates[i]) {
221221
//If has elevation data

0 commit comments

Comments
 (0)