[IMP]stock_inventory_non_stocked: Applied changes from code review, code optimization and some fixes.

Author: ipconinpe

stock_inventory_non_stocked/README.rst

@@ -35,6 +35,18 @@ This module adds a option to a create a 0 quantity quant for products without an
 .. contents::
    :local:
 
+Use Cases / Context
+===================
+
+In older versions of `stock_inventory`, the lines in the `stock.inventory` model were not part of the `stock.quant` model.
+In those versions, a line was created for every product found by the inventory adjustment group, regardless of whether
+the product was in stock or not.
+
+Currently, the lines of the model use Odoo's base `stock.quant` model. This means that if you select any configuration
+that includes a product without a `stock.quant` record, no line is created for that product. This behavior disrupts the
+intended functionality of the `stock_inventory` module, which is supposed to group all lines into a single record. If the
+lines do not exist, they are not displayed, making the adjustment process meaningless.
+
 Usage
 =====
 

stock_inventory_non_stocked/models/product_template.py

@@ -10,25 +10,13 @@ class ProductProduct(models.Model):
     has_quants = fields.Boolean(
         name="Has Quants",
         compute="_compute_has_quants",
+        precompute=True,
         store=True,
     )
 
-    @api.depends("qty_available", "incoming_qty", "outgoing_qty")
-    def _compute_has_quants(self):
-        for record in self:
-            record.has_quants = (
-                self.env["stock.quant"].search_count([("product_id", "=", record.id)])
-                > 0
-            )
-
     lot_ids = fields.One2many("stock.lot", "product_id", string="Lots", copy=False)
 
-
-class StockQuant(models.Model):
-    _inherit = "stock.quant"
-
-    @api.model_create_multi
-    def create(self, vals_list):
-        res = super(StockQuant, self).create(vals_list)
-        res.product_id._compute_has_quants()
-        return res
+    @api.depends("qty_available", "incoming_qty", "outgoing_qty", "stock_quant_ids")
+    def _compute_has_quants(self):
+        for record in self:
+            record.has_quants = record.stock_quant_ids and True or False

stock_inventory_non_stocked/models/stock_inventory.py

@@ -18,31 +18,17 @@ class StockInventory(models.Model):
     def _get_quants(self, locations):
         res = super(StockInventory, self)._get_quants(locations)
         if self.create_non_stocked:
-            if self.product_selection == "all":
-                product_ids = self.env["product.product"].search(
-                    [
-                        ("has_quants", "=", False),
-                        ("active", "=", True),
-                        ("type", "=", "product"),
-                    ]
-                )
-                new_quants = self.create_zero_quants(product_ids)
-                res |= new_quants
-            elif self.product_selection in ["manual", "one"]:
-                product_ids = self.product_ids.filtered(lambda x: not x.has_quants)
-                new_quants = self.create_zero_quants(product_ids)
-                res |= new_quants
+            self._check_responsible_of_inventory()
+            # If the option selected is all, this domain will be applied
+            domain = [
+                ("has_quants", "=", False),
+                ("active", "=", True),
+                ("type", "=", "product"),
+            ]
+            if self.product_selection in ["manual", "one"]:
+                domain.append(("id", "in", self.product_ids.ids))
             elif self.product_selection == "category":
-                product_ids = self.env["product.product"].search(
-                    [
-                        ("has_quants", "=", False),
-                        ("active", "=", True),
-                        ("type", "=", "product"),
-                        ("categ_id", "=", self.category_id.id),
-                    ]
-                )
-                new_quants = self.create_zero_quants(product_ids)
-                res |= new_quants
+                domain.append(("categ_id", "=", self.category_id.id))
             elif self.product_selection == "domain":
                 domain = self.product_domain
                 domain = (
@@ -52,38 +38,48 @@ def _get_quants(self, locations):
                     + domain[-1:]
                 )
                 domain = ast.literal_eval(domain)
-                product_ids = self.env["product.product"].search(domain)
-                new_quants = self.create_zero_quants(product_ids)
-                res |= new_quants
+            new_quants = self.create_zero_quants(domain)
+            res |= new_quants
         return res
 
-    def create_zero_quants(self, products):
-        new_quants = self.env["stock.quant"]
+    def create_zero_quants(self, domain):
+        products = self.env["product.product"].search_read(
+            domain, ["id", "tracking", "lot_ids"]
+        )
+        values = []
         for product in products:
             for location in self.location_ids:
                 # If the product is tracked by lot, we create a quant for each lot
                 # If the product is not tracked, we create a single quant
                 # If the product is tracked but has no lots, we don't create any quant
-                if product.tracking == "lot" and product.lot_ids:
+                if product["tracking"] in ["lot", "serial"] and product.lot_ids:
                     for lot in product.lot_ids:
-                        new_quants |= self.env["stock.quant"].create(
+                        values.append(
                             {
-                                "product_id": product.id,
+                                "product_id": product["id"],
                                 "location_id": location.id,
                                 "quantity": 0.0,
                                 "lot_id": lot.id,
-                                "user_id": self.env.uid,
                                 "last_count_date": fields.Datetime.now(),
                             }
                         )
-                elif product.tracking == "none":
-                    new_quants |= self.env["stock.quant"].create(
+                elif product["tracking"] == "none":
+                    values.append(
                         {
-                            "product_id": product.id,
+                            "product_id": product["id"],
                             "location_id": location.id,
                             "quantity": 0.0,
-                            "user_id": self.env.uid,
                             "last_count_date": fields.Datetime.now(),
                         }
                     )
+        new_quants = self.env["stock.quant"].create(values)
         return new_quants
+
+    # This method is designed to assing a responsible
+    # user to the inventory if it is not assigned
+    # this is necessary to avoid _unlink_zero_quants()
+    # method to remove quants created by this module
+    def _check_responsible_of_inventory(self):
+        for record in self:
+            if not record.responsible_id:
+                record.responsible_id = self.env.user

stock_inventory_non_stocked/readme/CONTEXT.rst

@@ -0,0 +1,8 @@
+In older versions of `stock_inventory`, the lines in the `stock.inventory` model were not part of the `stock.quant` model.
+In those versions, a line was created for every product found by the inventory adjustment group, regardless of whether
+the product was in stock or not.
+
+Currently, the lines of the model use Odoo's base `stock.quant` model. This means that if you select any configuration
+that includes a product without a `stock.quant` record, no line is created for that product. This behavior disrupts the
+intended functionality of the `stock_inventory` module, which is supposed to group all lines into a single record. If the
+lines do not exist, they are not displayed, making the adjustment process meaningless.

stock_inventory_non_stocked/static/description/index.html

@@ -373,49 +373,60 @@ <h1 class="title">Stock Inventory Non Stocked</h1>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
-<li><a class="reference internal" href="#usage" id="toc-entry-1">Usage</a></li>
-<li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-6">Maintainers</a></li>
+<li><a class="reference internal" href="#use-cases-context" id="toc-entry-1">Use Cases / Context</a></li>
+<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
 </ul>
 </li>
 </ul>
 </div>
+<div class="section" id="use-cases-context">
+<h1><a class="toc-backref" href="#toc-entry-1">Use Cases / Context</a></h1>
+<p>In older versions of <cite>stock_inventory</cite>, the lines in the <cite>stock.inventory</cite> model were not part of the <cite>stock.quant</cite> model.
+In those versions, a line was created for every product found by the inventory adjustment group, regardless of whether
+the product was in stock or not.</p>
+<p>Currently, the lines of the model use Odoo’s base <cite>stock.quant</cite> model. This means that if you select any configuration
+that includes a product without a <cite>stock.quant</cite> record, no line is created for that product. This behavior disrupts the
+intended functionality of the <cite>stock_inventory</cite> module, which is supposed to group all lines into a single record. If the
+lines do not exist, they are not displayed, making the adjustment process meaningless.</p>
+</div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <ul class="simple">
 <li>In the inventory adjustments, create a new adjustment group.</li>
 <li>Enable the option of create non stocked products.</li>
 <li>Start the inventory adjustment, it will create new quants for the non stocked products.</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_inventory_non_stocked%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
 <ul class="simple">
 <li>Ivan Perez</li>
 <li>Coninpe</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <ul class="simple">
 <li>Ivan Perez &lt;<a class="reference external" href="mailto:iperez&#64;coninpe.es">iperez&#64;coninpe.es</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose