[IMP] stock_inventory_verification_request: improvements in order to see in the tree view who has processed the svr and some minor improvements

Author: JoanSForgeFlow

stock_inventory_verification_request/README.rst

@@ -1,7 +1,3 @@
-.. image:: https://odoo-community.org/readme-banner-image
-   :target: https://odoo-community.org/get-involved?utm_source=readme
-   :alt: Odoo Community Association
-
 ====================================
 Stock Inventory Verification Request
 ====================================
@@ -17,7 +13,7 @@ Stock Inventory Verification Request
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github

stock_inventory_verification_request/__manifest__.py

@@ -19,6 +19,7 @@
     "data": [
         "security/ir.model.access.csv",
         "security/stock_security.xml",
+        "views/stock_move_line_views.xml",
         "views/stock_slot_verification_request_view.xml",
         "views/stock_inventory_view.xml",
         "views/stock_location_view.xml",

stock_inventory_verification_request/models/stock_inventory.py

@@ -75,6 +75,9 @@ def action_request_verification(self):
                         "product_id": quant.product_id.id,
                         "company_id": quant.company_id.id,
                         "lot_id": quant.lot_id.id if quant.lot_id else False,
+                        "inventory_id": quant.current_inventory_id.id
+                        if quant.current_inventory_id
+                        else False,
                     }
                 )
                 quant.requested_verification = True

stock_inventory_verification_request/models/stock_slot_verification_request.py

@@ -1,4 +1,4 @@
-# Copyright 2017-20 ForgeFlow S.L.
+# Copyright 2017-25 ForgeFlow S.L.
 #   (http://www.forgeflow.com)
 # Copyright 2025 OERP Canada <https://www.oerp.ca>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
@@ -82,6 +82,12 @@ def _compute_created_inventory_count(self):
         readonly=True,
         tracking=True,
     )
+    product_name = fields.Char(
+        "Product", related="product_id.name", store=True, translate=False
+    )
+    product_default_code = fields.Char(
+        related="product_id.default_code", store=True, translate=False
+    )
     lot_id = fields.Many2one(
         comodel_name="stock.lot",
         string="Lot",
@@ -115,16 +121,19 @@ def _compute_created_inventory_count(self):
         comodel_name="stock.inventory",
         string="Created Inventories",
         inverse_name="solving_slot_verification_request_id",
-        help="These inventory adjustment were created from this SVR.",
+        help="These inventory adjustments were created from this SVR.",
     )
     created_inventory_count = fields.Integer(compute="_compute_created_inventory_count")
+    processed_by = fields.Many2one(
+        "res.users",
+        readonly=True,
+        copy=False,
+        help="User who has solved or cancelled the request.",
+    )
 
     @api.depends("location_id", "product_id", "lot_id", "state")
     def _compute_involved_move_lines(self):
         for rec in self:
-            # Only compute when state is 'open' to prevent irrelevant data accumulation.
-            # No need to accumulate movements for a 'solved' or 'cancelled'
-            # SVR a lot of time after resolution.
             if rec.state == "open":
                 rec.involved_move_line_ids = self.env["stock.move.line"].search(
                     rec._get_involved_move_lines_domain()
@@ -167,22 +176,33 @@ def action_confirm(self):
         return True
 
     def action_cancel(self):
-        self.write({"state": "cancelled"})
+        self.write(
+            {
+                "state": "cancelled",
+                "processed_by": self.env.uid,
+            }
+        )
         if self.quant_id:
             self.quant_id.requested_verification = False
         return True
 
     def action_solved(self):
-        self.write({"state": "done"})
+        self.write(
+            {
+                "state": "done",
+                "processed_by": self.env.uid,
+            }
+        )
         if self.quant_id:
             self.quant_id.requested_verification = False
         return True
 
     def action_view_move_lines(self):
-        action = self.env.ref("stock.stock_move_line_action")
-        result = action.read()[0]
-        result["context"] = {}
+        action = self.env.ref(
+            "stock_inventory_verification_request.action_move_lines_svr"
+        ).read()[0]
         moves_ids = self.mapped("involved_move_line_ids").ids
+        result = action
         result["domain"] = [("id", "in", moves_ids)]
         return result
 
@@ -218,7 +238,6 @@ def action_create_inventory_adjustment(self):
         )
         action = self.env.ref("stock_inventory.action_view_inventory_group_form")
         result = action.read()[0]
-
         res = self.env.ref("stock_inventory.view_inventory_group_form", False)
         result["views"] = [(res and res.id or False, "form")]
         result["res_id"] = inventory.id

stock_inventory_verification_request/static/description/index.html

@@ -3,16 +3,15 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>README.rst</title>
+<title>Stock Inventory Verification Request</title>
 <style type="text/css">
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -360,21 +359,16 @@
 </style>
 </head>
 <body>
-<div class="document">
+<div class="document" id="stock-inventory-verification-request">
+<h1 class="title">Stock Inventory Verification Request</h1>
 
-
-<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
-<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
-</a>
-<div class="section" id="stock-inventory-verification-request">
-<h1>Stock Inventory Verification Request</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:f3bc9bf64a73db5a8cd369d1690d4376973ab74fe4d2a53300ed3dc91869b263
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_inventory_verification_request"><img alt="OCA/stock-logistics-warehouse" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_inventory_verification_request"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/stock-logistics-warehouse/tree/18.0/stock_inventory_verification_request"><img alt="OCA/stock-logistics-warehouse" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/stock-logistics-warehouse-18-0/stock-logistics-warehouse-18-0-stock_inventory_verification_request"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Adds the capability to request a Slot Verification when an inventory is
 ‘Pending to Approve’ or create one at will when a potential issue with a
 specific location is found. When asked from an inventory adjustment,
@@ -406,7 +400,7 @@ <h1>Stock Inventory Verification Request</h1>
 </ul>
 </div>
 <div class="section" id="usage">
-<h2><a class="toc-backref" href="#toc-entry-1">Usage</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 <p>In order to use this module act as follow:</p>
 <ul class="simple">
 <li>From a Inventory Adjustment in state ‘Pending to Approve’ click in the
@@ -421,23 +415,23 @@ <h2><a class="toc-backref" href="#toc-entry-1">Usage</a></h2>
 <p>You can also create the SVR manually.</p>
 </div>
 <div class="section" id="bug-tracker">
-<h2><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_inventory_verification_request%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h2><a class="toc-backref" href="#toc-entry-3">Credits</a></h2>
+<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
 <div class="section" id="authors">
-<h3><a class="toc-backref" href="#toc-entry-4">Authors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
 <ul class="simple">
 <li>ForgeFlow</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h3><a class="toc-backref" href="#toc-entry-5">Contributors</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Lois Rilo Antelo &lt;<a class="reference external" href="mailto:lois.rilo&#64;forgeflow.com">lois.rilo&#64;forgeflow.com</a>&gt;</li>
 <li>Michael Allen &lt;<a class="reference external" href="mailto:mallen&#64;opensourceintegrators.com">mallen&#64;opensourceintegrators.com</a>&gt;</li>
@@ -447,11 +441,9 @@ <h3><a class="toc-backref" href="#toc-entry-5">Contributors</a></h3>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h3><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h3>
+<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
@@ -462,6 +454,5 @@ <h3><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h3>
 </div>
 </div>
 </div>
-</div>
 </body>
 </html>

stock_inventory_verification_request/tests/test_verification_request.py

@@ -684,3 +684,57 @@ def test_action_view_quants(self):
             action["domain"],
             "Domain must filter the correct quant ID.",
         )
+
+    def test_09_product_related_fields(self):
+        svr = self.obj_svr.create(
+            {
+                "location_id": self.test_loc.id,
+                "state": "wait",
+                "product_id": self.product1.id,
+            }
+        )
+        self.assertEqual(
+            svr.product_name, "Test Product 1", "Product name not set correctly in SVR."
+        )
+        self.assertEqual(
+            svr.product_default_code,
+            "PROD1",
+            "Product default code not set correctly in SVR.",
+        )
+
+    def test_10_processed_by(self):
+        svr = self.obj_svr.create(
+            {
+                "location_id": self.test_loc.id,
+                "state": "wait",
+                "product_id": self.product1.id,
+            }
+        )
+        self.assertFalse(svr.processed_by)
+        svr.action_confirm()
+        self.assertFalse(
+            svr.processed_by, "Processed By should remain empty after confirm."
+        )
+        svr.action_solved()
+        self.assertEqual(
+            svr.processed_by.id,
+            self.env.uid,
+            "Processed By not set correctly after solved action.",
+        )
+        svr_cancel = self.obj_svr.create(
+            {
+                "location_id": self.test_loc.id,
+                "state": "wait",
+                "product_id": self.product1.id,
+            }
+        )
+        svr_cancel.action_confirm()
+        self.assertFalse(
+            svr_cancel.processed_by, "Processed By should remain empty after confirm."
+        )
+        svr_cancel.action_cancel()
+        self.assertEqual(
+            svr_cancel.processed_by.id,
+            self.env.uid,
+            "Processed By not set correctly after cancel action.",
+        )

stock_inventory_verification_request/views/stock_move_line_views.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- Copyright 2025 ForgeFlow S.L.
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="view_move_line_tree_svr" model="ir.ui.view">
+        <field name="name">stock.move.line.tree.svr</field>
+        <field name="model">stock.move.line</field>
+        <field name="inherit_id" ref="stock.view_move_line_tree" />
+        <field name="arch" type="xml">
+            <list position="attributes">
+                <attribute name="default_order">date desc</attribute>
+            </list>
+        </field>
+    </record>
+    <record id="action_move_lines_svr" model="ir.actions.act_window">
+        <field name="name">Product Moves Involved</field>
+        <field name="res_model">stock.move.line</field>
+        <field name="view_mode">list,form</field>
+        <field
+            name="view_id"
+            ref="stock_inventory_verification_request.view_move_line_tree_svr"
+        />
+        <field name="domain">[]</field>
+        <field name="context">{}</field>
+    </record>
+</odoo>

stock_inventory_verification_request/views/stock_slot_verification_request_view.xml

@@ -9,13 +9,16 @@
         <field name="arch" type="xml">
             <list default_order="id desc">
                 <field name="name" />
+                <field name="product_id" invisible="1" />
+                <field name="product_default_code" />
+                <field name="product_name" />
                 <field name="location_id" />
-                <field name="product_id" />
                 <field name="lot_id" groups="stock.group_production_lot" />
-                <field name="create_uid" readonly="1" />
+                <field name="create_uid" readonly="1" invisible="1" />
                 <field name="create_date" readonly="1" />
                 <field name="responsible_id" />
-                <field name="inventory_id" />
+                <field name="inventory_id" optional="hide" />
+                <field name="processed_by" />
                 <field name="state" />
                 <field name="company_id" groups="base.group_multi_company" />
             </list>
@@ -90,9 +93,9 @@
                             <field
                                 name="involved_move_line_count"
                                 widget="statinfo"
-                                string="Stock Moves Involved"
-                                help="Stock Moves related to the given location and product."
+                                help="Product Moves related to the given location and Product/lot."
                                 modifiers="{'readonly': true}"
+                                string="Product Moves Involved"
                             />
                         </button>
                         <button
@@ -129,11 +132,12 @@
                                 name="company_id"
                                 groups="base.group_multi_company"
                             />
-                            <field name="create_uid" readonly="1" />
                             <field name="create_date" readonly="1" />
+                            <field name="create_uid" readonly="1" invisible="1" />
                             <field name="responsible_id" />
                             <field name="inventory_id" />
-                            <field name="quant_id" />
+                            <field name="processed_by" readonly="1" />
+                            <field name="quant_id" invisible="1" />
                         </group>
                         <group>
                             <field name="notes" />