Skip to content

Commit b494243

Browse files
committed
[IMP] stock_request_tier_validation: add usererrors to avoid completion with a validation still pending
1 parent 9395bdf commit b494243

File tree

4 files changed

+57
-1
lines changed

4 files changed

+57
-1
lines changed

stock_request_tier_validation/i18n/es.po

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,20 @@ msgstr "Estado de la Validación"
136136
msgid "Validations"
137137
msgstr "Validaciones"
138138

139+
#. module: stock_request_tier_validation
140+
#. odoo-python
141+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
142+
#, python-format
143+
msgid "You cannot confirm a stock request order that has been rejected."
144+
msgstr "No puedes confirmar un pedido de existencias que ha sido rechazado."
145+
146+
#. module: stock_request_tier_validation
147+
#. odoo-python
148+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
149+
#, python-format
150+
msgid "You cannot confirm a stock request order that is pending validation."
151+
msgstr "No puedes confirmar un pedido de existencias que está pendiente de validación."
152+
139153
#~ msgid "Rejected"
140154
#~ msgstr "Rechazado"
141155

stock_request_tier_validation/i18n/it.po

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,21 @@ msgstr "Messaggio per 'Da validare'"
118118
msgid "Validated"
119119
msgstr "Approvata"
120120

121+
#. module: stock_request_tier_validation
122+
#. odoo-python
123+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
124+
#, python-format
125+
msgid "You cannot confirm a stock request order that has been rejected."
126+
msgstr "Non puoi confermare una richiesta di magazzino che è stata rifiutata."
127+
128+
#. module: stock_request_tier_validation
129+
#. odoo-python
130+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
131+
#, python-format
132+
msgid "You cannot confirm a stock request order that is pending validation."
133+
msgstr "Non puoi confermare una richiesta di magazzino che è in attesa di convalida."
134+
135+
121136
#. module: stock_request_tier_validation
122137
#: model:ir.model.fields,field_description:stock_request_tier_validation.field_stock_request__validated_message
123138
#: model:ir.model.fields,field_description:stock_request_tier_validation.field_stock_request_order__validated_message

stock_request_tier_validation/i18n/stock_request_tier_validation.pot

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,3 +132,17 @@ msgstr ""
132132
#: model:ir.model.fields,field_description:stock_request_tier_validation.field_stock_request_order__review_ids
133133
msgid "Validations"
134134
msgstr ""
135+
136+
#. module: stock_request_tier_validation
137+
#. odoo-python
138+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
139+
#, python-format
140+
msgid "You cannot confirm a stock request order that has been rejected."
141+
msgstr ""
142+
143+
#. module: stock_request_tier_validation
144+
#. odoo-python
145+
#: code:addons/stock_request_tier_validation/models/stock_request_order.py:0
146+
#, python-format
147+
msgid "You cannot confirm a stock request order that is pending validation."
148+
msgstr ""

stock_request_tier_validation/models/stock_request_order.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Copyright 2019-2020 ForgeFlow S.L. (https://www.forgeflow.com)
22
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
3-
from odoo import api, models
3+
from odoo import _, api, models
4+
from odoo.exceptions import UserError
45

56

67
class StockRequestOrder(models.Model):
@@ -16,3 +17,15 @@ def _get_under_validation_exceptions(self):
1617
res = super()._get_under_validation_exceptions()
1718
res.append("route_id")
1819
return res
20+
21+
def action_confirm(self):
22+
for order in self:
23+
if order.validation_status == "rejected":
24+
raise UserError(
25+
_(
26+
"You cannot confirm a stock request order that has been rejected."
27+
)
28+
)
29+
if order.validation_status == "pending":
30+
order.validate_tier()
31+
return super().action_confirm()

0 commit comments

Comments
 (0)