[IMP] attribute_set: remove deprecated code

Author: kobros-tech

attribute_set/models/attribute_attribute.py

@@ -10,7 +10,7 @@
 
 from lxml import etree
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 from ..utils.orm import setup_modifiers
@@ -46,7 +46,6 @@ class AttributeAttribute(models.Model):
         string="Attribute Nature",
         required=True,
         default="custom",
-        store=True,
     )
 
     attribute_type = fields.Selection(
@@ -271,7 +270,7 @@ def _onchange_domain(self):
                 ast.literal_eval(self.domain)
             except ValueError:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "`%(domain)s` is an invalid Domain name.\n"
                         "Specify a Python expression defining a list of triplets.\n"
                         "For example : `[('color', '=', 'red')]`",
@@ -295,7 +294,7 @@ def button_add_options(self):
             # context since 17.0 will be dropped in views
             # unless we suffix it's key with _view_ref
             "context": {"attribute_id_view_ref": self.id},
-            "name": _("Options Wizard"),
+            "name": self.env._("Options Wizard"),
             "view_mode": "form",
             "res_model": "attribute.option.wizard",
             "type": "ir.actions.act_window",
@@ -423,7 +422,7 @@ def write(self, vals):
                 ]
             ):
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "Can't change the type of an attribute. "
                         "Please create a new one."
                     )
@@ -441,7 +440,7 @@ def write(self, vals):
                 ]
             ):
                 raise ValidationError(
-                    _(
+                    self.env._(
                         """Can't change the attribute's Relational Model in order to
                         avoid conflicts with existing objects using this attribute.
                         Please create a new one."""
@@ -453,7 +452,7 @@ def write(self, vals):
                 [("serialized", "!=", vals["serialized"]), ("id", "in", self.ids)]
             ):
                 raise ValidationError(
-                    _(
+                    self.env._(
                         """It is not allowed to change the boolean 'Serialized'.
                         A serialized field can not be change to non-serialized \
                         and vice versa."""

attribute_set/utils/orm.py

@@ -6,43 +6,14 @@
 
 
 def transfer_field_to_modifiers(field, modifiers):
-    default_values = {}
-    state_exceptions = {}
-    for attr in ("invisible", "readonly", "required"):
-        state_exceptions[attr] = []
-        default_values[attr] = bool(field.get(attr))
-    for state, modifs in field.get("states", {}).items():
-        for modif in modifs:
-            if default_values[modif[0]] != modif[1]:
-                state_exceptions[modif[0]].append(state)
-
-    for attr, default_value in default_values.items():
-        if state_exceptions[attr]:
-            modifiers[attr] = [
-                ("state", "not in" if default_value else "in", state_exceptions[attr])
-            ]
-        else:
-            modifiers[attr] = default_value
+    """This module is not used all over the project, but may has a value"""
+    pass
 
 
 # Don't deal with groups, it is done by check_group().
 # Need the context to evaluate the invisible attribute on tree views.
 # For non-tree views, the context shouldn't be given.
 def transfer_node_to_modifiers(node, modifiers, context=None, in_tree_view=False):
-    if node.get("attrs"):
-        modifiers.update(safe_eval(node.get("attrs")))
-
-    if node.get("states"):
-        if "invisible" in modifiers and isinstance(modifiers["invisible"], list):
-            # TODO combine with AND or OR, use implicit AND for now.
-            modifiers["invisible"].append(
-                ("state", "not in", node.get("states").split(","))
-            )
-        else:
-            modifiers["invisible"] = [
-                ("state", "not in", node.get("states").split(","))
-            ]
-
     for a in ("invisible", "readonly", "required"):
         if node.get(a):
             try:
@@ -72,7 +43,6 @@ def simplify_modifiers(modifiers):
 
 def transfer_modifiers_to_node(modifiers, node):
     if modifiers:
-        simplify_modifiers(modifiers)
         node.set("modifiers", json.dumps(modifiers))
 
 

attribute_set/views/attribute_attribute_view.xml

@@ -14,15 +14,13 @@
                     nolabel="1"
                     required="1"
                 />
+                <!-- The field created by this Attribute will be related to the model given
+                    by 'default_model_id' through the menu's context that led to this view -->
+                <field name="model_id" invisible="context.get('default_model_id')" />
                 <separator invisible="nature == 'native'" />
                 <group>
                     <group invisible="nature == 'native'">
-                        <group invisible="context.get('default_model_id')">
-                            <!-- The field created by this Attribute will be related to the model given
-                            by 'default_model_id' through the menu's context that led to this view -->
-                            <field name="model_id" />
-                        </group>
-                        <group invisible="nature == 'native'">
+                        <group>
                             <field
                                 name="field_description"
                                 required="nature == 'custom'"