16.0[IMP] account_loan: Currency on loan not readonly + convert credit/debit for different currencies #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @etobella, |
etobella
reviewed
Sep 4, 2025
acsonefho
suggested changes
Sep 4, 2025
lmarion-source
force-pushed
the
16.0-account_loan_propagate_currency
branch
from
db98d77 to
6b54ed3
Compare
acsonefho
approved these changes
Sep 5, 2025
etobella
reviewed
Sep 8, 2025
etobella
requested changes
Sep 8, 2025
lmarion-source
force-pushed
the
16.0-account_loan_propagate_currency
branch
2 times, most recently
from
93a3374 to
22c8c44
Compare
I changed the commit message, however, I let 2 commits because it's 2 different things : currency not readonly, then convert credit/debit for different currencies. |
|
The commit message must include the module name. |
lmarion-source
force-pushed
the
16.0-account_loan_propagate_currency
branch
3 times, most recently
from
4d557ad to
eebccb4
Compare
1. We allow to change the currency on the loan if the user needs it
2. If the currency on the loan (or on the journal) is different from the one on the company, we do the conversion for credit/debit + add amount in currency on the move line
lmarion-source
force-pushed
the
16.0-account_loan_propagate_currency
branch
from
eebccb4 to
611319a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Business case:
When we create move lines from a journal entry, if the journal is in EUR but the company in USD, the credit/debit is in USD and amount_currency is filled in EUR.
For the loans, we wanted the same behavior : when creating the move lines from the loan line, the credit/debit should be in the currency of the company while the amount_currency is filled with the value in the journal currency