[IMP] Add currency change when loan/journal and company are not on the same currency

Author: lmarion-source

account_loan/models/account_loan_line.py

@@ -283,10 +283,19 @@ def _add_basic_values(self, vals, account):
                 "account_id": (account and account.id)
                 or partner.property_account_payable_id.id,
                 "partner_id": partner.id,
-                "credit": self.payment_amount,
                 "debit": 0,
+                "currency_id": self.loan_id.currency_id.id,
+                "credit": self.loan_id.journal_id.currency_id._convert(
+                    from_amount=self.payment_amount,
+                    to_currency=self.loan_id.company_id.currency_id,
+                    company=self.loan_id.company_id,
+                    date=self.date,
+                    round=False,
+                ),
+                "amount_currency": -self.payment_amount,
             }
         )
+
         return vals
 
     def _add_interests_values(self, vals):
@@ -295,7 +304,15 @@ def _add_interests_values(self, vals):
             {
                 "account_id": self.loan_id.interest_expenses_account_id.id,
                 "credit": 0,
-                "debit": self.interests_amount,
+                "currency_id": self.loan_id.currency_id.id,
+                "debit": self.loan_id.journal_id.currency_id._convert(
+                    from_amount=self.interests_amount,
+                    to_currency=self.loan_id.company_id.currency_id,
+                    company=self.loan_id.company_id,
+                    date=self.date,
+                    round=False,
+                ),
+                "amount_currency": self.interests_amount,
             }
         )
         return vals
@@ -306,7 +323,15 @@ def _add_short_term_account_values(self, vals):
             {
                 "account_id": self.loan_id.short_term_loan_account_id.id,
                 "credit": 0,
-                "debit": self.payment_amount - self.interests_amount,
+                "currency_id": self.loan_id.currency_id.id,
+                "debit": self.loan_id.journal_id.currency_id._convert(
+                    from_amount=self.payment_amount - self.interests_amount,
+                    to_currency=self.loan_id.company_id.currency_id,
+                    company=self.loan_id.company_id,
+                    date=self.date,
+                    round=False,
+                ),
+                "amount_currency": self.payment_amount - self.interests_amount,
             }
         )
         return vals
@@ -317,15 +342,31 @@ def _add_long_term_account_values(self, vals):
             vals.append(
                 {
                     "account_id": self.loan_id.short_term_loan_account_id.id,
-                    "credit": self.long_term_principal_amount,
                     "debit": 0,
+                    "currency_id": self.loan_id.currency_id.id,
+                    "credit": self.loan_id.journal_id.currency_id._convert(
+                        from_amount=self.long_term_principal_amount,
+                        to_currency=self.loan_id.company_id.currency_id,
+                        company=self.loan_id.company_id,
+                        date=self.date,
+                        round=False,
+                    ),
+                    "amount_currency": -self.long_term_principal_amount,
                 }
             )
             vals.append(
                 {
-                    "account_id": self.long_term_loan_account_id.id,
+                    "account_id": self.loan_id.short_term_loan_account_id.id,
                     "credit": 0,
-                    "debit": self.long_term_principal_amount,
+                    "currency_id": self.loan_id.currency_id.id,
+                    "debit": self.loan_id.journal_id.currency_id._convert(
+                        from_amount=self.long_term_principal_amount,
+                        to_currency=self.loan_id.company_id.currency_id,
+                        company=self.loan_id.company_id,
+                        date=self.date,
+                        round=False,
+                    ),
+                    "amount_currency": self.long_term_principal_amount,
                 }
             )
         return vals

account_loan/tests/test_loan.py

@@ -617,3 +617,33 @@ def create_loan(self, type_loan, amount, rate, periods):
         )
         loan.compute_lines()
         return loan
+
+    def test_change_currency(self):
+        loan = self.create_loan("fixed-annuity", 500000, 1, 60)
+        eur_currency = self.env.ref("base.EUR")
+        usd_currency = self.env.ref("base.USD")
+        loan.journal_id.currency_id = eur_currency
+        loan.currency_id = eur_currency
+        loan.company_id.currency_id = usd_currency
+        self.assertEqual(loan.currency_id, loan.journal_id.currency_id)
+        loan.compute_lines()
+        for line in loan.line_ids:
+            self.assertEqual(line.currency_id, loan.currency_id)
+
+        line = loan.line_ids.filtered(lambda r: r.sequence == 1)
+        line.view_process_values()
+
+        move_lines = line.mapped("move_ids.line_ids")
+        # Credit/Debit lines should be in USD, while amount_currency is in EUR
+        self.assertEqual(
+            round(move_lines[0].credit, 2),
+            round(-move_lines[0].amount_currency / eur_currency.rate, 2),
+        )
+        self.assertEqual(
+            round(move_lines[1].debit, 2),
+            round(move_lines[1].amount_currency / eur_currency.rate, 2),
+        )
+        self.assertEqual(
+            round(move_lines[2].debit, 2),
+            round(move_lines[2].amount_currency / eur_currency.rate, 2),
+        )