Merge pull request #604 from viztheman/config-max-connections

Add New "maxConnections" Config Option

Author: NuSkooler

core/config_default.js

@@ -15,6 +15,7 @@ module.exports = () => {
 
             menuFile: 'menu.hjson', //  'oputil.js config new' will set this appropriately in config.hjson; may be full path
             achievementFile: 'achievements.hjson',
+            maxConnections: 0 //  0 or less means 'unlimited'
         },
 
         term: {

core/login_server_module.js

@@ -17,8 +17,6 @@ module.exports = class LoginServerModule extends ServerModule {
         super();
     }
 
-    //  :TODO: we need to max connections -- e.g. from config 'maxConnections'
-
     prepareClient(client, cb) {
         if (client.user.isAuthenticated()) {
             return cb(null);
@@ -41,6 +39,9 @@ module.exports = class LoginServerModule extends ServerModule {
     }
 
     handleNewClient(client, clientSock, modInfo) {
+        const maxConnections = _.get(Config(), 'general.maxConnections');
+        const numConnections = clientConns.clientConnections.length;
+
         clientSock.on('error', err => {
             logger.log.warn({ modInfo, error: err.message }, 'Client socket error');
         });
@@ -54,6 +55,13 @@ module.exports = class LoginServerModule extends ServerModule {
         }
 
         client.rawSocket = clientSock;
+
+        if (maxConnections > 0 && numConnections >= maxConnections) {
+            client.term.write('\nAll nodes are busy. Try again later...\n');
+            client.end();
+            return;
+        }
+
         client.session.serverName = modInfo.name;
         client.session.isSecure = _.isBoolean(client.isSecure)
             ? client.isSecure

misc/config_template.in.hjson

@@ -65,6 +65,9 @@
 
         // Short board description
         description     : 'Yet another awesome ENiGMA½ BBS'
+
+        // Max active nodes (0 = unlimited)
+        maxConnections	: 0
     }
 
     term: {