Skip to content

Commit 83dc53e

Browse files
committed
Remove warnings for newer versions of testing frameworks in app cast testing
1 parent 630863d commit 83dc53e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/NetSparkle.Tests.AppCastGenerator/AppCastMakerTests.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
using System.Diagnostics;
1010
using NetSparkleUpdater.Interfaces;
1111
using NetSparkleUpdater.AppCastHandlers;
12+
using System.Threading.Tasks;
1213

1314
namespace NetSparkle.Tests.AppCastGenerator
1415
{
@@ -858,7 +859,7 @@ public void CheckReleaseNotesLink(AppCastMakerType appCastMakerType)
858859
[Theory]
859860
[InlineData(AppCastMakerType.Xml)]
860861
[InlineData(AppCastMakerType.Json)]
861-
public async void NetSparkleCanParseHumanReadableAppCast(AppCastMakerType appCastMakerType)
862+
public async Task NetSparkleCanParseHumanReadableAppCast(AppCastMakerType appCastMakerType)
862863
{
863864
var tempDir = GetCleanTempDir();
864865
// create dummy file
@@ -1055,7 +1056,7 @@ public void CannotSetVersionViaCLIWithTwoItemsHavingNoVersion(AppCastMakerType a
10551056
[Theory]
10561057
[InlineData(AppCastMakerType.Xml)]
10571058
[InlineData(AppCastMakerType.Json)]
1058-
public async void CanSetCriticalVersion(AppCastMakerType appCastMakerType)
1059+
public async Task CanSetCriticalVersion(AppCastMakerType appCastMakerType)
10591060
{
10601061
// setup test dir
10611062
var tempDir = GetCleanTempDir();
@@ -1145,7 +1146,7 @@ public async void CanSetCriticalVersion(AppCastMakerType appCastMakerType)
11451146
[InlineData(AppCastMakerType.Xml, true)]
11461147
[InlineData(AppCastMakerType.Xml, false)]
11471148
[InlineData(AppCastMakerType.Json, true)]
1148-
public async void CanChangeXmlSignatureOutput(AppCastMakerType appCastMakerType, bool useEdSignatureAttr)
1149+
public async Task CanChangeXmlSignatureOutput(AppCastMakerType appCastMakerType, bool useEdSignatureAttr)
11491150
{
11501151
// setup test dir
11511152
var tempDir = GetCleanTempDir();
@@ -1262,7 +1263,7 @@ public async void CanChangeXmlSignatureOutput(AppCastMakerType appCastMakerType,
12621263
[Theory]
12631264
[InlineData(AppCastMakerType.Xml)]
12641265
[InlineData(AppCastMakerType.Json)]
1265-
public async void CanSetChannel(AppCastMakerType appCastMakerType)
1266+
public async Task CanSetChannel(AppCastMakerType appCastMakerType)
12661267
{
12671268
// setup test dir
12681269
var tempDir = GetCleanTempDir();
@@ -1780,7 +1781,7 @@ public void CanMakeAppCastWithAssemblyData(AppCastMakerType appCastMakerType)
17801781
}
17811782
else
17821783
{
1783-
Assert.True(false, "Failed to build assembly");
1784+
Assert.Fail("Failed to build assembly");
17841785
}
17851786
}
17861787
finally

0 commit comments

Comments
 (0)