Avoid self-recursion in RandomExtensions.make (#1420)

Self-recursion disables optimizations and can lead to `@inferred` reporting
failures as a result, even when `@code_warntype` seemingly suggests that the
code being called is type stable.

As an example, without this patch the following reports failure

    using AbstractAlgebra, Test
    using AbstractAlgebra.RandomExtensions: RandomExtensions, make
    R = polynomial_ring(polynomial_ring(QQ,:x1)[1], :y)[1]
    @inferred make(R, 0:0, 1:10, -10:10)

Author: fingolfin

docs/src/rand.md

@@ -64,7 +64,7 @@ function RandomExtensions.make(S::PolyRing, deg_range::AbstractUnitRange{Int}, v
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, deg_range, vs[1]) # forward to default Make constructor
    else
-      make(S, deg_range, make(R, vs...))
+      Make(S, deg_range, make(R, vs...))
    end
 end
 ```

src/AbsMSeries.jl

@@ -156,7 +156,7 @@ function RandomExtensions.make(S::MSeriesRing,
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, term_range, vs[1])
    else
-      make(S, term_range, make(R, vs...))
+      Make(S, term_range, make(R, vs...))
    end
 end
 

src/Fraction.jl

@@ -928,7 +928,7 @@ function RandomExtensions.make(S::FracField, vs...)
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       RandomExtensions.Make(S, vs[1]) # forward to default Make constructor
    else
-      make(S, make(R, vs...))
+      Make(S, make(R, vs...))
    end
 end
 

src/FreeAssAlgebra.jl

@@ -224,7 +224,7 @@ function RandomExtensions.make(S::AbstractAlgebra.FreeAssAlgebra,
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, term_range, exp_bound, vs[1])
    else
-      make(S, term_range, exp_bound, make(R, vs...))
+      Make(S, term_range, exp_bound, make(R, vs...))
    end
 end
 

src/LaurentMPoly.jl

@@ -103,7 +103,7 @@ function RandomExtensions.make(S::AbstractAlgebra.LaurentMPolyRing,
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, term_range, exp_bound, vs[1])
    else
-      make(S, term_range, exp_bound, make(R, vs...))
+      Make(S, term_range, exp_bound, make(R, vs...))
    end
 end
 

src/MPoly.jl

@@ -1306,7 +1306,7 @@ function RandomExtensions.make(S::AbstractAlgebra.MPolyRing, term_range::Abstrac
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, term_range, exp_bound, vs[1])
    else
-      make(S, term_range, exp_bound, make(R, vs...))
+      Make(S, term_range, exp_bound, make(R, vs...))
    end
 end
 

src/Matrix.jl

@@ -6646,7 +6646,7 @@ function RandomExtensions.make(S::MatSpace, vs...)
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, vs[1]) # forward to default Make constructor
    else
-      make(S, make(R, vs...))
+      Make(S, make(R, vs...))
    end
 end
 

src/MatrixAlgebra.jl

@@ -314,7 +314,7 @@ function RandomExtensions.make(S::MatAlgebra, vs...)
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, vs[1]) # forward to default Make constructor
    else
-      make(S, make(R, vs...))
+      Make(S, make(R, vs...))
    end
 end
 

src/Module.jl

@@ -286,7 +286,7 @@ function RandomExtensions.make(M::FPModule, vs...)
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(M, vs[1]) # forward to default Make constructor
    else
-      make(M, make(R, vs...))
+      Make(M, make(R, vs...))
    end
 end
 

src/NCPoly.jl

@@ -684,7 +684,7 @@ function RandomExtensions.make(S::NCPolyRing, deg_range::AbstractUnitRange{Int},
    if length(vs) == 1 && elem_type(R) == Random.gentype(vs[1])
       Make(S, deg_range, vs[1]) # forward to default Make constructor
    else
-      make(S, deg_range, make(R, vs...))
+      Make(S, deg_range, make(R, vs...))
    end
 end