Fix model binding callback signature (to avoid updating DOM if that's wh... #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where the model change originated)
Contributor
Author
|
Fixes #15 |
Member
|
@KidkArolis This is a tough one to test since it has to do with the cursor position while typing. Thanks for troubleshooting and submitting the fix! |
Contributor
Author
|
Unit testing smaller functions could help, but that would require splitting stickit() function into smaller functions. |
Member
|
Yeah, we have been adding too much code, without refactoring. But even after splitting up the code it would be hard to unit test more than the api because of the closure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ere the model change originated)
Do you guys want a test? Wasn't sure what kind of test would be appropriate.