lint: temp dir

* add 'usetesting' linter

Signed-off-by: Alex Aizman <[email protected]>

Author: alex-aizman

.golangci.yml

@@ -22,6 +22,7 @@ linters:
     - gosec
     - gosimple
     - govet
+    # iface
     - importas
     - ineffassign
     - intrange
@@ -32,13 +33,15 @@ linters:
     - prealloc
     - protogetter
     - reassign
+    # recvcheck
     - revive
     - staticcheck
     - testpackage
     - typecheck
     - unconvert
     - unparam
     - unused
+    - usetesting
     - whitespace
 
 # See: https://golangci-lint.run/usage/linters/

ais/test/promote_test.go

@@ -8,7 +8,6 @@ import (
 	"fmt"
 	iofs "io/fs"
 	"math/rand/v2"
-	"os"
 	"os/exec"
 	"path/filepath"
 	"strings"
@@ -129,17 +128,15 @@ func (test *prmTests) do(t *testing.T, bck *meta.Bck) {
 	)
 	m.saveCluState(m.proxyURL)
 
-	tempdir, err := os.MkdirTemp("", "prm")
-	tassert.CheckFatal(t, err)
+	tempdir := t.TempDir()
 	subdirFQN := filepath.Join(tempdir, subdir)
-	err = cos.CreateDir(subdirFQN)
+	err := cos.CreateDir(subdirFQN)
 	tassert.CheckFatal(t, err)
 
 	if m.bck.IsRemote() {
 		m.del()
 	}
 	t.Cleanup(func() {
-		_ = os.RemoveAll(tempdir)
 		if m.bck.IsRemote() {
 			m.del()
 		}

ais/test/scripted_cli_test.go

@@ -6,7 +6,6 @@ package integration_test
 
 import (
 	"fmt"
-	"os"
 	"os/exec"
 	"sort"
 	"strconv"
@@ -153,12 +152,7 @@ func TestMultipartUploadUsingScript(t *testing.T) {
 		Long: true,
 	})
 
-	tempdir, err := os.MkdirTemp("", "s3-mpt")
-	tassert.CheckFatal(t, err)
-	t.Cleanup(func() {
-		_ = os.RemoveAll(tempdir)
-	})
-
+	tempdir := t.TempDir()
 	bck := cmn.Bck{Name: trand.String(10), Provider: apc.AIS}
 
 	// 1. set MD5 to satisfy `s3cmd` (for details, see docs/s3cmd.md & docs/s3compat.md)
@@ -238,11 +232,7 @@ func TestRemaisDeleteUsingScript(t *testing.T) {
 		remaisScript = "./scripts/remais-del-list-deleted.sh"
 	)
 	// 1. create temp root
-	root, err := os.MkdirTemp("", "ais-lpi-")
-	tassert.CheckFatal(t, err)
-	defer func() {
-		os.RemoveAll(root)
-	}()
+	root := t.TempDir()
 
 	//
 	// 2. script #1: generate

ais/tgtobj.go

@@ -741,6 +741,7 @@ fin:
 		if !retried {
 			nlog.Warningln("retrying", goi.lom.String(), err)
 			retried = true
+			cold = false
 			goto do
 		}
 	}

fs/lpi_test.go

@@ -8,7 +8,6 @@ package fs_test
 import (
 	"fmt"
 	"math/rand/v2"
-	"os"
 	"os/exec"
 	"strconv"
 	"strings"
@@ -29,13 +28,7 @@ const (
 
 func TestLocalPageIterator(t *testing.T) {
 	// 1. create temp root
-	root, err := os.MkdirTemp("", "ais-lpi-")
-	tassert.CheckFatal(t, err)
-	defer func() {
-		if !t.Failed() {
-			os.RemoveAll(root)
-		}
-	}()
+	root := t.TempDir()
 
 	// 2. generate
 	cmd := exec.Command(lpiTestScript, "--root_dir", root)

fs/walk_test.go

@@ -47,10 +47,9 @@ func TestWalkBck(t *testing.T) {
 			}()
 
 			for range test.mpathCnt {
-				mpath, err := os.MkdirTemp("", "testwalk")
-				tassert.CheckFatal(t, err)
+				mpath := t.TempDir()
 
-				err = cos.CreateDir(mpath)
+				err := cos.CreateDir(mpath)
 				tassert.CheckFatal(t, err)
 
 				_, err = fs.Add(mpath, "daeID")
@@ -133,10 +132,9 @@ func TestWalkBckSkipDir(t *testing.T) {
 	}()
 
 	for range mpathCnt {
-		mpath, err := os.MkdirTemp("", "testwalk")
-		tassert.CheckFatal(t, err)
+		mpath := t.TempDir()
 
-		err = cos.CreateDir(mpath)
+		err := cos.CreateDir(mpath)
 		tassert.CheckFatal(t, err)
 
 		_, err = fs.Add(mpath, "daeID")

tools/file.go

@@ -1,3 +1,4 @@
+//nolint:usetesting // need mkdir(dir = bdir)
 // Package tools provides common tools and utilities for all unit and integration tests
 /*
  * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.