Skip to content

Commit b0fc5cb

Browse files
authored
Better log (#175)
* chore(): @myunisoft/redis#3.3.1 * feature(customLogger): add requestId in log info * test(): update ut
1 parent 6f264a4 commit b0fc5cb

File tree

12 files changed

+184
-45
lines changed

12 files changed

+184
-45
lines changed

package-lock.json

Lines changed: 120 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"validation"
3333
],
3434
"dependencies": {
35-
"@myunisoft/redis": "github:MyUnisoft/redis#v3.2.6",
35+
"@myunisoft/redis": "github:MyUnisoft/redis#v3.3.1",
3636
"ajv": "^8.12.0",
3737
"pino-pretty": "^10.2.3",
3838
"ts-pattern": "^4.3.0"

src/utils/index.ts

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,17 @@ import { EventOptions, Events, GenericEvent } from "../types";
77

88
// CONSTANTS
99
const ajv = new Ajv();
10-
const kCustomKey = "scope";
10+
const kScopeKey = "scope";
11+
const kMetadataKey = "metadata";
12+
const kOriginKey = "origin";
1113
const kScopeKeys = Object.freeze({
1214
eventTransactionId: "event-id",
1315
transactionId: "t-id",
1416
schemaId: "s",
1517
firmId: "f",
1618
accountingFolderId: "acf",
17-
persPhysiqueId: "p"
19+
persPhysiqueId: "p",
20+
requestId: "req-id"
1821
});
1922

2023
export type OperationFunctions = Record<string, any>;
@@ -72,12 +75,20 @@ function* mapped<
7275
continue;
7376
}
7477

75-
if (!event[kCustomKey] || !event[kCustomKey][key]) {
78+
const originExist = event[kMetadataKey] && event[kMetadataKey][kOriginKey];
79+
80+
if (!event[kScopeKey] || !event[kScopeKey][key]) {
81+
if (originExist && event[kMetadataKey][kOriginKey][key]) {
82+
yield `${formattedKey}:${logValueFallback(event[kMetadataKey][kOriginKey][key])}`;
83+
84+
continue;
85+
}
86+
7687
yield `${formattedKey}:none`;
7788

7889
continue;
7990
}
8091

81-
yield `${formattedKey}:${logValueFallback(event[kCustomKey][key])}`;
92+
yield `${formattedKey}:${logValueFallback(event[kScopeKey][key])}`;
8293
}
8394
}

test/UT/class/eventManagement/dispatcher.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import {
88
closeRedis,
99
Channel,
1010
closeAllRedis,
11-
clearAllKeys
11+
clearAllKeys,
12+
getRedis
1213
} from "@myunisoft/redis";
1314
import * as Logger from "pino";
1415
import Ajv from "ajv";
@@ -17,7 +18,6 @@ import Ajv from "ajv";
1718
import { Dispatcher, EventOptions, Events } from "../../../../src/index";
1819
import * as EventsSchemas from "../../schema/index";
1920
import { Transaction, TransactionStore } from "../../../../src/class/store/transaction.class";
20-
import { IncomerStore } from "../../../../src/class/store/incomer.class";
2121

2222
// Internal Dependencies Mocks
2323
const logger = Logger.pino({
@@ -47,6 +47,8 @@ describe("Dispatcher", () => {
4747
port: Number(process.env.REDIS_PORT),
4848
host: process.env.REDIS_HOST
4949
});
50+
51+
await getRedis()!.flushall();
5052
});
5153

5254
afterAll(async() => {

test/UT/class/eventManagement/events.spec.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
initRedis,
77
closeAllRedis,
88
clearAllKeys,
9-
Channel
9+
Channel,
10+
getRedis
1011
} from "@myunisoft/redis";
1112
import * as Logger from "pino";
1213

@@ -81,6 +82,8 @@ describe("Publishing/exploiting a custom event", () => {
8182
host: process.env.REDIS_HOST
8283
} as any);
8384

85+
await getRedis()!.flushall();
86+
8487
await initRedis({
8588
port: process.env.REDIS_PORT,
8689
host: process.env.REDIS_HOST
@@ -259,7 +262,12 @@ describe("Publishing/exploiting a custom event", () => {
259262
},
260263
metadata: {
261264
agent: "jest",
262-
createdAt: Date.now()
265+
createdAt: Date.now(),
266+
origin: {
267+
endpoint: "/foo",
268+
method: "POST",
269+
requestId: "1"
270+
}
263271
}
264272
};
265273

test/UT/class/eventManagement/externals.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ import { randomUUID } from "node:crypto";
44
// Import Third-party Dependencies
55
import {
66
initRedis,
7-
closeAllRedis
7+
closeAllRedis,
8+
getRedis
89
} from "@myunisoft/redis";
910
import * as Logger from "pino";
1011

@@ -25,6 +26,8 @@ beforeAll(async() => {
2526
port: Number(process.env.REDIS_PORT),
2627
host: process.env.REDIS_HOST
2728
}, "subscriber");
29+
30+
await getRedis()!.flushall();
2831
});
2932

3033
afterAll(async() => {

test/UT/class/eventManagement/handle-inactive-no-backup.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
initRedis,
77
clearAllKeys,
88
Channel,
9-
closeAllRedis
9+
closeAllRedis,
10+
getRedis
1011
} from "@myunisoft/redis";
1112
import * as Logger from "pino";
1213

@@ -36,6 +37,8 @@ describe("Publishing/exploiting a custom event & inactive incomer", () => {
3637
host: process.env.REDIS_HOST
3738
} as any);
3839

40+
await getRedis()!.flushall();
41+
3942
await initRedis({
4043
port: process.env.REDIS_PORT,
4144
host: process.env.REDIS_HOST

test/UT/class/eventManagement/handle-inactive-with-backup.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ import {
77
initRedis,
88
clearAllKeys,
99
Channel,
10-
closeAllRedis
10+
closeAllRedis,
11+
getRedis
1112
} from "@myunisoft/redis";
1213
import * as Logger from "pino";
1314

@@ -37,6 +38,8 @@ describe("Publishing/exploiting a custom event & inactive incomer", () => {
3738
host: process.env.REDIS_HOST
3839
} as any);
3940

41+
await getRedis()!.flushall();
42+
4043
await initRedis({
4144
port: process.env.REDIS_PORT,
4245
host: process.env.REDIS_HOST

test/UT/class/eventManagement/incomer.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ import timers from "node:timers/promises";
44
// Import Third-party Dependencies
55
import {
66
initRedis,
7-
closeAllRedis
7+
closeAllRedis,
8+
getRedis
89
} from "@myunisoft/redis";
910

1011
// Import Internal Dependencies
@@ -33,6 +34,8 @@ describe("Init Incomer without Dispatcher alive", () => {
3334
host: process.env.REDIS_HOST
3435
} as any);
3536

37+
await getRedis()!.flushall();
38+
3639
await initRedis({
3740
port: process.env.REDIS_PORT,
3841
host: process.env.REDIS_HOST

test/UT/class/eventManagement/ping.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import timers from "timers/promises";
66
import {
77
initRedis,
88
clearAllKeys,
9-
closeAllRedis
9+
closeAllRedis,
10+
getRedis
1011
} from "@myunisoft/redis";
1112
import * as Logger from "pino";
1213

@@ -33,6 +34,8 @@ describe("Ping", () => {
3334
host: process.env.REDIS_HOST
3435
} as any);
3536

37+
await getRedis()!.flushall();
38+
3639
await initRedis({
3740
port: process.env.REDIS_PORT,
3841
host: process.env.REDIS_HOST

0 commit comments

Comments
 (0)