Skip to content

Commit 94a7c3d

Browse files
Fix build_targets in xcschemes to accept string labels (#2864)
Signed-off-by: Brentley Jones <[email protected]>
1 parent 442deb8 commit 94a7c3d

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

tools/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ _XCSCHEMES = [
108108
),
109109
run = xcschemes.run(
110110
build_targets = [
111-
xcschemes.top_level_build_target(_TOOLS["import_indexstores"]),
111+
_TOOLS["import_indexstores"],
112112
],
113113
diagnostics = _XCSCHEME_DIAGNOSTICS,
114114
launch_target = xcschemes.launch_target(
@@ -276,7 +276,7 @@ _XCSCHEMES = [
276276
),
277277
run = xcschemes.run(
278278
build_targets = [
279-
xcschemes.top_level_build_target(_TOOLS["swiftc_stub"]),
279+
_TOOLS["swiftc_stub"],
280280
],
281281
diagnostics = _XCSCHEME_DIAGNOSTICS,
282282
launch_target = xcschemes.launch_target(

xcodeproj/internal/xcschemes/xcscheme_labels.bzl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ load(
77
)
88

99
def _resolve_build_target_labels(build_target):
10+
if type(build_target) == "string":
11+
return _resolve_label(build_target)
12+
1013
return struct(
1114
extension_host = _resolve_label(build_target.extension_host),
1215
include = build_target.include,
@@ -23,6 +26,7 @@ def _resolve_build_target_labels(build_target):
2326
def _resolve_label(label_str):
2427
if not label_str:
2528
return ""
29+
2630
return str(native.package_relative_label(label_str))
2731

2832
def _resolve_labels(schemes):

0 commit comments

Comments
 (0)