getDefinitionAtPosition doesn't distinguish different kinds in a merged declaration

[jeffreymorlan]

TypeScript Version: 2.7.2

Search Terms: getDefinitionAtPosition kind

Code

namespace A { export interface B {} }
class A {}
interface A {}

var x: A; // do getDefinitionAtPosition on the A reference here

Expected behavior:
In the result, each of the individual declarations should have the appropriate kind:

[
    { fileName: 'test.ts', textSpan: { start: 10, length: 1 }, kind: 'module', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 44, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 59, length: 1 }, kind: 'interface', name: 'A', ... }
]

Actual behavior:
All declarations have the same kind:

[
    { fileName: 'test.ts', textSpan: { start: 10, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 44, length: 1 }, kind: 'class', name: 'A', ... },
    { fileName: 'test.ts', textSpan: { start: 59, length: 1 }, kind: 'class', name: 'A', ... }
]

[mhegazy]

PRs welcomed.

[jhart100187]

Hi, I'm in the process of reviewing this issue as my first issue, and I think I've narrowed it down to the getSymbolAtLocation function in checker.ts. Is that the right track so far? I can't figure out how to step through the code in VS Code, so I'm having to base my guess on intuition. I've setup a fourslash test that recreates the issue, so hopefully I can solve this issue soon.

function getSymbolAtLocation(node: Node): Symbol | undefined

Line 25838 in checker.ts

[mhegazy]

I've narrowed it down to the getSymbolAtLocation function in checker.ts. Is that the right track so far?

You do not want to change this one. instead, when you have a definition you want to get its meaning, using getMeaningFromLocation and filtering the definitions you have to match the meaning you are looking for.

See the use of hasMatchingMeaning in findAllRefernces.ts

[vipulbhj]

where will I find findAllRefernces.ts
Literally been looking for it for the last half an hour. I am an absolute beginner, sorry if this is a stupid question

[kristielim]

would like to take a look at this for GraceHopperOSD

[mengdidi]

Worked with kristielim for GraceHopperOSD

[yehee]

@kristielim @mengdidi Hi! I was looking into the issue but wondering if this has already been worked on. Thanks!