Skip to content

Commit d79d872

Browse files
committed
Make the review-shell purer
The purpose of this `env` is to add the binaries to the `PATH`. The benefit of making it purer is that unwrapped programs missing dependencies may fail. As a added benefit this dramatically reduces the collision warnings from `buildEnv` `warning: collision between `/nix/store/82icynaidvzyic2g349cqi4p9a5d4aa2-vimplugin-ai.vim-2023-10-03/doc/tags' and `/nix/store/qc4bdwi6zhk4r1vzbcxrnwrrjnm33a6g-vimplugin-CheckAttach-2019-05-08/doc/tags'`
1 parent cfae4ff commit d79d872

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

nixpkgs_review/nix.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ def write_shell_expression(
312312
env = buildEnv {
313313
name = "env";
314314
inherit paths;
315+
pathsToLink = [ "/bin" ];
315316
ignoreCollisions = true;
316317
};
317318
in (import ./nixpkgs { }).mkShell {

0 commit comments

Comments
 (0)