-
-
Notifications
You must be signed in to change notification settings - Fork 254
Closed
Labels
bugSomething isn't workingSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.
Description
Explanation
- Resolve type errors in NetworkController and its downstream packages that were marked with
@ts-expect-error TODO:annotations in deps: Bump@metamask/{eth-json-rpc-provider,rpc-errors}#1653. - Affected packages:
network-controller,selected-network-controller,transaction-controller,gas-fee-controller
Tasks
Provider type alignment
ProxyWithAccessibleTarget<SafeEventEmitterProvider>(@metamask/network-controller) vs.Provider(@metamask/eth-query)
error TS2345: Argument of type 'ProxyWithAccessibleTarget<SafeEventEmitterProvider>' is not assignable to parameter of type 'Provider<JsonRpcParams, Json>'.
Types of property 'sendAsync' are incompatible.
Type '(req: JsonRpcRequest<JsonRpcParams>, callback: (error: unknown, providerRes?: any) => void) => void' is not assignable to type '<Params, Result>(payload: SendAsyncPayload<Params>, callback: ProviderSendAsyncCallback<Result>) => void'.
Types of parameters 'req' and 'payload' are incompatible.
Type 'SendAsyncPayload<Params>' is not assignable to type 'JsonRpcRequest<JsonRpcParams>'.SafeEventEmitterProviderProviderProxyFakeProvider
References
Metadata
Metadata
Labels
bugSomething isn't workingSomething isn't workingteam-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.