Skip to content

Commit 80ed1a3

Browse files
authored
Add release workflows (#1071)
1 parent 5676d14 commit 80ed1a3

File tree

4 files changed

+151
-0
lines changed

4 files changed

+151
-0
lines changed
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
name: Create Release Pull Request
2+
3+
on:
4+
workflow_dispatch:
5+
inputs:
6+
base-branch:
7+
description: 'The base branch for git operations and the pull request.'
8+
default: 'master'
9+
required: true
10+
release-type:
11+
description: 'A SemVer version diff, i.e. major, minor, patch, prerelease etc. Mutually exclusive with "release-version".'
12+
required: false
13+
release-version:
14+
description: 'A specific version to bump to. Mutually exclusive with "release-type".'
15+
required: false
16+
17+
jobs:
18+
create-release-pr:
19+
runs-on: ubuntu-latest
20+
permissions:
21+
contents: write
22+
pull-requests: write
23+
steps:
24+
- uses: actions/checkout@v2
25+
with:
26+
# This is to guarantee that the most recent tag is fetched.
27+
# This can be configured to a more reasonable value by consumers.
28+
fetch-depth: 0
29+
# We check out the specified branch, which will be used as the base
30+
# branch for all git operations and the release PR.
31+
ref: ${{ github.event.inputs.base-branch }}
32+
- name: Get Node.js version
33+
id: nvm
34+
run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
35+
- uses: actions/setup-node@v2
36+
with:
37+
node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
38+
- uses: MetaMask/action-create-release-pr@v1
39+
env:
40+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
41+
with:
42+
release-type: ${{ github.event.inputs.release-type }}
43+
release-version: ${{ github.event.inputs.release-version }}

.github/workflows/publish-release.yml

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
name: Publish Release
2+
3+
on:
4+
push:
5+
branches: [master]
6+
7+
jobs:
8+
is-release:
9+
# release merge commits come from GitHub user
10+
if: github.event.head_commit.committer.name == 'GitHub'
11+
outputs:
12+
IS_RELEASE: ${{ steps.is-release.outputs.IS_RELEASE }}
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: MetaMask/[email protected]
16+
id: is-release
17+
18+
publish-release:
19+
permissions:
20+
contents: write
21+
if: needs.is-release.outputs.IS_RELEASE == 'true'
22+
runs-on: ubuntu-latest
23+
needs: is-release
24+
steps:
25+
- uses: actions/checkout@v2
26+
with:
27+
ref: ${{ github.sha }}
28+
- name: Get Node.js version
29+
id: nvm
30+
run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
31+
- name: Setup Node
32+
uses: actions/setup-node@v2
33+
with:
34+
node-version: ${{ steps.nvm.outputs.NODE_VERSION }}
35+
- uses: MetaMask/[email protected]
36+
env:
37+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
38+
39+
publish-npm-dry-run:
40+
runs-on: ubuntu-latest
41+
needs: publish-release
42+
steps:
43+
- uses: actions/checkout@v2
44+
with:
45+
ref: ${{ github.sha }}
46+
- name: Dry Run Publish
47+
# omit npm-token token to perform dry run publish
48+
uses: MetaMask/[email protected]
49+
50+
publish-npm:
51+
environment: npm-publish
52+
runs-on: ubuntu-latest
53+
needs: publish-npm-dry-run
54+
steps:
55+
- uses: actions/checkout@v2
56+
with:
57+
ref: ${{ github.sha }}
58+
- name: Publish
59+
uses: MetaMask/[email protected]
60+
with:
61+
npm-token: ${{ secrets.NPM_TOKEN }}

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Changelog
2+
All notable changes to this project will be documented in this file.
3+
4+
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
5+
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
6+
7+
## [Unreleased]
8+
9+
[Unreleased]: https://github.com/MetaMask/controllers/compare/v1.35.0...HEAD

README.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,41 @@ Tokens should include a field `"erc20": true`, and can include additional fields
6666
- decimals (precision of the tokens stored)
6767
6868
A full list of permitted fields can be found in the [permitted-fields.json](./permitted-fields.json) file.
69+
70+
### Release & Publishing
71+
72+
The project follows the same release process as the other libraries in the MetaMask organization. The GitHub Actions [`action-create-release-pr`](https://github.com/MetaMask/action-create-release-pr) and [`action-publish-release`](https://github.com/MetaMask/action-publish-release) are used to automate the release process; see those repositories for more information about how they work.
73+
74+
1. Choose a release version.
75+
76+
- The release version should be chosen according to SemVer. Analyze the changes to see whether they include any breaking changes, new features, or deprecations, then choose the appropriate SemVer version. See [the SemVer specification](https://semver.org/) for more information.
77+
78+
2. If this release is backporting changes onto a previous release, then ensure there is a major version branch for that version (e.g. `1.x` for a `v1` backport release).
79+
80+
- The major version branch should be set to the most recent release with that major version. For example, when backporting a `v1.0.2` release, you'd want to ensure there was a `1.x` branch that was set to the `v1.0.1` tag.
81+
82+
3. Trigger the [`workflow_dispatch`](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_dispatch) event [manually](https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow) for the `Create Release Pull Request` action to create the release PR.
83+
84+
- For a backport release, the base branch should be the major version branch that you ensured existed in step 2. For a normal release, the base branch should be the main branch for that repository (which should be the default value).
85+
- This should trigger the [`action-create-release-pr`](https://github.com/MetaMask/action-create-release-pr) workflow to create the release PR.
86+
87+
4. Update the changelog to move each change entry into the appropriate change category ([See here](https://keepachangelog.com/en/1.0.0/#types) for the full list of change categories, and the correct ordering), and edit them to be more easily understood by users of the package.
88+
89+
- Generally any changes that don't affect consumers of the package (e.g. lockfile changes or development environment changes) are omitted. Exceptions may be made for changes that might be of interest despite not having an effect upon the published package (e.g. major test improvements, security improvements, improved documentation, etc.).
90+
- Try to explain each change in terms that users of the package would understand (e.g. avoid referencing internal variables/concepts).
91+
- Consolidate related changes into one change entry if it makes it easier to explain.
92+
- Run `yarn auto-changelog validate --rc` to check that the changelog is correctly formatted.
93+
94+
5. Review and QA the release.
95+
96+
- If changes are made to the base branch, the release branch will need to be updated with these changes and review/QA will need to restart again. As such, it's probably best to avoid merging other PRs into the base branch while review is underway.
97+
98+
6. Squash & Merge the release.
99+
100+
- This should trigger the [`action-publish-release`](https://github.com/MetaMask/action-publish-release) workflow to tag the final release commit and publish the release on GitHub.
101+
102+
7. Publish the release on npm.
103+
104+
- Wait for the `publish-release` GitHub Action workflow to finish. This should trigger a second job (`publish-npm`), which will wait for a run approval by the [`npm publishers`](https://github.com/orgs/MetaMask/teams/npm-publishers) team.
105+
- Approve the `publish-npm` job (or ask somebody on the npm publishers team to approve it for you).
106+
- Once the `publish-npm` job has finished, check npm to verify that it has been published.

0 commit comments

Comments
 (0)