Android Permissions cleanup (#202)

Author: Mateusz-Nejman

Pixed.Android/MainActivity.cs

@@ -1,8 +1,6 @@
 using Android.App;
-using Android.Content;
 using Android.Content.PM;
 using Android.OS;
-using Android.Runtime;
 using Avalonia;
 using Avalonia.Android;
 using Avalonia.ReactiveUI;
@@ -11,7 +9,6 @@
 using Pixed.Application.DependencyInjection;
 using Pixed.Application.IO;
 using Pixed.Application.Platform;
-using System.Threading.Tasks;
 
 namespace Pixed.Android;
 
@@ -22,8 +19,7 @@ namespace Pixed.Android;
     ConfigurationChanges = ConfigChanges.Orientation | ConfigChanges.ScreenSize | ConfigChanges.UiMode)]
 public class MainActivity : AvaloniaMainActivity<App>
 {
-    private TaskCompletionSource<Permission> _permissionTcs;
-    protected override async void OnCreate(Bundle? savedInstanceState)
+    protected override void OnCreate(Bundle? savedInstanceState)
     {
         AndroidX.Core.SplashScreen.SplashScreen.InstallSplashScreen(this);
         PlatformSettings.MainActivity = this;
@@ -34,13 +30,6 @@ protected override async void OnCreate(Bundle? savedInstanceState)
         IPlatformSettings.Instance = new PlatformSettings();
 
         base.OnCreate(savedInstanceState);
-        var permissions = await CheckPermissions();
-
-        if (permissions != Permission.Granted)
-        {
-            Process.KillProcess(Process.MyPid());
-            return;
-        }
     }
     protected override AppBuilder CustomizeAppBuilder(AppBuilder builder)
     {
@@ -50,42 +39,5 @@ protected override AppBuilder CustomizeAppBuilder(AppBuilder builder)
             .UseReactiveUI()
             .UseShell();
     }
-
-    private Task<Permission> CheckPermissions()
-    {
-        if (Environment.IsExternalStorageManager)
-        {
-            return Task.FromResult(Permission.Granted);
-        }
-
-        if (_permissionTcs != null && _permissionTcs.Task.IsCompleted)
-        {
-            _permissionTcs.SetCanceled();
-            _permissionTcs = null;
-        }
-
-        Intent intent = new(global::Android.Provider.Settings.ActionManageAppAllFilesAccessPermission);
-        intent.AddCategory("android.intent.category.DEFAULT");
-        intent.SetData(global::Android.Net.Uri.Parse("package:" + PackageName));
-        StartActivityForResult(intent, 1);
-        _permissionTcs = new TaskCompletionSource<Permission>();
-        return _permissionTcs.Task;
-    }
-
-    protected override void OnActivityResult(int requestCode, [GeneratedEnum] Result resultCode, Intent? data)
-    {
-        base.OnActivityResult(requestCode, resultCode, data);
-
-        if (requestCode == 1)
-        {
-            if (Environment.IsExternalStorageManager)
-            {
-                _permissionTcs.TrySetResult(Permission.Granted);
-                return;
-            }
-
-            _permissionTcs.TrySetResult(Permission.Denied);
-        }
-    }
 }
 

Pixed.Android/Properties/AndroidManifest.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:installLocation="auto" package="com.nejman.pixed" android:versionCode="17" android:versionName="1.7">
 	<uses-permission android:name="android.permission.INTERNET" />
-	<uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
 	<application android:label="Pixed" android:icon="@mipmap/pixed_icon" android:theme="@style/Theme.Splash" />
 </manifest>