Skip to content

Commit b2e3172

Browse files
authored
fix afterSetup event not working as described (#38)
1 parent a695ff2 commit b2e3172

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,9 @@ class SentryOptionsContext implements EventListenerInterface
110110

111111
public function setServerContext(Event $event): void
112112
{
113-
/** @var \CakeSentry\Http\SentryClient $subject */
114-
$subject = $event->getSubject();
115-
$options = $subject->getHub()->getClient()->getOptions();
113+
/** @var \Sentry\State\HubInterface $subject */
114+
$hub = $event->getSubject();
115+
$options = $subject->getClient()->getOptions();
116116

117117
$options->setEnvironment('test_app');
118118
$options->setRelease('3.0.0@dev');

src/CakeSentryInit.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use Cake\Event\Event;
99
use Cake\Event\EventManager;
1010
use Cake\Utility\Hash;
11+
use Sentry\SentrySdk;
1112
use function Sentry\init;
1213

1314
class CakeSentryInit
@@ -41,7 +42,7 @@ public static function init(): void
4142
$config = self::getConfig('sentry');
4243
if ($config !== null && Hash::check($config, 'dsn')) {
4344
init($config);
44-
$event = new Event('CakeSentry.Client.afterSetup');
45+
$event = new Event('CakeSentry.Client.afterSetup', SentrySdk::getCurrentHub());
4546
EventManager::instance()->dispatch($event);
4647
}
4748
}

tests/TestCase/Http/ClientTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,8 @@ public function testSetupClientDispatchAfterSetup(): void
108108
$called = false;
109109
EventManager::instance()->on(
110110
'CakeSentry.Client.afterSetup',
111-
function () use (&$called) {
111+
function (Event $event) use (&$called) {
112+
$this->assertInstanceOf(Hub::class, $event->getSubject());
112113
$called = true;
113114
},
114115
);

0 commit comments

Comments
 (0)