Skip to content

Commit 92544c3

Browse files
authored
fabric: list hydra in optional extra (#21165)
* hydra * extra
1 parent 825f683 commit 92544c3

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

requirements/fabric/extra.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# NOTE: the upper bound for the package version is only set for CI stability, and it is dropped while installing this package
2+
# in case you want to preserve/enforce restrictions on the latest compatible version, add "strict" as an in-line comment
3+
4+
hydra-core >=1.2.0, <1.4.0

src/lightning/__setup__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def _prepare_extras() -> dict[str, Any]:
4141
}
4242

4343
# project specific extras groups
44-
extras["fabric-all"] = extras["fabric-strategies"] + extras["fabric-examples"]
44+
extras["fabric-all"] = extras["fabric-extra"] + extras["fabric-strategies"] + extras["fabric-examples"]
4545
extras["fabric-dev"] = extras["fabric-all"] + extras["fabric-test"]
4646
extras["pytorch-all"] = extras["pytorch-extra"] + extras["pytorch-strategies"] + extras["pytorch-examples"]
4747
extras["pytorch-dev"] = extras["pytorch-all"] + extras["pytorch-test"]

src/lightning_fabric/__setup__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def _prepare_extras() -> dict[str, Any]:
4444
}
4545
for req in parse_requirements(extras["strategies"]):
4646
extras[req.key] = [str(req)]
47-
extras["all"] = extras["strategies"] + extras["examples"]
47+
extras["all"] = extras["extra"] + extras["strategies"] + extras["examples"]
4848
extras["dev"] = extras["all"] + extras["test"]
4949
return extras
5050

0 commit comments

Comments
 (0)