Skip to content

Commit e051077

Browse files
committed
fix: P1 fixes
1 parent bdf4a89 commit e051077

File tree

7 files changed

+44
-42
lines changed

7 files changed

+44
-42
lines changed

.changeset/curly-ants-begin.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"live-mobile": minor
3+
---
4+
5+
fix: QA fixes large mover

apps/ledger-live-mobile/src/newArch/components/Swiper/components/SwipeableCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import Animated, {
1010
const { width } = Dimensions.get("window");
1111
const SPRING_CONFIG = {
1212
damping: 30,
13-
stiffness: 200,
13+
stiffness: 400,
1414
};
1515

1616
type SwipeableCardProps = {

apps/ledger-live-mobile/src/newArch/features/LandingPages/screens/LargeMoverLandingPage/components/Card.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export const Card: React.FC<CardProps> = ({
9292
<Svg style={styles.gradientTop}>
9393
<Defs>
9494
<LinearGradient id="midGlowTop" x1="0" y1="0" x2="0" y2="1">
95-
<Stop offset="0" stopColor={middleColor} stopOpacity="0.9" />
95+
<Stop offset="0" stopColor={middleColor} stopOpacity="0.5" />
9696
<Stop offset="0.5" stopColor={middleColor} stopOpacity="0" />
9797
</LinearGradient>
9898
</Defs>
@@ -182,9 +182,9 @@ const styles = StyleSheet.create({
182182
},
183183
gradientTop: {
184184
position: "absolute",
185-
top: -15,
185+
top: -5,
186186
width: width,
187187
height: 100,
188-
zIndex: 1,
188+
zIndex: 11,
189189
},
190190
});

apps/ledger-live-mobile/src/newArch/features/LandingPages/screens/LargeMoverLandingPage/components/Information/InfoCard.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@ export const InfoCard = ({
66
label,
77
value,
88
bg = "neutral.c30",
9+
left = false,
910
}: {
1011
label: string;
1112
value: React.ReactNode;
1213
bg?: string;
14+
left?: boolean;
1315
}) => (
14-
<Flex style={styles.container} bg={bg}>
16+
<Flex style={[styles.container, left && { marginRight: 12 }]} bg={bg}>
1517
<Text style={styles.name} color="neutral.c70">
1618
{label}
1719
</Text>
@@ -22,9 +24,9 @@ export const InfoCard = ({
2224
const styles = StyleSheet.create({
2325
container: {
2426
flexDirection: "column",
25-
padding: 16,
27+
padding: 12,
2628
borderRadius: 16,
27-
width: "48%",
29+
flex: 1,
2830
},
2931
name: {
3032
fontSize: 14,

apps/ledger-live-mobile/src/newArch/features/LandingPages/screens/LargeMoverLandingPage/components/Information/index.tsx

Lines changed: 6 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export const Informations: React.FC<InformationsProps> = props => {
3737

3838
<Flex style={styles.row}>
3939
<InfoCard
40+
left
4041
label={t("largeMover.marketCap")}
4142
value={formatCounterValue(marketCap ?? 0, counterValueCurrency.ticker, locale, t)}
4243
/>
@@ -48,6 +49,7 @@ export const Informations: React.FC<InformationsProps> = props => {
4849

4950
<Flex style={styles.row}>
5051
<InfoCard
52+
left
5153
label={t("largeMover.fdv")}
5254
value={formatCounterValue(fdv ?? 0, counterValueCurrency.ticker, locale, t)}
5355
/>
@@ -64,6 +66,7 @@ export const Informations: React.FC<InformationsProps> = props => {
6466
</Flex>
6567
<Flex style={styles.row}>
6668
<InfoCard
69+
left
6770
label={t("largeMover.circulatingSupply")}
6871
value={formatCounterValue(circulatingSupply ?? 0, "", locale, t, {
6972
ticker,
@@ -75,7 +78,7 @@ export const Informations: React.FC<InformationsProps> = props => {
7578
/>
7679
</Flex>
7780

78-
<Flex paddingBottom={6}>
81+
<Flex paddingBottom={4}>
7982
<AthAtlBlock
8083
label="largeMover.ath"
8184
value={allTimeHigh}
@@ -108,37 +111,12 @@ const styles = StyleSheet.create({
108111
title: {
109112
fontWeight: "bold",
110113
fontSize: 14,
111-
paddingBottom: 16,
114+
paddingBottom: 12,
112115
},
113116
row: {
114117
flexDirection: "row",
115118
justifyContent: "space-between",
116-
paddingBottom: 16,
117-
},
118-
container: {
119-
flexDirection: "column",
120-
padding: 16,
121-
borderRadius: 16,
122-
width: "48%",
123-
},
124-
bigContainer: {
125-
flexDirection: "column",
126-
padding: 12,
127-
borderRadius: 16,
128-
},
129-
rowInside: {
130-
flexDirection: "row",
131-
justifyContent: "space-between",
132-
paddingBottom: 2,
133-
},
134-
name: {
135-
fontSize: 15,
136-
paddingBottom: 6,
137-
},
138-
value: {
139-
fontSize: 15,
140-
fontWeight: "bold",
141-
textTransform: "uppercase",
119+
paddingBottom: 12,
142120
},
143121
date: {
144122
fontSize: 12,

apps/ledger-live-mobile/src/newArch/features/LandingPages/screens/LargeMoverLandingPage/components/Ticker.tsx

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
import React from "react";
2-
import { View, StyleSheet } from "react-native";
2+
import { View, StyleSheet, Platform } from "react-native";
33
import { getCryptoCurrencyById, getCurrencyColor } from "@ledgerhq/live-common/currencies/index";
44
import { Flex, Text } from "@ledgerhq/native-ui";
55
import CircleCurrencyIcon from "~/components/CircleCurrencyIcon";
66
import Svg, { Defs, LinearGradient, Rect, Stop } from "react-native-svg";
7+
import { BlurView } from "@react-native-community/blur";
8+
import { useTheme } from "styled-components/native";
79

810
type TickerProps = {
911
currencyId: string;
1012
width: number;
1113
};
1214

1315
export const Ticker: React.FC<TickerProps> = ({ currencyId, width }) => {
16+
const theme = useTheme();
1417
const currency = getCryptoCurrencyById(currencyId);
1518
const midColor = getCurrencyColor(currency);
1619
return (
@@ -28,10 +31,25 @@ export const Ticker: React.FC<TickerProps> = ({ currencyId, width }) => {
2831
<Flex
2932
flexDirection="row"
3033
alignItems="center"
31-
backgroundColor="opacityDefault.c10"
34+
backgroundColor={Platform.OS === "ios" ? "opacityDefault.c10" : "neutral.c30"}
3235
padding={4}
3336
borderRadius={40}
3437
>
38+
{Platform.OS === "ios" && (
39+
<BlurView
40+
style={{
41+
borderRadius: 25,
42+
position: "absolute",
43+
top: 0,
44+
left: 0,
45+
right: 0,
46+
bottom: 0,
47+
backgroundColor: theme.colors.opacityDefault.c40,
48+
}}
49+
blurType={theme.theme}
50+
blurAmount={7}
51+
/>
52+
)}
3553
<Flex>
3654
<CircleCurrencyIcon currency={currency} size={24} sizeRatio={0.9} />
3755
</Flex>

apps/ledger-live-mobile/src/newArch/features/LandingPages/screens/LargeMoverLandingPage/index.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { LandingPagesNavigatorParamList } from "~/components/RootNavigator/types
77
import { NavigatorName, ScreenName } from "~/const";
88
import { StackNavigatorProps } from "~/components/RootNavigator/types/helpers";
99
import { StickyHeader } from "./components/StickyHeader";
10-
import { Platform, SafeAreaView } from "react-native";
10+
import { SafeAreaView } from "react-native";
1111
import { useTheme } from "styled-components/native";
1212
import { getCurrencyIdsFromTickers, rangeMap } from "./utils";
1313
import { SwiperComponent } from "~/newArch/components/Swiper/components/Swiper";
@@ -49,8 +49,7 @@ export const LargeMoverLandingPage = ({ route }: LargeMoverLandingPageProps) =>
4949
const navigation = useNavigation<NavigationProp<WalletTabNavigatorStackParamList>>();
5050

5151
const { colors } = useTheme();
52-
const constHeight = Platform.OS === "ios" ? 0.75 : 0.8;
53-
const height = getWindowDimensions().height * constHeight;
52+
const height = getWindowDimensions().height * 0.78;
5453
const [currentIndex, setCurrentIndex] = useState(0);
5554
const showOverlay = useSelector(tutorialSelector);
5655
const handleSwipe = (newIndex: number) => {
@@ -109,10 +108,10 @@ export const LargeMoverLandingPage = ({ route }: LargeMoverLandingPageProps) =>
109108
return (
110109
<>
111110
{showOverlay && !loading && <OverlayTutorial />}
112-
<SafeAreaView style={{ flex: 1, backgroundColor: colors.neutral.c00, paddingTop: 10 }}>
111+
<SafeAreaView style={{ flex: 1, backgroundColor: colors.neutral.c00, paddingTop: 40 }}>
113112
<TrackScreen name={PAGE_NAME} initialRange={initialRange} currencyIds={currencyIds} />
114113
<StickyHeader />
115-
<Flex paddingTop={40}>
114+
<Flex paddingTop={25}>
116115
{loading && loadingChart ? (
117116
<LoadingIndicator height={height} />
118117
) : (

0 commit comments

Comments
 (0)