Merge pull request #11332 from LedgerHQ/LIVE-20867-ledger-live-wont-load-or-is-extremely-laggy-on-mac-windows

marcotoniut-ledger · marcotoniut-ledger · commit dd2110a42596 · 2025-08-14T10:34:12.000+01:00
LIVE-20867: prevent infinite rendering cycles when purging anonymous notifications (cherry picked from commit cab707b)
diff --git a/.changeset/shy-cats-rush.md b/.changeset/shy-cats-rush.md
@@ -0,0 +1,6 @@
+---
+"ledger-live-desktop": patch
+"@ledgerhq/live-common": patch
+---
+
+Fixes infinite loop for untracked users with (partially) expired braze campaigns
diff --git a/apps/ledger-live-desktop/src/renderer/actions/constants.ts b/apps/ledger-live-desktop/src/renderer/actions/constants.ts
@@ -1,9 +1,11 @@
 // Action types
 
 /** Settings --------- */
+export const PURGE_EXPIRED_ANONYMOUS_USER_NOTIFICATIONS =
+  "settings/purgeExpiredAnonymousUserNotifications";
+export const RESET_HIDDEN_NFT_COLLECTIONS = "settings/resetHiddenNftCollections";
+export const TOGGLE_MARKET_WIDGET = "settings/toggleMarketWidget";
 export const TOGGLE_MEMOTAG_INFO = "settings/toggleShouldDisplayMemoTagInfo";
 export const TOGGLE_MEV = "settings/toggleMEV";
-export const TOGGLE_MARKET_WIDGET = "settings/toggleMarketWidget";
-export const UPDATE_NFT_COLLECTION_STATUS = "settings/updateNftCollectionStatus";
-export const RESET_HIDDEN_NFT_COLLECTIONS = "settings/resetHiddenNftCollections";
 export const UPDATE_ANONYMOUS_USER_NOTIFICATIONS = "settings/updateAnonymousUserNotifications";
+export const UPDATE_NFT_COLLECTION_STATUS = "settings/updateNftCollectionStatus";
diff --git a/apps/ledger-live-desktop/src/renderer/actions/settings.ts b/apps/ledger-live-desktop/src/renderer/actions/settings.ts
@@ -26,6 +26,7 @@ import { useRefreshAccountsOrdering } from "~/renderer/actions/general";
 import { Language, Locale } from "~/config/languages";
 import { Layout } from "LLD/features/Collectibles/types/Layouts";
 import {
+  PURGE_EXPIRED_ANONYMOUS_USER_NOTIFICATIONS,
   RESET_HIDDEN_NFT_COLLECTIONS,
   TOGGLE_MARKET_WIDGET,
   TOGGLE_MEMOTAG_INFO,
@@ -390,7 +391,7 @@ export const setDismissedContentCards = (payload: { id: string; timestamp: numbe
   payload,
 });
 
-export const clearDismissedContentCards = (payload: string[]) => ({
+export const clearDismissedContentCards = (payload: { now: Date }) => ({
   type: "CLEAR_DISMISSED_CONTENT_CARDS",
   payload,
 });
@@ -461,9 +462,15 @@ export const toggleShouldDisplayMemoTagInfo = (payload: boolean) => {
   };
 };
 
+export const purgeExpiredAnonymousUserNotifications = (payload: { now: Date }) => {
+  return {
+    type: PURGE_EXPIRED_ANONYMOUS_USER_NOTIFICATIONS,
+    payload,
+  };
+};
+
 export const updateAnonymousUserNotifications = (payload: {
   notifications: SettingsState["anonymousUserNotifications"];
-  purgeState?: boolean;
 }) => {
   return {
     type: UPDATE_ANONYMOUS_USER_NOTIFICATIONS,
diff --git a/apps/ledger-live-desktop/src/renderer/hooks/useBraze.ts b/apps/ledger-live-desktop/src/renderer/hooks/useBraze.ts
@@ -1,37 +1,36 @@
-import { useEffect, useCallback, useRef } from "react";
 import * as braze from "@braze/web-sdk";
 import { ClassicCard } from "@braze/web-sdk";
+import { generateAnonymousId } from "@ledgerhq/live-common/braze/anonymousUsers";
+import { getEnv } from "@ledgerhq/live-env";
+import { useCallback, useEffect, useRef } from "react";
+import { useDispatch, useSelector } from "react-redux";
 import { getBrazeConfig } from "~/braze-setup";
+import getUser from "~/helpers/user";
 import {
+  ActionContentCard,
   ContentCard as LedgerContentCard,
   LocationContentCard,
-  PortfolioContentCard,
   NotificationContentCard,
   Platform,
-  ActionContentCard,
+  PortfolioContentCard,
 } from "~/types/dynamicContent";
-import { useDispatch, useSelector } from "react-redux";
 import {
   setActionCards,
   setDesktopCards,
   setNotificationsCards,
   setPortfolioCards,
 } from "../actions/dynamicContent";
-import getUser from "~/helpers/user";
-import {
-  developerModeSelector,
-  trackingEnabledSelector,
-  dismissedContentCardsSelector,
-  anonymousBrazeIdSelector,
-  anonymousUserNotificationsSelector,
-} from "../reducers/settings";
 import {
   clearDismissedContentCards,
+  purgeExpiredAnonymousUserNotifications,
   setAnonymousBrazeId,
-  updateAnonymousUserNotifications,
 } from "../actions/settings";
-import { getEnv } from "@ledgerhq/live-env";
-import { getOldCampaignIds, generateAnonymousId } from "@ledgerhq/live-common/braze/anonymousUsers";
+import {
+  anonymousBrazeIdSelector,
+  developerModeSelector,
+  dismissedContentCardsSelector,
+  trackingEnabledSelector,
+} from "../reducers/settings";
 
 const getDesktopCards = (elem: braze.ContentCards) =>
   elem.cards.filter(card => card.extras?.platform === Platform.Desktop);
@@ -53,92 +52,66 @@ export const compareCards = (a: LedgerContentCard, b: LedgerContentCard) => {
 };
 
 export const mapAsActionContentCard = (card: ClassicCard): ActionContentCard => ({
-  id: String(card.id),
-  title: card.extras?.title,
+  created: card.created,
   description: card.extras?.description,
-  location: LocationContentCard.Action,
+  id: String(card.id),
   image: card.extras?.image,
   link: card.extras?.link,
-  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-  created: card.created as Date,
+  location: LocationContentCard.Action,
   mainCta: card.extras?.mainCta,
-  secondaryCta: card.extras?.secondaryCta,
   order: parseInt(card.extras?.order) ? parseInt(card.extras?.order) : undefined,
+  secondaryCta: card.extras?.secondaryCta,
+  title: card.extras?.title,
 });
 
 export const mapAsPortfolioContentCard = (card: ClassicCard): PortfolioContentCard => ({
-  id: String(card.id),
-  title: card.extras?.title,
-  description: card.extras?.description,
+  created: card.created,
   cta: card.extras?.cta,
-  tag: card.extras?.tag,
-  location: LocationContentCard.Portfolio,
+  description: card.extras?.description,
+  id: String(card.id),
   image: card.extras?.image,
-  url: card.extras?.url,
-  path: card.extras?.path,
-  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-  created: card.created as Date,
+  location: LocationContentCard.Portfolio,
   order: parseInt(card.extras?.order) ? parseInt(card.extras?.order) : undefined,
+  path: card.extras?.path,
+  tag: card.extras?.tag,
+  title: card.extras?.title,
+  url: card.extras?.url,
 });
 
 export const mapAsNotificationContentCard = (card: ClassicCard): NotificationContentCard => ({
-  id: String(card.id),
-  title: card.extras?.title,
+  created: card.created,
+  cta: card.extras?.cta,
   description: card.extras?.description,
+  id: String(card.id),
   location: LocationContentCard.NotificationCenter,
-  url: card.extras?.url,
+  order: parseInt(card.extras?.order) ? parseInt(card.extras?.order) : undefined,
   path: card.extras?.path,
-  cta: card.extras?.cta,
-  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-  created: card.created as Date,
+  title: card.extras?.title,
+  url: card.extras?.url,
   viewed: card.viewed,
-  order: parseInt(card.extras?.order) ? parseInt(card.extras?.order) : undefined,
 });
 
+/**
+ * TODO put this effectful logic into a provider instead
+ */
 export async function useBraze() {
   const dispatch = useDispatch();
   const devMode = useSelector(developerModeSelector);
   const contentCardsDissmissed = useSelector(dismissedContentCardsSelector);
-  const anonymousUserNotifications = useSelector(anonymousUserNotificationsSelector);
   const isTrackedUser = useSelector(trackingEnabledSelector);
   const anonymousBrazeId = useRef(useSelector(anonymousBrazeIdSelector));
 
   const initBraze = useCallback(async () => {
     const user = await getUser();
     const brazeConfig = getBrazeConfig();
     const isPlaywright = !!getEnv("PLAYWRIGHT_RUN");
-    dispatch(clearDismissedContentCards(getOldCampaignIds(contentCardsDissmissed)));
 
     if (!anonymousBrazeId.current) {
       anonymousBrazeId.current = generateAnonymousId();
       dispatch(setAnonymousBrazeId(anonymousBrazeId.current));
     }
 
-    /**
-     * If the user is opt-out from analytics, we need to purge expired notifications persisted in the store/offline storage
-     */
-    if (!isTrackedUser) {
-      const expiredAnonymousUserNotifications = getOldCampaignIds(anonymousUserNotifications);
-      if (expiredAnonymousUserNotifications.length) {
-        const validAnonymousUserNotificationsOnly = Object.keys(anonymousUserNotifications).reduce(
-          (validNotifications: Record<string, number>, key: string) => {
-            if (!expiredAnonymousUserNotifications.includes(key)) {
-              validNotifications[key] = anonymousUserNotifications[key];
-            }
-            return validNotifications;
-          },
-          {},
-        );
-        dispatch(
-          updateAnonymousUserNotifications({
-            notifications: validAnonymousUserNotificationsOnly,
-            purgeState: true,
-          }),
-        );
-      }
-    }
-
-    braze.initialize(brazeConfig.apiKey, {
+    const isInitialized = braze.initialize(brazeConfig.apiKey, {
       baseUrl: brazeConfig.endpoint,
       allowUserSuppliedJavascript: true,
       enableHtmlInAppMessages: true,
@@ -147,6 +120,11 @@ export async function useBraze() {
       appVersion: isTrackedUser ? __APP_VERSION__ : undefined,
     });
 
+    if (!isInitialized) {
+      console.warn("Failed to initialize Braze SDK");
+      return;
+    }
+
     // If it's playwright, we don't want to fetch content cards
     if (isPlaywright) {
       return;
@@ -189,16 +167,22 @@ export async function useBraze() {
 
     braze.automaticallyShowInAppMessages();
     braze.openSession();
-  }, [
-    dispatch,
-    devMode,
-    isTrackedUser,
-    contentCardsDissmissed,
-    anonymousBrazeId,
-    anonymousUserNotifications,
-  ]);
+  }, [dispatch, devMode, isTrackedUser, contentCardsDissmissed, anonymousBrazeId]);
 
   useEffect(() => {
     initBraze();
   }, [initBraze]);
+
+  // TODO should there be an interval to periodically purge dismissed cards?
+  useEffect(() => {
+    dispatch(clearDismissedContentCards({ now: new Date() }));
+  }, [dispatch]);
+
+  // TODO should there be an interval to periodically purge old notifications?
+  useEffect(() => {
+    // If the user is opt-out from analytics, we need to purge expired notifications persisted in the store/offline storage
+    if (!isTrackedUser) {
+      dispatch(purgeExpiredAnonymousUserNotifications({ now: new Date() }));
+    }
+  }, [dispatch, isTrackedUser]);
 }
diff --git a/apps/ledger-live-desktop/src/renderer/hooks/useNotifications.ts b/apps/ledger-live-desktop/src/renderer/hooks/useNotifications.ts
@@ -23,6 +23,7 @@ export function useNotifications() {
     setCachedNotifications(cards);
   }, [dispatch, notificationsCards]);
 
+  // TODO use date library
   function startOfDayTime(date: Date): number {
     const startOfDate = new Date(date.getFullYear(), date.getMonth(), date.getDate());
     return startOfDate.getTime();
@@ -37,8 +38,7 @@ export function useNotifications() {
     const notifsByDay: Record<string, NotificationContentCard[]> = notifs.reduce(
       (sum: Record<string, NotificationContentCard[]>, notif: NotificationContentCard) => {
         // group by publication date
-        const k = startOfDayTime(notif.created);
-
+        const k = notif.created ? `${startOfDayTime(notif.created)}` : "no-date";
         return { ...sum, [`${k}`]: [...(sum[k] || []), notif] };
       },
       {},
diff --git a/apps/ledger-live-desktop/src/renderer/reducers/settings.test.ts b/apps/ledger-live-desktop/src/renderer/reducers/settings.test.ts
@@ -2,14 +2,17 @@
  * @jest-environment jsdom
  */
 
+import { getBrazeCampaignCutoff } from "@ledgerhq/live-common/braze/anonymousUsers";
+import { aDeviceInfoBuilder } from "@ledgerhq/live-common/mock/fixtures/aDeviceInfo";
 import { DeviceModelId } from "@ledgerhq/types-devices";
-import {
+import { State } from ".";
+import { purgeExpiredAnonymousUserNotifications } from "../actions/settings";
+import reducer, {
   lastSeenDeviceSelector,
-  INITIAL_STATE as SETTINGS_INITIAL_STATE,
   localeSelector,
+  INITIAL_STATE as SETTINGS_INITIAL_STATE,
+  SettingsState,
 } from "./settings";
-import { State } from ".";
-import { aDeviceInfoBuilder } from "@ledgerhq/live-common/mock/fixtures/aDeviceInfo";
 
 const invalidDeviceModelIds = ["nanoFTS", undefined, "whatever"];
 const validDeviceModelIds: DeviceModelId[] = Object.values(DeviceModelId);
@@ -90,3 +93,79 @@ describe("lastSeenDeviceSelector", () => {
     expect(localeSelector(state)).toEqual("en-US");
   });
 });
+
+describe("action: purgeAnonymousUserNotifications", () => {
+  it("should remove notifications older than cutoff but keep newer ones", () => {
+    const now = new Date();
+    const cutoff = getBrazeCampaignCutoff(now);
+
+    const oldTimestamp = cutoff - 1;
+    const newTimestamp = cutoff + 1;
+
+    const state: SettingsState = {
+      ...SETTINGS_INITIAL_STATE,
+      anonymousUserNotifications: {
+        a: oldTimestamp,
+        b: newTimestamp,
+        LNSUpsell: oldTimestamp,
+      },
+    };
+
+    const newState = reducer(state, purgeExpiredAnonymousUserNotifications({ now }));
+
+    expect(newState.anonymousUserNotifications).toEqual({
+      b: newTimestamp,
+      LNSUpsell: oldTimestamp,
+    });
+  });
+
+  it("should keep all notifications if none are expired", () => {
+    const now = new Date();
+    const ts = now.getTime() - 1000;
+
+    const state: SettingsState = {
+      ...SETTINGS_INITIAL_STATE,
+      anonymousUserNotifications: {
+        a: ts,
+        b: ts,
+        LNSUpsell: ts,
+      },
+    };
+
+    const newState = reducer(state, purgeExpiredAnonymousUserNotifications({ now }));
+
+    expect(newState).toBe(state);
+  });
+
+  it("should keep LNSUpsell even if expired", () => {
+    const now = new Date();
+    const cutoff = getBrazeCampaignCutoff(now);
+    const expired = cutoff - 1;
+
+    const state: SettingsState = {
+      ...SETTINGS_INITIAL_STATE,
+      anonymousUserNotifications: {
+        x: expired,
+        LNSUpsell: expired,
+      },
+    };
+
+    const newState = reducer(state, purgeExpiredAnonymousUserNotifications({ now }));
+
+    expect(newState.anonymousUserNotifications).toEqual({
+      LNSUpsell: expired,
+    });
+  });
+
+  it("should return original state if anonymousUserNotifications is empty", () => {
+    const now = new Date();
+    const state: SettingsState = {
+      ...SETTINGS_INITIAL_STATE,
+      anonymousUserNotifications: {},
+    };
+
+    const newState = reducer(state, purgeExpiredAnonymousUserNotifications({ now }));
+
+    expect(newState).toBe(state);
+  });
+});
diff --git a/apps/ledger-live-desktop/src/renderer/reducers/settings.ts b/apps/ledger-live-desktop/src/renderer/reducers/settings.ts
diff --git a/apps/ledger-live-desktop/src/types/dynamicContent.ts b/apps/ledger-live-desktop/src/types/dynamicContent.ts
diff --git a/libs/ledger-live-common/src/braze/anonymousUsers.ts b/libs/ledger-live-common/src/braze/anonymousUsers.ts
