Skip to content

Commit 558c438

Browse files
committed
feat: add links for CTA
1 parent 68701fc commit 558c438

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

.changeset/sharp-bottles-unite.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"ledger-live-desktop": minor
3+
"live-mobile": minor
4+
---
5+
6+
Add links for CTA

apps/ledger-live-desktop/src/renderer/components/SyncOnboarding/Manual/SeedStep.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import CharonPng from "./assets/charon.png";
1010
import SecretRecoveryPhrasePng from "./assets/secret-recovery-phrase.png";
1111
import { trackPage, useTrack } from "~/renderer/analytics/segment";
1212
import { CharonStatus } from "@ledgerhq/live-common/hw/extractOnboardingState";
13+
import { openURL } from "~/renderer/linking";
1314

1415
export type SeedPathStatus =
1516
| "choice_new_or_restore"
@@ -27,17 +28,19 @@ export type Props = {
2728
charonStatus: CharonStatus | null;
2829
};
2930

31+
const CHARON_LEARN_MORE_URL = "https://shop.ledger.com/products/ledger-recovery-key";
32+
3033
const SeedStep = ({ seedPathStatus, deviceModelId, charonSupported, charonStatus }: Props) => {
3134
const { t } = useTranslation();
3235
const track = useTrack();
3336
const productName = getDeviceModel(deviceModelId).productName;
3437

3538
const handleLearnMoreClick = useCallback(() => {
36-
// TODO: Add link
3739
track("button_clicked", {
3840
button: "Learn More",
3941
page: "Charon Start",
4042
});
43+
openURL(CHARON_LEARN_MORE_URL);
4144
}, [track]);
4245

4346
useEffect(() => {

apps/ledger-live-mobile/src/screens/SyncOnboarding/SyncOnboardingCompanion.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import React, {
77
useRef,
88
useLayoutEffect,
99
} from "react";
10-
import { Image } from "react-native";
10+
import { Image, Linking } from "react-native";
1111
import { Flex, VerticalTimeline, Text, ContinueOnDevice, Link } from "@ledgerhq/native-ui";
1212
import { useSafeAreaInsets } from "react-native-safe-area-context";
1313
import { useOnboardingStatePolling } from "@ledgerhq/live-common/onboarding/hooks/useOnboardingStatePolling";
@@ -125,6 +125,8 @@ const fromSeedPhraseTypeToAnalyticsPropertyString = new Map<SeedPhraseType, stri
125125
[SeedPhraseType.Twelve, "Twelve"],
126126
]);
127127

128+
const CHARON_LEARN_MORE_URL = "https://shop.ledger.com/products/ledger-recovery-key";
129+
128130
// Because of https://github.com/typescript-eslint/typescript-eslint/issues/1197
129131
enum CompanionStepKey {
130132
EarlySecurityCheckCompleted = 0,
@@ -560,11 +562,11 @@ export const SyncOnboardingCompanion: React.FC<SyncOnboardingCompanionProps> = (
560562

561563
const track = useTrack();
562564
const handleLearnMoreClick = useCallback(() => {
563-
// TODO: Add link
564565
track("button_clicked", {
565566
button: "Learn More",
566567
page: "Charon Start",
567568
});
569+
Linking.openURL(CHARON_LEARN_MORE_URL);
568570
}, [track]);
569571

570572
const companionSteps: Step[] = useMemo(

0 commit comments

Comments
 (0)