test: slash invariants (#1083)

**Motivation:**

Improve slashing invariants in integration tests

**Modifications:**

Adds `check_Base_Slashing_State`, and implements several checks used
within

**Result:**

Slashing invariants check all manner of state changes in the ALM and
delegation.

---------

Co-authored-by: Michael <[email protected]>

Author: 2 people

src/test/integration/IntegrationChecks.t.sol

@@ -451,18 +451,6 @@ contract IntegrationCheckUtils is IntegrationBase {
         assert_Snap_Unchanged_AllocatableMagnitude(operator, allStrats, "should not have updated allocatable magnitude");
     }
 
-    // /// @dev Checks invariants for registration for a variety of allocation states
-    // /// 
-    // function check_Registration_State(
-    //     User operator,
-    //     OperatorSet memory operatorSet,
-    //     IStrategy[] memory unallocated,
-    //     AllocateParams memory pending,
-    //     AllocateParams memory active
-    // ) internal {
-    //     check_Base_Registration_State(operator, operatorSet);
-    // }
-
     /// @dev Check invariants for registerForOperatorSets given a set of strategies
     /// for which NO allocation exists (currentMag/pendingDiff are 0)
     /// @param unallocated For the given operatorSet, a list of strategies for which NO allocation exists
@@ -839,6 +827,37 @@ contract IntegrationCheckUtils is IntegrationBase {
         check_ActiveModification_State(operator, deallocateParams); 
     }
 
+    /*******************************************************************************
+                                ALM - SLASHING
+    *******************************************************************************/
+
+    function check_Base_Slashing_State(
+        User operator,
+        AllocateParams memory allocateParams,
+        SlashingParams memory slashParams
+    ) internal {
+        OperatorSet memory operatorSet = allocateParams.operatorSet;
+
+        check_MaxMag_Invariants(operator);
+        check_IsSlashable_State(operator, operatorSet, allocateParams.strategies);
+
+        // Slashing SHOULD change max magnitude and current allocation
+        assert_Snap_Slashed_MaxMagnitude(operator, slashParams, "slash should lower max magnitude");
+        assert_Snap_Slashed_EncumberedMagnitude(operator, slashParams, "slash should lower max magnitude");
+        assert_Snap_Slashed_AllocatedStake(operator, operatorSet, slashParams, "slash should lower allocated stake");
+        assert_Snap_Slashed_SlashableStake(operator, operatorSet, slashParams, "slash should lower slashable stake");
+        assert_Snap_Slashed_OperatorShares(operator, slashParams, "slash should remove operator shares");
+        assert_Snap_Slashed_Allocation(operator, operatorSet, slashParams, "slash should reduce current magnitude");
+        assert_Snap_Increased_BurnableShares(operator, slashParams, "slash should increase burnable shares");
+
+        // Slashing SHOULD NOT change allocatable magnitude, registration, and slashability status
+        assert_Snap_Unchanged_AllocatableMagnitude(operator, allStrats, "slashing should not change allocatable magnitude");
+        assert_Snap_Unchanged_Registration(operator, operatorSet, "slash should not change registration status");
+        assert_Snap_Unchanged_Slashability(operator, operatorSet, "slash should not change slashability status");
+        assert_Snap_Unchanged_AllocatedSets(operator, "should not have updated allocated sets");
+        assert_Snap_Unchanged_AllocatedStrats(operator, operatorSet, "should not have updated allocated strategies");
+    }
+
     // TODO: improvement needed 
 
     /// @dev Run a method as if the user's allocation delay had passed

src/test/integration/tests/SlashingWithdrawals.t.sol

@@ -15,7 +15,6 @@ contract Integration_ALMSlashBase is IntegrationCheckUtils {
     uint[] initTokenBalances;
     uint[] initDepositShares;
 
-
     /// Shared setup:
     /// 
     /// 1. Generate staker, operator, and AVS
@@ -129,6 +128,7 @@ contract Integration_InitSlash is Integration_ALMSlashBase {
 }
 
 contract Integration_SlashingWithdrawals is Integration_ALMSlashBase {
+<<<<<<< HEAD
 
     function testFuzz_slash_undelegate_completeAsTokens(
         uint24 _random
@@ -244,6 +244,8 @@ contract Integration_SlashingWithdrawals is Integration_ALMSlashBase {
         assert_Snap_Allocations_Modified(
             operator, allocateParams, true, "operator allocations should be updated after delay"
         );
+=======
+>>>>>>> b6c49a95 (test: slash invariants (#1083))
 
     function testFuzz_slash_undelegate_completeAsTokens(
         uint24 _random