Skip to content

Commit 1512167

Browse files
fix: readd manual checks (#996)
* fix: readd manual checks * chore: forge fmt
1 parent 10fb40f commit 1512167

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

src/contracts/core/RewardsCoordinator.sol

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ contract RewardsCoordinator is
371371
*/
372372
function _setOperatorSplit(OperatorSplit storage operatorSplit, uint16 split, uint32 activatedAt) internal {
373373
require(split <= ONE_HUNDRED_IN_BIPS, SplitExceedsMax());
374-
374+
375375
require(block.timestamp > operatorSplit.activatedAt, PreviousSplitPending());
376376

377377
if (operatorSplit.activatedAt == 0) {
@@ -555,20 +555,20 @@ contract RewardsCoordinator is
555555
* @param operatorSplit The split struct for an Operator
556556
* @return The split in basis points.
557557
*/
558-
function _getOperatorSplit(OperatorSplit memory operatorSplit) internal view returns (uint16) {
558+
function _getOperatorSplit(
559+
OperatorSplit memory operatorSplit
560+
) internal view returns (uint16) {
559561
if (
560-
(operatorSplit.activatedAt == 0) ||
561-
(operatorSplit.oldSplitBips == type(uint16).max && block.timestamp < operatorSplit.activatedAt)
562+
(operatorSplit.activatedAt == 0)
563+
|| (operatorSplit.oldSplitBips == type(uint16).max && block.timestamp < operatorSplit.activatedAt)
562564
) {
563565
// Return the Default Operator Split if the operator split has not been initialized.
564566
// Also return the Default Operator Split if the operator split has been initialized but not activated yet. (i.e the first initialization)
565567
return defaultOperatorSplitBips;
566568
} else {
567569
// Return the new split if the new split has been activated, else return the old split.
568570
return
569-
(block.timestamp >= operatorSplit.activatedAt)
570-
? operatorSplit.newSplitBips
571-
: operatorSplit.oldSplitBips;
571+
(block.timestamp >= operatorSplit.activatedAt) ? operatorSplit.newSplitBips : operatorSplit.oldSplitBips;
572572
}
573573
}
574574

src/test/unit/AVSDirectoryUnit.t.sol

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ contract AVSDirectoryUnitTests is EigenLayerUnitTestSetup, IAVSDirectoryEvents,
5050
)
5151
);
5252
isExcludedFuzzAddress[address(avsd)] = true;
53+
54+
assertTrue(avsd.domainSeparator() != bytes32(0), "sanity check");
5355
}
5456

5557
function _newOperatorRegistrationSignature(

src/test/unit/DelegationUnit.t.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,6 +1335,7 @@ contract DelegationManagerUnitTests is EigenLayerUnitTestSetup, IDelegationManag
13351335

13361336
contract DelegationManagerUnitTests_Initialization_Setters is DelegationManagerUnitTests {
13371337
function test_initialization() public view {
1338+
assertTrue(delegationManager.domainSeparator() != bytes32(0), "sanity check");
13381339
assertEq(
13391340
address(delegationManager.strategyManager()),
13401341
address(strategyManagerMock),

src/test/unit/StrategyManagerUnit.t.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ contract StrategyManagerUnitTests_initialize is StrategyManagerUnitTests {
251251
}
252252

253253
function test_InitializedStorageProperly() public view {
254+
assertTrue(strategyManager.domainSeparator() != bytes32(0), "sanity check");
254255
assertEq(strategyManager.owner(), initialOwner, "strategyManager.owner() != initialOwner");
255256
assertEq(
256257
strategyManager.strategyWhitelister(),

0 commit comments

Comments
 (0)