Skip to content

Commit b6b545d

Browse files
authored
chore: Fix old 'blob certified' terminology to be 'blob complete' (#1462)
Signed-off-by: litt3 <[email protected]>
1 parent 36aae2c commit b6b545d

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

api/clients/v2/payloaddispersal/payload_disperser.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ func (pd *PayloadDisperser) SendPayload(
108108

109109
probe.SetStage("QUEUED")
110110

111-
timeoutCtx, cancel = context.WithTimeout(ctx, pd.config.BlobCertifiedTimeout)
111+
timeoutCtx, cancel = context.WithTimeout(ctx, pd.config.BlobCompleteTimeout)
112112
defer cancel()
113-
blobStatusReply, err := pd.pollBlobStatusUntilCertified(timeoutCtx, blobKey, blobStatus.ToProfobuf(), probe)
113+
blobStatusReply, err := pd.pollBlobStatusUntilComplete(timeoutCtx, blobKey, blobStatus.ToProfobuf(), probe)
114114
if err != nil {
115-
return nil, fmt.Errorf("poll blob status until certified: %w", err)
115+
return nil, fmt.Errorf("poll blob status until complete: %w", err)
116116
}
117-
pd.logger.Debug("Blob status CERTIFIED", "blobKey", blobKey.Hex())
117+
pd.logger.Debug("Blob status COMPLETE", "blobKey", blobKey.Hex())
118118

119119
probe.SetStage("build_cert")
120120

@@ -152,11 +152,11 @@ func (pd *PayloadDisperser) Close() error {
152152
return nil
153153
}
154154

155-
// pollBlobStatusUntilCertified polls the disperser for the status of a blob that has been dispersed
155+
// pollBlobStatusUntilComplete polls the disperser for the status of a blob that has been dispersed
156156
//
157-
// This method will only return a non-nil BlobStatusReply if the blob is reported to be CERTIFIED prior to the timeout.
157+
// This method will only return a non-nil BlobStatusReply if the blob is reported to be COMPLETE prior to the timeout.
158158
// In all other cases, this method will return a nil BlobStatusReply, along with an error describing the failure.
159-
func (pd *PayloadDisperser) pollBlobStatusUntilCertified(
159+
func (pd *PayloadDisperser) pollBlobStatusUntilComplete(
160160
ctx context.Context,
161161
blobKey core.BlobKey,
162162
initialStatus dispgrpc.BlobStatus,

api/clients/v2/payloaddispersal/payload_disperser_config.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ type PayloadDisperserConfig struct {
1515
// blob
1616
DisperseBlobTimeout time.Duration
1717

18-
// BlobCertifiedTimeout is the duration after which the PayloadDisperser will time out, while polling
19-
// the disperser for blob status, waiting for BlobStatus_CERTIFIED
20-
BlobCertifiedTimeout time.Duration
18+
// BlobCompleteTimeout is the duration after which the PayloadDisperser will time out, while polling
19+
// the disperser for blob status, waiting for BlobStatus_COMPLETE
20+
BlobCompleteTimeout time.Duration
2121

2222
// BlobStatusPollInterval is the tick rate for the PayloadDisperser to use, while polling the disperser with
2323
// GetBlobStatus.
@@ -32,7 +32,7 @@ func getDefaultPayloadDisperserConfig() *PayloadDisperserConfig {
3232
return &PayloadDisperserConfig{
3333
PayloadClientConfig: *clients.GetDefaultPayloadClientConfig(),
3434
DisperseBlobTimeout: 2 * time.Minute,
35-
BlobCertifiedTimeout: 2 * time.Minute,
35+
BlobCompleteTimeout: 2 * time.Minute,
3636
BlobStatusPollInterval: 1 * time.Second,
3737
ContractCallTimeout: 5 * time.Second,
3838
}
@@ -47,8 +47,8 @@ func (dc *PayloadDisperserConfig) checkAndSetDefaults() error {
4747
dc.DisperseBlobTimeout = defaultConfig.DisperseBlobTimeout
4848
}
4949

50-
if dc.BlobCertifiedTimeout == 0 {
51-
dc.BlobCertifiedTimeout = defaultConfig.BlobCertifiedTimeout
50+
if dc.BlobCompleteTimeout == 0 {
51+
dc.BlobCompleteTimeout = defaultConfig.BlobCompleteTimeout
5252
}
5353

5454
if dc.BlobStatusPollInterval == 0 {

test/v2/client/test_client.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,9 @@ func NewTestClient(
163163
payloadClientConfig := clients.GetDefaultPayloadClientConfig()
164164

165165
payloadDisperserConfig := payloaddispersal.PayloadDisperserConfig{
166-
PayloadClientConfig: *payloadClientConfig,
167-
DisperseBlobTimeout: 1337 * time.Hour, // this suite enforces its own timeouts
168-
BlobCertifiedTimeout: 1337 * time.Hour, // this suite enforces its own timeouts
166+
PayloadClientConfig: *payloadClientConfig,
167+
DisperseBlobTimeout: 1337 * time.Hour, // this suite enforces its own timeouts
168+
BlobCompleteTimeout: 1337 * time.Hour, // this suite enforces its own timeouts
169169
}
170170
payloadDisperser, err := payloaddispersal.NewPayloadDisperser(
171171
logger,

0 commit comments

Comments
 (0)