Merge branch 'master' into feat/access-control

Author: pakim249CAL

.github/workflows/live-network-tests.yaml

@@ -46,7 +46,7 @@ jobs:
 
           PAYLOAD=$(jq -n \
             --arg channel "#da-live-tests" \
-            --arg text "${MENTION}Live Network Tests completed, status: ${STATUS_EMOJI} ${{ job.status }}" \
+            --arg text "${MENTION}Live V2 Network Tests completed, status: ${STATUS_EMOJI} ${{ job.status }}" \
             --arg title "logs" \
             --arg title_link "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
             --arg color "$COLOR" \
@@ -101,7 +101,7 @@ jobs:
 
           PAYLOAD=$(jq -n \
             --arg channel "#da-live-tests" \
-            --arg text "${MENTION}Live Network Tests completed, status: ${STATUS_EMOJI} ${{ job.status }}" \
+            --arg text "${MENTION}Live V1 Network Tests completed, status: ${STATUS_EMOJI} ${{ job.status }}" \
             --arg title "logs" \
             --arg title_link "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
             --arg color "$COLOR" \

api/clients/eigenda_client_e2e_live_test.go

@@ -41,6 +41,7 @@ func TestClientUsingTestnet(t *testing.T) {
 
 	t.Run("PutBlobWaitForConfirmationDepth0AndGetBlob", func(t *testing.T) {
 		t.Parallel()
+		confDepth := uint64(0)
 
 		client, err := NewEigenDAClient(testutils.GetLogger(), EigenDAClientConfig{
 			RPC: testRPC,
@@ -52,7 +53,7 @@ func TestClientUsingTestnet(t *testing.T) {
 			CustomQuorumIDs:          []uint{},
 			SignerPrivateKeyHex:      testSignerPrivateKeyHex,
 			WaitForFinalization:      false,
-			WaitForConfirmationDepth: 0,
+			WaitForConfirmationDepth: confDepth,
 			SvcManagerAddr:           testSvcManagerAddr,
 			EthRpcUrl:                testEthRpcUrl,
 		})
@@ -73,18 +74,18 @@ func TestClientUsingTestnet(t *testing.T) {
 		confDepth := uint64(3)
 
 		client, err := NewEigenDAClient(testutils.GetLogger(), EigenDAClientConfig{
-			RPC: "disperser-holesky.eigenda.xyz:443",
+			RPC: testRPC,
 			// Should need way less than 20 minutes, but we set it to 20 minutes to be safe
 			// In worst case we had 10 min batching interval + some time for the tx to land onchain,
 			// plus wait for 3 blocks of confirmation.
-			StatusQueryTimeout:       20 * time.Minute,
-			StatusQueryRetryInterval: 5 * time.Second,
+			StatusQueryTimeout:       testStatusQueryTimeout,
+			StatusQueryRetryInterval: testStatusQueryRetryInterval,
 			CustomQuorumIDs:          []uint{},
-			SignerPrivateKeyHex:      "2d23e142a9e86a9175b9dfa213f20ea01f6c1731e09fa6edf895f70fe279cbb1",
+			SignerPrivateKeyHex:      testSignerPrivateKeyHex,
 			WaitForFinalization:      false,
 			WaitForConfirmationDepth: confDepth,
-			SvcManagerAddr:           "0xD4A7E1Bd8015057293f0D0A557088c286942e84b",
-			EthRpcUrl:                "https://1rpc.io/holesky",
+			SvcManagerAddr:           testSvcManagerAddr,
+			EthRpcUrl:                testEthRpcUrl,
 		})
 		data := "hello world!"
 		assert.NoError(t, err)

contracts/src/integrations/cert/router/EigenDACertVerifierRouter.sol

@@ -35,12 +35,19 @@ contract EigenDACertVerifierRouter is IEigenDACertVerifierRouter, OwnableUpgrade
 
     /// ADMIN ///
 
+    /// For a fully secure integration, the owner of this contract should be a timelocked contract.
     function initialize(address _initialOwner, address certVerifier) external initializer {
         _transferOwnership(_initialOwner);
         // Add a default cert verifier at block 0, which will be used for all blocks before the first ABN.
         _addCertVerifier(0, certVerifier);
     }
 
+    /// @notice Adds a cert verifier to the router.
+    /// @param activationBlockNumber The block number at which the cert verifier will be activated.
+    /// @param certVerifier The address of the cert verifier to be added.
+    /// Note: for a fully secure integration, the owner of this contract should be a timelocked contract,
+    /// such that new certs can only be activated after a certain period of time. When submitting this transaction,
+    /// make sure that the activationBlockNumber is greater than the timelock period by some margin.
     function addCertVerifier(uint32 activationBlockNumber, address certVerifier) external onlyOwner {
         // We disallow adding cert verifiers at the current block number to avoid a race condition of
         // adding a cert verifier at the current block and verifying in the same block