Skip to content

Commit a355a61

Browse files
committed
skip iterating over method nodes, if search fields are empty
1 parent a626bc4 commit a355a61

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/MethodCallSearch.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ public JPanel getPanel()
9191
@Override
9292
public void search(ResourceContainer container, String resourceWorkingName, ClassNode node, boolean exact)
9393
{
94-
final Iterator<MethodNode> methods = node.methods.iterator();
95-
9694
String searchOwner = mOwner.getText();
9795
if (searchOwner.isEmpty())
9896
searchOwner = null;
@@ -105,6 +103,11 @@ public void search(ResourceContainer container, String resourceWorkingName, Clas
105103
if (searchDesc.isEmpty())
106104
searchDesc = null;
107105

106+
if (searchName == null && searchOwner == null && searchDesc == null)
107+
return;
108+
109+
final Iterator<MethodNode> methods = node.methods.iterator();
110+
108111
while (methods.hasNext())
109112
{
110113
final MethodNode method = methods.next();
@@ -116,9 +119,6 @@ public void search(ResourceContainer container, String resourceWorkingName, Clas
116119
{
117120
final MethodInsnNode min = (MethodInsnNode) insnNode;
118121

119-
if (searchName == null && searchOwner == null && searchDesc == null)
120-
continue;
121-
122122
if (exact)
123123
{
124124
if (searchName != null && !searchName.equals(min.name))

0 commit comments

Comments
 (0)