Skip to content

Commit a5c8e0f

Browse files
refactor(*) fix tests, linting, powershell artifacts, ci (#134)
* feat(powershell) add powershell files - add test fixtures - add to available targets * fix(reducer): reduce multidimensional query strings correctly (#93) * fix(headers) reduce normal using Object.assign * fix(node) remove extra whitespace in node fixtures * fix(node) switch from util.inspect to stringify-object module - Consistent formatting across Node versions - Fixes cross-node-version tests * chore(lint) fixes - Deprecate utils functions (util._extend -> Object.assign). - Invoke assertion `should` methods. - Remove unnecessary escape chars. * chore(travis) use later versions of node * chore(test) disable posttest run for now * style(spelling) fix misspelled attachment - when we switched from util._extend to Object.assign, the ordering of the headers seemed to be affected, which means we can switch back to a normal `reduce` instead of `reduceRight` * test(requests) disable deep equal for https - Mockbin returns http url even when request is for https url * test(targets) build in skip mechanism for failures * test(headers) fix headers consistencies w/fixtures * test(go) fix header order, human readable Fixes #125, #124 From #93
1 parent 4c0c5ea commit a5c8e0f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+3073
-250
lines changed

.travis.yml

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,13 @@
11
language: node_js
22

33
node_js:
4-
- iojs
5-
- 0.10
6-
- 0.12
4+
- node
5+
- lts/*
6+
- 8
77

88
before_install:
99
- sudo apt-get update -qq
1010
- sudo apt-get install -qq --yes python3 php5-curl php5-cli
1111

1212
after_script:
1313
- npm run codeclimate
14-
15-
notifications:
16-
webhooks:
17-
urls:
18-
- https://webhooks.gitter.im/e/95c4e911f2486588f98c
19-
on_success: always
20-
on_failure: always
21-
on_start: false

CONTRIBUTING.md

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ Good bug reports are extremely helpful - thank you!
2828
Guidelines for bug reports:
2929

3030
1. **Use the GitHub issue search** — check if the issue has already been
31-
reported.
31+
reported.
3232

3333
2. **Check if the issue has been fixed** — try to reproduce it using the
34-
latest `master` or development branch in the repository.
34+
latest `master` or development branch in the repository.
3535

3636
3. **Isolate the problem** — create a [reduced test
37-
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
37+
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
3838

3939
A good bug report shouldn't leave others needing to chase you up for more
4040
information. Please try to be as detailed as possible in your report. What is
@@ -85,48 +85,48 @@ Follow this process if you'd like your work considered for inclusion in the
8585
project:
8686

8787
1. [Fork](http://help.github.com/fork-a-repo/) the project, clone your fork,
88-
and configure the remotes:
88+
and configure the remotes:
8989

90-
```bash
91-
# Clone your fork of the repo into the current directory
92-
git clone https://github.com/<your-username>/<repo-name>
93-
# Navigate to the newly cloned directory
94-
cd <repo-name>
95-
# Assign the original repo to a remote called "upstream"
96-
git remote add upstream https://github.com/Mashape/httpsnippet.git
97-
```
90+
```bash
91+
# Clone your fork of the repo into the current directory
92+
git clone https://github.com/<your-username>/<repo-name>
93+
# Navigate to the newly cloned directory
94+
cd <repo-name>
95+
# Assign the original repo to a remote called "upstream"
96+
git remote add upstream https://github.com/Mashape/httpsnippet.git
97+
```
9898

9999
2. If you cloned a while ago, get the latest changes from upstream:
100100

101-
```bash
102-
git checkout <dev-branch>
103-
git pull upstream <dev-branch>
104-
```
101+
```bash
102+
git checkout <dev-branch>
103+
git pull upstream <dev-branch>
104+
```
105105

106106
3. Create a new topic branch (off the main project development branch) to
107-
contain your feature, change, or fix:
107+
contain your feature, change, or fix:
108108

109-
```bash
110-
git checkout -b <topic-branch-name>
111-
```
109+
```bash
110+
git checkout -b <topic-branch-name>
111+
```
112112

113113
4. Commit your changes in logical chunks. Please adhere to these [git commit
114-
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
115-
or your code is unlikely be merged into the main project. Use Git's
116-
[interactive rebase](https://help.github.com/articles/interactive-rebase)
117-
feature to tidy up your commits before making them public.
114+
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
115+
or your code is unlikely be merged into the main project. Use Git's
116+
[interactive rebase](https://help.github.com/articles/interactive-rebase)
117+
feature to tidy up your commits before making them public.
118118
119119
5. Locally merge (or rebase) the upstream development branch into your topic branch:
120120
121-
```bash
122-
git pull [--rebase] upstream <dev-branch>
123-
```
121+
```bash
122+
git pull [--rebase] upstream <dev-branch>
123+
```
124124
125125
6. Push your topic branch up to your fork:
126126
127-
```bash
128-
git push origin <topic-branch-name>
129-
```
127+
```bash
128+
git push origin <topic-branch-name>
129+
```
130130
131131
7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
132132
with a clear title and description.

0 commit comments

Comments
 (0)