Skip to content

Commit a926291

Browse files
artem-lunargspencer-lunarg
authored andcommitted
sync: Disable resource reporting due to stale index issue
#8291 This can be related to command buffer lifetime management. Usage records can reference handles from the command buffers that were Reset.
1 parent 298836f commit a926291

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

layers/sync/sync_commandbuffer.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1199,11 +1199,17 @@ std::ostream &operator<<(std::ostream &out, const ResourceUsageRecord::Formatter
11991199
out << ", reset_no: " << std::to_string(record.reset_count);
12001200

12011201
// Associated resource
1202+
// TODO: Fix issue in submit-time validation resource reporting.
1203+
// Some cases of false-positives lead to stale resource indices.
1204+
// https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8291
1205+
// This can be related to command buffer Reset.
1206+
/*
12021207
if (formatter.handle_index != vvl::kNoIndex32) {
12031208
auto cb_context = static_cast<const syncval_state::CommandBuffer *>(record.cb_state);
12041209
const HandleRecord &handle_record = cb_context->access_context.GetHandleRecord(formatter.handle_index);
12051210
out << ", resource: " << handle_record.Formatter(formatter.sync_state);
12061211
}
1212+
*/
12071213
// Report debug region name. Empty name means that we are not inside any debug region.
12081214
if (formatter.debug_name_provider) {
12091215
const std::string debug_region_name = formatter.debug_name_provider->GetDebugRegionName(record);

tests/unit/sync_val.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6222,7 +6222,7 @@ TEST_F(NegativeSyncVal, RenderPassStoreOpNone) {
62226222
m_commandBuffer->end();
62236223
}
62246224

6225-
TEST_F(NegativeSyncVal, DebugResourceName) {
6225+
TEST_F(NegativeSyncVal, DISABLED_DebugResourceName) {
62266226
TEST_DESCRIPTION("Test that hazardous buffer is reported. Two copies write to a buffer");
62276227
AddRequiredExtensions(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
62286228
RETURN_IF_SKIP(InitSyncVal());
@@ -6251,7 +6251,7 @@ TEST_F(NegativeSyncVal, DebugResourceName) {
62516251
m_default_queue->Wait();
62526252
}
62536253

6254-
TEST_F(NegativeSyncVal, DebugDescriptorBufferName) {
6254+
TEST_F(NegativeSyncVal, DISABLED_DebugDescriptorBufferName) {
62556255
TEST_DESCRIPTION("Test that hazardous buffer is reported. Two dispatches write to a buffer");
62566256
AddRequiredExtensions(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
62576257
RETURN_IF_SKIP(InitSyncVal());
@@ -6309,7 +6309,7 @@ TEST_F(NegativeSyncVal, DebugDescriptorBufferName) {
63096309
m_default_queue->Wait();
63106310
}
63116311

6312-
TEST_F(NegativeSyncVal, DebugDescriptorBufferName2) {
6312+
TEST_F(NegativeSyncVal, DISABLED_DebugDescriptorBufferName2) {
63136313
TEST_DESCRIPTION("Test that hazardous buffer is reported. Dispatch writes to a buffer, then copy to the same buffer");
63146314
AddRequiredExtensions(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
63156315
RETURN_IF_SKIP(InitSyncVal());
@@ -6369,7 +6369,7 @@ TEST_F(NegativeSyncVal, DebugDescriptorBufferName2) {
63696369
m_default_queue->Wait();
63706370
}
63716371

6372-
TEST_F(NegativeSyncVal, DebugDescriptorBufferName3) {
6372+
TEST_F(NegativeSyncVal, DISABLED_DebugDescriptorBufferName3) {
63736373
TEST_DESCRIPTION("Different buffer of the same shader is reported depending on the previous access");
63746374
AddRequiredExtensions(VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
63756375
RETURN_IF_SKIP(InitSyncVal());

0 commit comments

Comments
 (0)