Merge pull request #44 from JupiterOne/INT-11348-duplicated-vuln-key

Corrected vuln step to avoid duplicated relationships to be created

Author: Gonzalo-Avalos-Ribas

src/steps/ms-defender/client.ts

@@ -3,7 +3,7 @@ import { GraphClient, GraphClientResponse } from '../../ms-graph/client';
 import { IntegrationLogger } from '@jupiterone/integration-sdk-core';
 import { ClientConfig } from '../../ms-graph/types';
 
-const ITEMS_PER_PAGE = 500;
+const ITEMS_PER_PAGE = 750;
 export class DefenderClient extends GraphClient {
   constructor(logger: IntegrationLogger, config: ClientConfig) {
     super(logger, { ...config, isDefenderApi: true });

src/steps/ms-defender/vulnerabilities/index.ts

@@ -17,7 +17,6 @@ import {
   createVulnerabilityCveRelationship,
   createVulnerabilityEntity,
   createMachineVulnerabilityRelationship,
-  createVulnerabilityKey,
 } from './converters';
 
 export async function fetchFindings({
@@ -44,10 +43,9 @@ export async function fetchFindings({
         async (finding) => {
           const findingEntity = createVulnerabilityEntity(finding);
 
-          if (!jobState.hasKey(createVulnerabilityKey(finding.id))) {
-            await jobState.addEntity(findingEntity);
-          }
+          if (jobState.hasKey(findingEntity._key)) return;
 
+          await jobState.addEntity(findingEntity);
           await jobState.addRelationship(
             createMachineVulnerabilityRelationship({
               machineEntity,