Fix #321767: Delete/rename/move/clarify the "Open" column of "String Data"

and some fixes for translatable texts as well as a minor and
non-consequential typo and code style issue

Author: Jojo-Schmitz

mscore/editstringdata.cpp

@@ -37,7 +37,7 @@ EditStringData::EditStringData(QWidget *parent, QList<instrString> * strings, in
       _strings = strings;
       QStringList hdrLabels;
       int         numOfStrings = _strings->size();
-      hdrLabels << tr("Open", "string data") << tr("Pitch", "string data");
+      hdrLabels << tr("Unfingered", "string data") << tr("Pitch", "string data");
       stringList->setHorizontalHeaderLabels(hdrLabels);
       stringList->setRowCount(numOfStrings);
       // if any string, insert into string list control and select the first one

mscore/editstringdata.ui

@@ -27,20 +27,17 @@
       <layout class="QHBoxLayout" name="horizontalLayout_2" stretch="0,0">
        <item>
         <widget class="QTableWidget" name="stringList">
-         <attribute name="horizontalHeaderDefaultSectionSize">
-          <number>50</number>
-         </attribute>
          <attribute name="horizontalHeaderStretchLastSection">
           <bool>true</bool>
          </attribute>
          <column>
           <property name="text">
-           <string>Open</string>
+           <string notr="true">Unfingered</string>
           </property>
          </column>
          <column>
           <property name="text">
-           <string>Pitch</string>
+           <string notr="true">Pitch</string>
           </property>
          </column>
         </widget>

mscore/editstyle.ui

@@ -6565,7 +6565,7 @@ By default, they will be placed such as that their right end are at the same lev
            <item row="3" column="0" colspan="3">
             <widget class="QCheckBox" name="arpeggioHiddenInStdIfTab">
              <property name="text">
-              <string>Do not show arpeggio in standard notation when displayed in tablature</string>
+              <string>Do not show arpeggios in standard notation when displayed in tablature</string>
              </property>
             </widget>
            </item>

mscore/updatechecker.cpp

@@ -34,8 +34,8 @@ namespace Ms {
 
 static int defaultPeriod()
       {
-      int result = 24;
-      if(qApp->applicationName() == "MuseScore2"){ //avoid nightly cymbals
+      int result = 24; // hours
+      if (qApp->applicationName() == "MuseScore3") { //avoid nightly cymbals
             if (MuseScore::unstable())
                   result = 24;
             else

share/instruments/instruments.xml

@@ -6213,7 +6213,7 @@
             <Instrument id="bass-drum">
                   <family>drums</family>
                   <longName>Concert Bass Drum</longName>
-                  <shortName>Con. BD</shortName>
+                  <shortName>Con. B.D.</shortName>
                   <description>Bass Drum</description>
                   <musicXMLid>drum.bass-drum</musicXMLid>
                   <clef>PERC</clef>

share/instruments/instrumentsxml.h

@@ -926,7 +926,7 @@ QT_TRANSLATE_NOOP3("InstrumentsXML", "D. Set", "Drumset"),
 QT_TRANSLATE_NOOP("InstrumentsXML", "Concert Snare Drum"),
 QT_TRANSLATE_NOOP3("InstrumentsXML", "Con. Sn.", "Concert Snare Drum"),
 QT_TRANSLATE_NOOP("InstrumentsXML", "Concert Bass Drum"),
-QT_TRANSLATE_NOOP3("InstrumentsXML", "Con. BD", "Concert Bass Drum"),
+QT_TRANSLATE_NOOP3("InstrumentsXML", "Con. B.D.", "Concert Bass Drum"),
 QT_TRANSLATE_NOOP("InstrumentsXML", "Piccolo Snare"),
 QT_TRANSLATE_NOOP3("InstrumentsXML", "Picc. Sn.", "Piccolo Snare"),
 QT_TRANSLATE_NOOP("InstrumentsXML", "Field Drum"),