fix: update web API blink endpoints to use new LightController fluent API

The blink endpoints were failing because they were using the old Effects API
pattern instead of the new controller's simplified blink method.

Changes:
- Use controller.by_index(light_id).blink() for single light blink
- Use controller.all().blink() for all lights blink
- Convert Speed enum to string with speed.name.lower()
- Pass RGB tuple directly to blink method

Fixed endpoints:
- GET /light/{light_id}/blink
- GET /lights/blink

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: JnyJny

src/busylight/api/busylight_api.py

@@ -3,7 +3,7 @@
 from json import loads as json_loads
 from os import environ
 from secrets import compare_digest
-from typing import Any, Callable, Dict, List
+from typing import Any, Callable
 
 from busylight_core import Light, LightUnavailableError, NoLightsFoundError
 from fastapi import Depends, FastAPI, HTTPException, Path, Request, status
@@ -82,10 +82,10 @@ def __init__(self):
             dependencies=dependencies,
         )
         self.controller = LightController()
-        self.endpoints: List[str] = []
+        self.endpoints: list[str] = []
 
     @property
-    def lights(self) -> List[Light]:
+    def lights(self) -> list[Light]:
         """Get all lights for compatibility."""
         return self.controller.lights
 
@@ -219,11 +219,11 @@ async def light_manager_update(request: Request, call_next):
 
 ## GET API Routes
 ##
-@busylightapi.get("/", response_model=List[EndPoint])
-async def available_endpoints() -> List[Dict[str, str]]:
+@busylightapi.get("/", response_model=list[EndPoint])
+async def available_endpoints() -> list[dict[str, str]]:
     """API endpoint listing.
 
-    List of valid endpoints recognized by this API.
+    list of valid endpoints recognized by this API.
     """
     return [{"path": endpoint} for endpoint in busylightapi.endpoints]
 
@@ -238,37 +238,56 @@ async def available_endpoints() -> List[Dict[str, str]]:
 )
 async def light_status(
     light_id: int = Path(..., title="Numeric light identifier", ge=0),
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Information about the light selected by `light_id`."""
     light = busylightapi.lights[light_id]
+
     return {
         "light_id": light_id,
         "name": light.name,
-        "info": light.hardware,
-        "is_on": light.is_on,
+        "info": {
+            "path": light.hardware.path,
+            "vendor_id": light.hardware.vendor_id,
+            "product_id": light.hardware.product_id,
+            "serial_number": light.hardware.serial_number,
+            "manufacturer_string": light.hardware.manufacturer_string,
+            "product_string": light.hardware.product_string,
+            "release_number": light.hardware.release_number,
+            "is_acquired": light.hardware.is_acquired,
+        },
+        "is_on": light.is_lit,
         "color": colortuple_to_name(light.color),
         "rgb": light.color,
     }
 
 
 @busylightapi.get(
     "/lights/status",
-    response_model=List[LightDescription],
+    response_model=list[LightDescription],
 )
 @busylightapi.get(
     "/lights",
-    response_model=List[LightDescription],
+    response_model=list[LightDescription],
 )
-async def lights_status() -> List[Dict[str, Any]]:
+async def lights_status() -> list[dict[str, Any]]:
     """Information about all available lights."""
     result = []
     for light_id, light in enumerate(busylightapi.lights):
         result.append(
             {
                 "light_id": light_id,
                 "name": light.name,
-                "info": light.hardware,
-                "is_on": light.is_on,
+                "info": {
+                    "path": light.hardware.path,
+                    "vendor_id": light.hardware.vendor_id,
+                    "product_id": light.hardware.product_id,
+                    "serial_number": light.hardware.serial_number,
+                    "manufacturer_string": light.hardware.manufacturer_string,
+                    "product_string": light.hardware.product_string,
+                    "release_number": light.hardware.release_number,
+                    "is_acquired": light.hardware.is_acquired,
+                },
+                "is_on": light.is_lit,
                 "color": colortuple_to_name(light.color),
                 "rgb": light.color,
             },
@@ -284,7 +303,7 @@ async def light_on(
     light_id: int = Path(..., title="Numeric light identifier", ge=0),
     color: str = "green",
     dim: float = 1.0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Turn on the specified light with the given `color`.
 
     `light_id` is an integer value identifying a light and ranges
@@ -313,7 +332,7 @@ async def light_on(
 async def lights_on(
     color: str = "green",
     dim: float = 1.0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Turn on all lights with the given `color`.
 
     `color` can be a color name or a hexadecimal string e.g. "red",
@@ -338,7 +357,7 @@ async def lights_on(
 )
 async def light_off(
     light_id: int = Path(..., title="Numeric light identifier", ge=0),
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Turn off the specified light.
     `light_id` is an integer value identifying a light and ranges
     between zero and number_of_lights-1.
@@ -358,7 +377,7 @@ async def light_off(
     "/lights/off",
     response_model=LightOperation,
 )
-async def lights_off() -> Dict[str, Any]:
+async def lights_off() -> dict[str, Any]:
     """Turn off all lights."""
     await busylightapi.off()
 
@@ -378,7 +397,7 @@ async def blink_light(
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
     count: int = 0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Start blinking the specified light: color and off.
 
     `light_id` is an integer value identifying a light and ranges
@@ -391,9 +410,9 @@ async def blink_light(
     """
     rgb = parse_color_string(color, dim)
 
-    effect = Effects.for_name("blink")(rgb, speed.duty_cycle, count=count)
-
-    await busylightapi.apply_effect(effect, light_id)
+    # Use controller's fluent API
+    selection = busylightapi.controller.by_index(light_id)
+    selection.blink(rgb, count=count, speed=speed.name.lower())
 
     return {
         "action": "blink",
@@ -415,20 +434,20 @@ async def blink_lights(
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
     count: int = 0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Start blinking all the lights: red and off
     <p>Note: lights will not be synchronized.</p>
     """
     rgb = parse_color_string(color, dim)
 
-    blink = Effects.for_name("blink")(rgb, speed.duty_cycle, count=count)
-
-    await busylightapi.apply_effect(blink)
+    # Use controller's fluent API
+    selection = busylightapi.controller.all()
+    selection.blink(rgb, count=count, speed=speed.name.lower())
 
     return {
         "action": "blink",
         "light_id": "all",
-        "color": "red",
+        "color": color,
         "rgb": rgb,
         "speed": speed,
         "dim": dim,
@@ -444,7 +463,7 @@ async def rainbow_light(
     light_id: int = Path(..., title="Numeric light identifier", ge=0),
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Start a rainbow animation on the specified light.
 
     `light_id` is an integer value identifying a light and ranges
@@ -470,7 +489,7 @@ async def rainbow_light(
 async def rainbow_lights(
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Start a rainbow animation on all lights.
     <p><em>Note:</em> lights will not be synchronized.</p>
     """
@@ -497,7 +516,7 @@ async def flash_light_impressively(
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
     count: int = 0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Flash the specified light impressively [default: red/blue].
 
     `light_id` is an integer value identifying a light and ranges
@@ -573,7 +592,7 @@ async def pulse_light(
     speed: Speed = Speed.Slow,
     dim: float = 1.0,
     count: int = 0,
-) -> Dict[str, Any]:
+) -> dict[str, Any]:
     """Pulse a light with a specified color [default: red].
 
     `light_id` is an integer value identifying a light and ranges