reintroduce linter

Author: Jguer

.devcontainer/Dockerfile

@@ -7,6 +7,9 @@ RUN sudo pacman -Syu --noconfirm pacman-contrib fish git-delta openssh bat go
 # Set passwordless sudo for the docker user
 RUN echo "docker ALL=(ALL) NOPASSWD: ALL" > /etc/sudoers.d/docker
 
+# Add /app/bin to the PATH
+ENV PATH="/app/bin:$PATH"
+
 # Create a non-root user and switch to it
 USER docker
 

.golangci.yml

@@ -1,68 +1,19 @@
-linters-settings:
-  dupl:
-    threshold: 100
-  funlen:
-    lines: 100
-    statements: 50
-  goconst:
-    min-len: 3
-    min-occurrences: 4
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - experimental
-      - opinionated
-      - performance
-      - style
-  gocyclo:
-    min-complexity: 15
-  goimports:
-    local-prefixes: github.com/Jguer/yay/v12
-  gomnd:
-    checks:
-      - argument
-      - case
-      - condition
-      - return
-    ignored-numbers:
-      - "0"
-      - "1"
-      - "2"
-      - "3"
-    ignored-functions:
-      - strings.SplitN
-  lll:
-    line-length: 140
-  misspell:
-    locale: US
-  nolintlint:
-    allow-unused: false # report any unused nolint directives
-    require-explanation: false # don't require an explanation for nolint directives
-    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
-
+version: "2"
+run:
+  go: "1.22"
 linters:
-  # please, do not use `enable-all`: it's deprecated and will be removed soon.
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
-  disable-all: true
+  default: none
   enable:
-    - forbidigo
     - bodyclose
+    - copyloopvar
     - dogsled
     - dupl
-    - errorlint
     - errcheck
-    - copyloopvar
-    # - funlen # TOFIX
+    - errorlint
+    - forbidigo
     - gochecknoinits
-    # - goconst # TOFIX
-    # - gocritic
-    # - gocyclo # TOFIX
-    - gofmt
-    - goimports
-    # - gomnd # TOFIX
     - goprintffuncname
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - lll
@@ -71,32 +22,75 @@ linters:
     - noctx
     - nolintlint
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unparam
     - unused
     - whitespace
-
-run:
-  go: "1.22"
-  timeout: "10m"
-
-issues:
-  exclude-rules:
-    - path: (.+)_test.go
-      linters:
-        - lll
-        - revive
-        - wsl
-        - govet
-        - godot
-        - errcheck
-        - stylecheck
-        - dupl
-        - gocritic
-        - gochecknoinits
-        - errorlint
-
-  exclude:
-    - G204
+    - revive
+  settings:
+    dupl:
+      threshold: 100
+    funlen:
+      lines: 100
+      statements: 50
+    goconst:
+      min-len: 3
+      min-occurrences: 4
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - experimental
+        - opinionated
+        - performance
+        - style
+    gocyclo:
+      min-complexity: 15
+    lll:
+      line-length: 140
+    misspell:
+      locale: US
+    nolintlint:
+      require-explanation: false
+      require-specific: false
+      allow-unused: false
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - dupl
+          - errcheck
+          - errorlint
+          - gochecknoinits
+          - gocritic
+          - godot
+          - govet
+          - lll
+          - revive
+          - staticcheck
+          - wsl
+        path: (.+)_test.go
+      - path: (.+)\.go$
+        text: G204
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/Jguer/go-alpm/v2
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

.vscode/settings.json

@@ -0,0 +1,7 @@
+{
+    "go.lintTool": "golangci-lint",
+    "gopls": {
+        "formatting.gofumpt": true,
+        "formatting.local": "github.com/Jguer/go-alpm/v2"
+    }
+}

callbacks.go

@@ -30,7 +30,7 @@ var (
 	questionCallbackContextPool = callbackContextPool{}
 )
 
-func DefaultLogCallback(ctx interface{}, lvl LogLevel, s string) {
+func DefaultLogCallback(_ interface{}, lvl LogLevel, s string) {
 	if lvl <= DefaultLogLevel {
 		fmt.Fprintln(os.Stdout, "go-alpm: ", s)
 	}

callbacks_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	alpm "github.com/Jguer/go-alpm/v2"
+
 	"github.com/stretchr/testify/require"
 )
 

package_test.go

@@ -13,6 +13,7 @@ import (
 	"time"
 
 	alpm "github.com/Jguer/go-alpm/v2"
+
 	"github.com/stretchr/testify/assert"
 )