fix(core): workaround package.json files with no name

Closes #261

Author: JamieMason

src/dependency.rs

@@ -177,7 +177,7 @@ impl Dependency {
       for instance in every_instance_in_the_project {
         if *instance.name_internal.borrow() == *self.name_internal {
           for snapped_to_package in snapped_to_packages {
-            if instance.package.borrow().get_name_unsafe() == snapped_to_package.borrow().get_name_unsafe() {
+            if instance.package.borrow().name == snapped_to_package.borrow().name {
               return Some(instance.actual_specifier.clone());
             }
           }
@@ -211,7 +211,7 @@ impl Dependency {
         }
         let specifier_order = b.actual_specifier.unwrap().cmp(&a.actual_specifier.unwrap());
         if matches!(specifier_order, Ordering::Equal) {
-          a.package.borrow().get_name_unsafe().cmp(&b.package.borrow().get_name_unsafe())
+          a.package.borrow().name.cmp(&b.package.borrow().name)
         } else {
           specifier_order
         }

src/effects/ui.rs

@@ -459,7 +459,7 @@ impl Ui<'_> {
       if self.ctx.config.cli.show_packages {
         packages
           .iter()
-          .sorted_by_key(|package| package.borrow().get_name_unsafe())
+          .sorted_by_key(|package| package.borrow().name.clone())
           .for_each(|package| {
             self.print_formatted_package(&package.borrow());
           });
@@ -486,7 +486,7 @@ impl Ui<'_> {
     if self.ctx.config.cli.show_packages {
       mismatches
         .iter()
-        .sorted_by_key(|mismatch| mismatch.package.borrow().get_name_unsafe())
+        .sorted_by_key(|mismatch| mismatch.package.borrow().name.clone())
         .for_each(|mismatch| {
           let icon = "-".dimmed();
           let package = mismatch.package.borrow();
@@ -500,9 +500,8 @@ impl Ui<'_> {
 
   /// Render a clickable link to a package.json file
   fn package_json_link(&self, package: &PackageJson) -> ColoredString {
-    let name = package.get_name_unsafe();
     let file_path = package.file_path.to_str().unwrap();
-    let plain_link = self.link(format!("file:{file_path}"), name);
+    let plain_link = self.link(format!("file:{file_path}"), package.name.clone());
     format!("{plain_link}").normal()
   }
 

src/group_selector.rs

@@ -86,11 +86,7 @@ impl GroupSelector {
   }
 
   pub fn matches_packages(&self, instance: &Instance) -> bool {
-    matches_globs(
-      &instance.package.borrow().get_name_unsafe(),
-      &self.include_packages,
-      &self.exclude_packages,
-    )
+    matches_globs(&instance.package.borrow().name, &self.include_packages, &self.exclude_packages)
   }
 
   pub fn matches_dependencies(&self, instance: &Instance) -> bool {
@@ -158,13 +154,13 @@ fn with_resolved_keywords(dependency_names: &[String], packages: &Packages) -> V
     match dependency_name.as_str() {
       "$LOCAL" => {
         for package in packages.all.iter() {
-          let package_name = package.borrow().get_name_unsafe();
+          let package_name = package.borrow().name.clone();
           resolved_dependencies.push(package_name);
         }
       }
       "!$LOCAL" => {
         for package in packages.all.iter() {
-          let package_name = package.borrow().get_name_unsafe();
+          let package_name = package.borrow().name.clone();
           resolved_dependencies.push(format!("!{}", package_name));
         }
       }

src/instance.rs

@@ -62,7 +62,7 @@ impl Instance {
     dependency_type: &DependencyType,
     package: Rc<RefCell<PackageJson>>,
   ) -> Instance {
-    let package_name = package.borrow().get_name_unsafe();
+    let package_name = package.borrow().name.clone();
     let specifier = Specifier::new(&raw_specifier);
     Instance {
       actual_specifier: specifier.clone(),

src/package_json.rs

@@ -8,6 +8,8 @@ use {
 
 #[derive(Debug)]
 pub struct PackageJson {
+  /// The name property of the package.json
+  pub name: String,
   /// The path to the package.json file
   pub file_path: PathBuf,
   /// Syncpack formatting mismatches found in the file
@@ -63,6 +65,11 @@ impl PackageJson {
             error!("Invalid JSON: {}", &file_path.to_str().unwrap());
           })
           .map(|contents: Value| Self {
+            name: contents
+              .pointer("/name")
+              .and_then(|name| name.as_str())
+              .unwrap_or("NAME_IS_MISSING")
+              .to_string(),
             file_path: file_path.clone(),
             formatting_mismatches: RefCell::new(vec![]),
             json: RefCell::new(contents.to_string()),
@@ -86,11 +93,6 @@ impl PackageJson {
     }
   }
 
-  /// Convenience method to get the name of the package
-  pub fn get_name_unsafe(&self) -> String {
-    self.get_string("/name").expect("package.json file has no name property")
-  }
-
   /// Deeply get a property in the parsed package.json
   pub fn get_prop(&self, pointer: &str) -> Option<Value> {
     self.contents.borrow().pointer(pointer).cloned()

src/packages.rs

@@ -61,11 +61,7 @@ impl Packages {
 
   /// Get a package.json file by its name
   pub fn get_by_name(&self, name: &str) -> Option<Rc<RefCell<PackageJson>>> {
-    self
-      .all
-      .iter()
-      .find(|package| package.borrow().get_name_unsafe() == name)
-      .map(Rc::clone)
+    self.all.iter().find(|package| package.borrow().name == name).map(Rc::clone)
   }
 
   /// Get every instance of a dependency from every package.json file

src/test/mock.rs

@@ -61,6 +61,11 @@ pub fn rcfile_from_mock(value: serde_json::Value) -> Rcfile {
 /// Parse a package.json string
 pub fn package_json_from_value(contents: Value) -> PackageJson {
   PackageJson {
+    name: contents
+      .pointer("/name")
+      .and_then(|name| name.as_str())
+      .unwrap_or("NAME_IS_MISSING")
+      .to_string(),
     file_path: PathBuf::new(),
     formatting_mismatches: RefCell::new(vec![]),
     json: RefCell::new(contents.to_string()),