feat(core): add fix-mismatches command

Author: JamieMason

src/bin-fix-mismatches.ts

@@ -0,0 +1,18 @@
+#!/usr/bin/env node
+
+import chalk from 'chalk';
+import * as program from 'commander';
+import * as _ from 'lodash';
+import { relative } from 'path';
+import { DEFAULT_PATTERN, OPTION_PACKAGES } from './constants';
+import { setVersionsToNewestMismatch } from './manifests';
+
+program.option(OPTION_PACKAGES.spec, OPTION_PACKAGES.description).parse(process.argv);
+
+const { packages = DEFAULT_PATTERN } = program;
+
+setVersionsToNewestMismatch(packages).then((descriptors) => {
+  _.each(descriptors, (descriptor) => {
+    console.log(chalk.blue(`./${relative('.', descriptor.path)}`));
+  });
+});

src/bin.ts

@@ -1,13 +1,12 @@
 #!/usr/bin/env node
 
 import * as program from 'commander';
-import { COMMAND_LIST, COMMAND_LIST_MISMATCHES } from './constants';
+import { FIX_MISMATCHES, LIST, LIST_MISMATCHES } from './constants';
 
 program
   .version('TODO')
-  .command(COMMAND_LIST.name, COMMAND_LIST.description, {
-    isDefault: true
-  })
-  .command(COMMAND_LIST_MISMATCHES.name, COMMAND_LIST_MISMATCHES.description);
+  .command(FIX_MISMATCHES.name, FIX_MISMATCHES.description)
+  .command(LIST.name, LIST.description, { isDefault: true })
+  .command(LIST_MISMATCHES.name, LIST_MISMATCHES.description);
 
 program.parse(process.argv);

src/constants.ts

@@ -1,10 +1,14 @@
 import { IManifestKey } from './typings';
 
-export const COMMAND_LIST = {
+export const FIX_MISMATCHES = {
+  description: 'set dependencies used with different versions to the same version',
+  name: 'fix-mismatches'
+};
+export const LIST = {
   description: 'list every dependency used in your packages',
   name: 'list'
 };
-export const COMMAND_LIST_MISMATCHES = {
+export const LIST_MISMATCHES = {
   description: 'list every dependency used with different versions in your packages',
   name: 'list-mismatches'
 };

src/lib/write-json.ts

@@ -1,9 +1,10 @@
 import { writeFile } from 'fs';
 
-export const writeJson = (location: string, contents: string): Promise<void> =>
+export const formatJson = (contents: object) => `${JSON.stringify(contents, null, 2)}\n`;
+
+export const writeJson = (location: string, contents: object): Promise<void> =>
   new Promise((resolve, reject) => {
-    const json = `${JSON.stringify(contents, null, 2)}\n`;
-    writeFile(location, json, { encoding: 'utf8' }, (err) => {
+    writeFile(location, formatJson(contents), { encoding: 'utf8' }, (err) => {
       err ? reject(err) : resolve();
     });
   });

src/manifests/index.spec.ts

@@ -1,6 +1,7 @@
+import { readFileSync } from 'fs';
 import * as mock from 'mock-fs';
-import { createManifest, createMockDescriptor, createMockFs } from '../../test/helpers';
-import { IManifest } from '../typings';
+import { createFile, createManifest, createMockDescriptor, createMockFs } from '../../test/helpers';
+import { IManifest, IManifestDescriptor } from '../typings';
 import { getMismatchedVersions, getVersions, setVersion, setVersionRange, setVersionsToNewestMismatch } from './index';
 
 const pattern = '/Users/you/Dev/monorepo/packages/*/package.json';
@@ -85,7 +86,7 @@ describe('setVersionRange', () => {
 });
 
 describe('setVersionsToNewestMismatch', () => {
-  it('sets the version of dependencies with different versions to the newest of those versions found', async () => {
+  it('sets all dependencies used with different versions to the newest of those versions', async () => {
     const result = await setVersionsToNewestMismatch(pattern);
     expect(result).toEqual(
       expect.arrayContaining([
@@ -100,4 +101,21 @@ describe('setVersionsToNewestMismatch', () => {
       ])
     );
   });
+  it('rewrites the updated manifests with the correct data', async () => {
+    await setVersionsToNewestMismatch(pattern);
+    expect(readFileSync('/Users/you/Dev/monorepo/packages/foo/package.json', 'utf8')).toEqual(
+      createFile(
+        'foo',
+        { chalk: '2.3.0', commander: '2.13.0' },
+        { jest: '22.1.4', prettier: '1.10.2', rimraf: '2.6.2' },
+        { gulp: '*' }
+      )
+    );
+    expect(readFileSync('/Users/you/Dev/monorepo/packages/bar/package.json', 'utf8')).toEqual(
+      createFile('bar', { chalk: '2.3.0' }, { jest: '22.1.4' })
+    );
+    expect(readFileSync('/Users/you/Dev/monorepo/packages/baz/package.json', 'utf8')).toEqual(
+      createFile('baz', {}, { npm: 'https://github.com/npm/npm.git', prettier: '1.10.2' }, { gulp: '*' })
+    );
+  });
 });

src/manifests/index.ts

@@ -1,4 +1,5 @@
 import { DEFAULT_PATTERN } from '../constants';
+import { writeJson } from '../lib/write-json';
 import { IDictionary, IManifest, IManifestDescriptor } from '../typings';
 import { getManifests } from './get-manifests';
 import { manifestData } from './manifest-data';
@@ -34,7 +35,15 @@ export const setVersionRange: SetVersionRange = (range, pattern = DEFAULT_PATTER
   });
 
 export const setVersionsToNewestMismatch: SetVersionsToNewestMismatch = (pattern = DEFAULT_PATTERN) =>
-  getManifests(pattern).then((descriptors) => {
-    manifestData.setVersionsToNewestMismatch(unwrap(descriptors));
-    return descriptors;
-  });
+  getManifests(pattern)
+    .then((descriptors) => {
+      const data = unwrap(descriptors);
+      const nextData = manifestData.setVersionsToNewestMismatch(data);
+      return descriptors.map((descriptor, i) => ({
+        data: nextData[i],
+        path: descriptor.path
+      }));
+    })
+    .then((descriptors) =>
+      Promise.all(descriptors.map((descriptor) => writeJson(descriptor.path, descriptor.data))).then(() => descriptors)
+    );

test/helpers.ts

@@ -1,13 +1,24 @@
+import { formatJson } from '../src/lib/write-json';
 import { IDictionary, IManifest, IManifestDescriptor } from '../src/typings';
 
+export const createFile = (
+  name: string,
+  dependencies: IManifest['dependencies'] = {},
+  devDependencies: IManifest['devDependencies'] = {},
+  peerDependencies: IManifest['peerDependencies'] = {}
+) => formatJson(createManifest(name, dependencies, devDependencies, peerDependencies));
+
 export const createMockFs = (
   name: string,
   dependencies: IManifest['dependencies'] = {},
   devDependencies: IManifest['devDependencies'] = {},
   peerDependencies: IManifest['peerDependencies'] = {}
 ): { [path: string]: string } => ({
-  [`/Users/you/Dev/monorepo/packages/${name}/package.json`]: JSON.stringify(
-    createManifest(name, dependencies, devDependencies, peerDependencies)
+  [`/Users/you/Dev/monorepo/packages/${name}/package.json`]: createFile(
+    name,
+    dependencies,
+    devDependencies,
+    peerDependencies
   )
 });