Skip to content

Conversation

@rosiel
Copy link
Contributor

@rosiel rosiel commented Oct 24, 2023

#112

This PR causes the Starter Site to have Config Override Inspector installed.

It configures the module to

  • grey out (disable) the overridden form element
  • display the real (override) value, unless it's marked as secret
  • display a message, "This field is overridden by settings.php configuration."

It relies on the module forms including a config key which most don't. There are PRs for islandora and openseadragon to mark up the appropriate form elements, but some values we (site template) override are for search_api and matomo and they're not COI-compatible. So this will (as of now) have only a partial effect.

@Islandora-Devops/committers

@aOelschlager aOelschlager self-requested a review November 8, 2023 18:32
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this to test the two COI prs (Islandora/openseadragon#57, Islandora/islandora#986)
It works!
Needs to pull in the newest commits in main and it's ready to go!

@aOelschlager aOelschlager merged commit f9c671e into Islandora-Devops:main Nov 17, 2023
@rosiel rosiel deleted the coi branch March 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants