ref: make workspace diagnostics more accurate

Author: Iron-E

lua/libmodal/src/Layer.lua

@@ -1,4 +1,7 @@
+--- @type libmodal.globals
 local globals = require 'libmodal/src/globals'
+
+--- @type libmodal.utils
 local utils = require 'libmodal/src/utils'
 
 --- Normalizes a `buffer = true|false|0` argument into a number.
@@ -143,6 +146,12 @@ function Layer:map(mode, lhs, rhs, options)
 	end
 end
 
+--- @param keymaps_by_mode table the keymaps (e.g. `{n = {gg = {rhs = 'G', silent = true}}}`)
+--- @return libmodal.Layer
+function Layer.new(keymaps_by_mode)
+	return setmetatable({existing_keymaps_by_mode = {}, layer_keymaps_by_mode = keymaps_by_mode, active = false}, Layer)
+end
+
 --- restore one keymapping to its original state.
 --- @param buffer? number the buffer to unmap from (`nil` if it is not buffer-local)
 --- @param mode string the mode of the keymap.
@@ -175,11 +184,4 @@ function Layer:unmap(buffer, mode, lhs)
 	self.existing_keymaps_by_mode[mode][lhs] = nil
 end
 
-return
-{
-	--- @param keymaps_by_mode table the keymaps (e.g. `{n = {gg = {rhs = 'G', silent = true}}}`)
-	--- @return libmodal.Layer
-	new = function(keymaps_by_mode)
-		return setmetatable({existing_keymaps_by_mode = {}, layer_keymaps_by_mode = keymaps_by_mode, active = false}, Layer)
-	end
-}
+return Layer

lua/libmodal/src/Mode.lua

@@ -1,6 +1,11 @@
-local globals    = require 'libmodal/src/globals'
+--- @type libmodal.globals
+local globals = require 'libmodal/src/globals'
+
+--- @type libmodal.collections.ParseTable
 local ParseTable = require 'libmodal/src/collections/ParseTable'
-local utils      = require 'libmodal/src/utils'
+
+--- @type libmodal.utils
+local utils = require 'libmodal/src/utils'
 
 --- @class libmodal.Mode
 --- @field private exit libmodal.utils.Vars
@@ -111,6 +116,7 @@ function Mode:enter()
 
 		-- if there were errors, handle them.
 		if not ok then
+			--- @diagnostic disable-next-line:param-type-mismatch if `not ok` then `mode_result` is a string
 			utils.notify_error('Error during nvim-libmodal mode', mode_result)
 			continue_mode = false
 		else
@@ -195,7 +201,7 @@ return
 		local self = setmetatable(
 			{
 				exit = utils.Vars.new('exit', name),
-				indicator = utils.Indicator.mode(name),
+				indicator = utils.Indicator.new('LibmodalPrompt', '-- ' .. name .. ' --'),
 				input = utils.Vars.new('input', name),
 				instruction = instruction,
 				name = name,
@@ -213,6 +219,7 @@ return
 
 			-- determine if a default `Help` should be created.
 			if not self.instruction[HELP] then
+				--- @diagnostic disable-next-line:param-type-mismatch we checked that `instruction` is a table above
 				self.help = utils.Help.new(self.instruction, 'KEY MAP')
 			end
 

lua/libmodal/src/Prompt.lua

@@ -1,4 +1,7 @@
+--- @type libmodal.globals
 local globals = require 'libmodal/src/globals'
+
+--- @type libmodal.utils
 local utils = require 'libmodal/src/utils'
 
 --- @class libmodal.Prompt
@@ -95,6 +98,7 @@ function Prompt:enter()
 
 		-- if there were errors.
 		if not ok then
+			--- @diagnostic disable-next-line:param-type-mismatch if `not ok` then `mode_result` is a string
 			utils.notify_error('Error during nvim-libmodal mode', prompt_result)
 			continue_mode = false
 		else
@@ -116,7 +120,7 @@ return
 		local self = setmetatable(
 			{
 				exit         = utils.Vars.new('exit', name),
-				indicator    = utils.Indicator.prompt(name),
+				indicator    = utils.Indicator.new('LibmodalStar', '* ' .. name .. ' > '),
 				input        = utils.Vars.new('input', name),
 				instruction = instruction,
 				name        = name
@@ -140,6 +144,7 @@ return
 
 			if not contained_help then -- assign it.
 				completions[#completions + 1] = HELP
+				--- @diagnostic disable-next-line:param-type-mismatch we checked that `instruction` is a table above
 				self.help = utils.Help.new(instruction, 'COMMAND')
 			end
 

lua/libmodal/src/collections/ParseTable.lua

@@ -1,9 +1,12 @@
---- the number corresponding to <CR> in vim.
-local CR   = 13
+--- @type libmodal.globals
 local globals = require 'libmodal/src/globals'
 
+--- the number corresponding to <CR> in vim.
+local CR = string.byte(vim.api.nvim_replace_termcodes('<CR>', true, true, true))
+
 --- @class libmodal.collections.ParseTable
-local ParseTable = require('libmodal/src/utils/classes').new(nil)
+--- @field CR number the byte representation of `<CR>`
+local ParseTable = require('libmodal/src/utils/classes').new {CR = CR}
 
 --- reverse the order of elements in some `tbl`
 --- @param tbl table the table to reverse
@@ -93,6 +96,19 @@ function ParseTable:get(key_dict)
 	return get(self, table_reverse(key_dict))
 end
 
+--- create a new `libmodal.collections.ParseTable` from a user-provided table.
+--- @param user_table table keymaps (e.g. `{zfo = 'tabnew'}`)
+--- @return libmodal.collections.ParseTable
+function ParseTable.new(user_table)
+	local self = setmetatable({}, ParseTable)
+
+	-- parse the passed in table.
+	self:parse_put_all(user_table)
+
+	-- return the new `ParseTable`.
+	return self
+end
+
 --- parse `key` and retrieve its value
 --- @param key string the left-hand-side of the mapping to retrieve
 --- @return false|fun()|nil|string|table match a string/func when fully found; a table when partially found; false when not found.
@@ -123,20 +139,4 @@ function ParseTable:parse_put_all(keys_and_values)
 	end
 end
 
-return
-{
-	CR = CR,
-
-	--- create a new `libmodal.collections.ParseTable` from a user-provided table.
-	--- @param user_table table keymaps (e.g. `{zfo = 'tabnew'}`)
-	--- @return libmodal.collections.ParseTable
-	new = function(user_table)
-		local self = setmetatable({}, ParseTable)
-
-		-- parse the passed in table.
-		self:parse_put_all(user_table)
-
-		-- return the new `ParseTable`.
-		return self
-	end,
-}
+return ParseTable

lua/libmodal/src/collections/Stack.lua

@@ -1,6 +1,11 @@
 --- @class libmodal.collections.Stack
 local Stack = require('libmodal/src/utils/classes').new(nil)
 
+--- @return libmodal.collections.Stack
+function Stack.new()
+	return setmetatable({}, Stack)
+end
+
 --- @return unknown top the foremost value of the stack
 function Stack:peek()
 	return self[#self]
@@ -19,9 +24,4 @@ function Stack:push(value)
 	self[#self + 1] = value
 end
 
-return
-{
-	new = function()
-		return setmetatable({}, Stack)
-	end,
-}
+return Stack

lua/libmodal/src/collections/init.lua

@@ -4,5 +4,5 @@
 return
 {
 	ParseTable = require 'libmodal/src/collections/ParseTable',
-	Stack      = require 'libmodal/src/collections/Stack'
+	Stack = require 'libmodal/src/collections/Stack'
 }

lua/libmodal/src/globals.lua

@@ -1,48 +1,34 @@
-local VIM_FALSE = 0
-local VIM_TRUE  = 1
-
 --- @class libmodal.globals
---- @field private ESC_NR number
---- @field private TYPE_FUNC string
---- @field private TYPE_NUM string
---- @field private TYPE_STR string
---- @field private TYPE_TBL string
---- @field private VIM_FALSE number
---- @field private VIM_TRUE number
-return
+--- @field ESC_NR number the key-code for the escape character.
+--- @field TYPE_FUNC string the string which is returned by `type(function() end)` (or any function)
+--- @field TYPE_NUM string the string which is returned by `type(0)` (or any number)
+--- @field TYPE_STR string the string which is returned by `type ''` (or any string)
+--- @field TYPE_TBL string the string which is returned by `type {}` (or any table)
+--- @field VIM_FALSE number the value of Vimscript's `v:false`
+--- @field VIM_TRUE number the value of Vimscript's `v:true`
+local globals =
 {
-	--- the key-code for the escape character.
 	ESC_NR = 27,
-
-	--- the string which is returned by `type(function() end)` (or any function)
 	TYPE_FUNC = type(function() end),
-
-	--- the string which is returned by `type(0)` (or any number)
 	TYPE_NUM  = type(0),
-
-	--- the string which is returned by `type ''` (or any string)
 	TYPE_STR = type '',
-
-	--- the string which is returned by `type {}` (or any table)
 	TYPE_TBL = type {},
-
-	--- the value of Vimscript's `v:false`
-	VIM_FALSE = VIM_FALSE,
-
-	--- the value of Vimscript's `v:true`
-	VIM_TRUE  = VIM_TRUE,
-
-	--- assert some value is either `false` or `v:false`.
-	--- @param val boolean|number
-	--- @return boolean
-	is_false = function(val)
-		return val == false or val == VIM_FALSE
-	end,
-
-	--- assert some value is either `true` or `v:true`.
-	--- @param val boolean|number
-	--- @return boolean
-	is_true = function(val)
-		return val == true or val == VIM_TRUE
-	end
+	VIM_FALSE = 0,
+	VIM_TRUE  = 1,
 }
+
+--- assert some value is either `false` or `v:false`.
+--- @param val boolean|number
+--- @return boolean
+function globals.is_false(val)
+	return val == false or val == globals.VIM_FALSE
+end
+
+--- assert some value is either `true` or `v:true`.
+--- @param val boolean|number
+--- @return boolean
+function globals.is_true(val)
+	return val == true or val == globals.VIM_TRUE
+end
+
+return globals

lua/libmodal/src/init.lua

@@ -1,16 +1,18 @@
 --- @class libmodal
---- @field private collections libmodal.collections
---- @field private globals libmodal.globals
---- @field private Layer libmodal.Layer
---- @field private Mode libmodal.Mode
---- @field private Prompt libmodal.Prompt
---- @field private utils libmodal.utils
-return
+--- @field collections libmodal.collections
+--- @field globals libmodal.globals
+--- @field Layer libmodal.Layer
+--- @field Mode libmodal.Mode
+--- @field Prompt libmodal.Prompt
+--- @field utils libmodal.utils
+local libmodal =
 {
 	collections = require 'libmodal/src/collections',
-	globals     = require 'libmodal/src/globals',
-	Layer       = require 'libmodal/src/Layer',
-	Mode        = require 'libmodal/src/Mode',
-	Prompt      = require 'libmodal/src/Prompt',
-	utils       = require 'libmodal/src/utils',
+	globals = require 'libmodal/src/globals',
+	Layer = require 'libmodal/src/Layer',
+	Mode = require 'libmodal/src/Mode',
+	Prompt = require 'libmodal/src/Prompt',
+	utils = require 'libmodal/src/utils',
 }
+
+return libmodal

lua/libmodal/src/utils/Help.lua

@@ -1,3 +1,4 @@
+--- @type libmodal.globals
 local globals = require 'libmodal/src/globals'
 
 --- @class libmodal.utils.Help
@@ -27,6 +28,32 @@ local function align_columns(tbl, longest_key_len)
 	return to_print
 end
 
+--- create a default help table with `commands_or_maps` and vim expressions.
+--- @param commands_or_maps {[string]: fun()|string} commands or mappings to vim expressions.
+--- @param title string
+--- @return libmodal.utils.Help
+function Help.new(commands_or_maps, title)
+	-- find the longest key in the table, or at least the length of the title
+	local longest_key_maps = string.len(title)
+	for key, _ in pairs(commands_or_maps) do
+		local key_len = string.len(key)
+		if key_len > longest_key_maps then
+			longest_key_maps = key_len
+		end
+	end
+
+	-- create a new `Help`.
+	return setmetatable(
+		{
+			[1] = ' ',
+			[2] = table.concat(align_columns({[title] = 'VIM EXPRESSION'}, longest_key_maps)),
+			[3] = table.concat(align_columns({[string.rep('-', string.len(title))] = '--------------'}, longest_key_maps)),
+			[4] = table.concat(align_columns(commands_or_maps, longest_key_maps)),
+		},
+		Help
+	)
+end
+
 --- show the contents of this `Help`.
 function Help:show()
 	for _, help_text in ipairs(self) do
@@ -35,33 +62,4 @@ function Help:show()
 	vim.fn.getchar()
 end
 
---[[/* CLASS `Help` */]]
-
-return
-{
-	--- create a default help table with `commands_or_maps` and vim expressions.
-	--- @param commands_or_maps {[string]: fun()|string} commands or mappings to vim expressions.
-	--- @param title string
-	--- @return libmodal.utils.Help
-	new = function(commands_or_maps, title)
-		-- find the longest key in the table, or at least the length of the title
-		local longest_key_maps = string.len(title)
-		for key, _ in pairs(commands_or_maps) do
-			local key_len = string.len(key)
-			if key_len > longest_key_maps then
-				longest_key_maps = key_len
-			end
-		end
-
-		-- create a new `Help`.
-		return setmetatable(
-			{
-				[1] = ' ',
-				[2] = table.concat(align_columns({[title] = 'VIM EXPRESSION'}, longest_key_maps)),
-				[3] = table.concat(align_columns({[string.rep('-', string.len(title))] = '--------------'}, longest_key_maps)),
-				[4] = table.concat(align_columns(commands_or_maps, longest_key_maps)),
-			},
-			Help
-		)
-	end
-}
+return Help